Re: [RFC 2/4] stk: Handle Launch Browser proactive command

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

Hi Jeevaka,

On 01/13/2011 08:56 AM, Jeevaka.Badrappan(a)elektrobit.com wrote:
> Hi,
> 
>>>
>>> So a question about this.  Why are we checking the netreg atom?
>>> Shouldn't we be checking the gprs atom's attached property?  But this
>>> brings up an even more interesting question, do we even need to
>>> assume that we have to be attached to the cellular network to
>>> perform these operations?  We could in theory go over wifi.
>>
>> I agree that the modem online property is unrelated to this.
>> Also the card may in theory specify a URL that designates a
>> local file or something on a local network, not the internet.
>>
> 
> Agree. It can be anything not only cellular network. Do we need
> to check the bearer parameters in that case or can I just remove the
> current check code?

Good point on the bearer parameters.  My take is that we should either
ignore the bearer parameters or return not-capable if they're set.
Otherwise removing the current checks in the code seems reasonable to me.

Regards,
-Denis