From: Paolo Bonzini <pbonzini@redhat.com>
To: David Ahern <daahern@cisco.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 8/8] x86_64 config: fix compile for CONFIG_FDC=n
Date: Thu, 13 Jan 2011 18:04:38 +0100 [thread overview]
Message-ID: <4D2F30A6.4050108@redhat.com> (raw)
In-Reply-To: <1294900477-23722-9-git-send-email-daahern@cisco.com>
On 01/13/2011 07:34 AM, David Ahern wrote:
>
> +#ifdef CONFIG_FDC
> /* floppy type */
>
> fd0 = fdctrl_get_drive_type(floppy_controller, 0);
> @@ -403,6 +408,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t above_4g_mem_size,
> val |= 0x02; /* FPU is there */
> val |= 0x04; /* PS/2 mouse installed */
> rtc_set_memory(s, REG_EQUIPMENT_BYTE, val);
> +#endif
Isn't it a bit too eager? The equipment byte should still be set, or
have you checked with a real machine?
Paolo
next prev parent reply other threads:[~2011-01-13 17:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 6:34 [Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling config settings David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 1/8] fix 'no such file' error from make_device_config.sh David Ahern
2011-01-13 13:43 ` Markus Armbruster
2011-01-13 14:40 ` David Ahern
2011-01-14 10:34 ` Markus Armbruster
2011-01-14 15:13 ` David Ahern
2011-01-14 19:57 ` Stefan Weil
2011-01-14 22:01 ` Blue Swirl
2011-01-13 6:34 ` [Qemu-devel] [PATCH 2/8] x86_64 config: fix compile for CONFIG_VMWARE_VGA=n David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 3/8] x86_64 config: fix compile for CONFIG_PARALLEL=n David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 4/8] remove unused parallel_* variables from pc.c David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 5/8] x86_64 config: fix compile for CONFIG_NE2000_ISA=n David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 6/8] x86_64 config: fix compile for CONFIG_VGA_ISA=n David Ahern
2011-01-13 17:02 ` [Qemu-devel] " Paolo Bonzini
2011-01-13 17:28 ` David Ahern
2011-01-14 7:31 ` Paolo Bonzini
2011-01-14 17:49 ` David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 7/8] x86_64 config: fix compile for CONFIG_IDE_ISA=n David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 8/8] x86_64 config: fix compile for CONFIG_FDC=n David Ahern
2011-01-13 17:04 ` Paolo Bonzini [this message]
2011-01-13 17:25 ` [Qemu-devel] " David Ahern
2011-01-13 9:57 ` [Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling config settings Isaku Yamahata
2011-01-13 14:30 ` David Ahern
2011-01-13 17:06 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2F30A6.4050108@redhat.com \
--to=pbonzini@redhat.com \
--cc=daahern@cisco.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.