Re: [Qemu-devel] [PATCH 1/8] fix 'no such file' error from make_device_config.sh

[David Ahern <daahern@cisco.com>]

On 01/14/11 03:34, Markus Armbruster wrote:

>>> What about:
>>>
>>> diff --git a/make_device_config.sh b/make_device_config.sh
>>> index 596fc5b..711829c 100644
>>> --- a/make_device_config.sh
>>> +++ b/make_device_config.sh
>>> @@ -18,7 +18,7 @@ process_includes () {
>>>  
>>>  f=$src
>>>  while [ -n "$f" ] ; do
>>> -  f=`tr -d '\r' < $f | awk '/^include / {ORS=" "; print "'$src_dir'/" $2}'`
>>> +  f=`tr -d '\r' <"$f" | awk '/^include / {print "'$src_dir'/" $2}'`
>>>    [ $? = 0 ] || exit 1
>>>    all_includes="$all_includes $f"
>>>  done
>>
>> That works too.
> 
> Care to respin your patch?

done.

> 
>> Any idea why the '%/config-devices.mak' rule does not work for a build
>> directory != src directory?
>>
>> e.g., src=/my/qemu.git, build=/tmp/build-qemu
>>
>> x86_64-softmmu/config-devices.mak is not created, so
>> config-all-devices.mak is empty and the build blows up.
> 
> Should be debuggable :)
> 
> "mkdir bld && cd bld && ./configure --disable-werror && make" works for
> me.  config-all-devices.mak has some 80 entries.

And it works for me too. Must have been an 11pm phenomenon.

David