From: Stephen Boyd <sboyd@codeaurora.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
Colin Cross <ccross@android.com>,
Daniel Walker <dwalker@codeaurora.org>,
David Brown <davidb@codeaurora.org>,
Erik Gilling <konkers@android.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Olof Johansson <olof@lixom.net>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Tony Lindgren <tony@atomide.com>,
linux-tegra@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] TWD: enable one-shot mode
Date: Fri, 14 Jan 2011 10:45:08 -0800 [thread overview]
Message-ID: <4D3099B4.40900@codeaurora.org> (raw)
In-Reply-To: <20110111115209.GA12781@n2100.arm.linux.org.uk>
On 01/11/2011 03:52 AM, Russell King - ARM Linux wrote:
> On Mon, Jan 10, 2011 at 09:12:36PM -0800, Stephen Boyd wrote:
>>
>> I see this patch was already tested and merged but can you elaborate on
>> why this was done? From what I understand, NOHZ selects one-shot (like
>> is done in this patch), so why don't the machines with a TWD choose NOHZ
>> or high res timers?
>
> You're right - so it's not actually required. It should probably be
> reverted, though it does no damage...
Now I'm wondering why there are other 'select TICK_ONESHOT' lines in
arch/arm/Kconfig. Can we just remove them all? Otherwise it feels like
we're making it confusing for others later on.
----->8---[cut here]----8<-----
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e2f8011..7750a78 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -532,7 +532,6 @@ config ARCH_MMP
select CLKDEV_LOOKUP
select GENERIC_CLOCKEVENTS
select HAVE_SCHED_CLOCK
- select TICK_ONESHOT
select PLAT_PXA
select SPARSE_IRQ
help
@@ -613,7 +612,6 @@ config ARCH_PXA
select ARCH_REQUIRE_GPIOLIB
select GENERIC_CLOCKEVENTS
select HAVE_SCHED_CLOCK
- select TICK_ONESHOT
select PLAT_PXA
select SPARSE_IRQ
help
@@ -668,7 +666,6 @@ config ARCH_SA1100
select GENERIC_CLOCKEVENTS
select HAVE_CLK
select HAVE_SCHED_CLOCK
- select TICK_ONESHOT
select ARCH_REQUIRE_GPIOLIB
help
Support for StrongARM 11x0 based boards.
@@ -1300,7 +1297,6 @@ config HAVE_ARM_SCU
config HAVE_ARM_TWD
bool
depends on SMP
- select TICK_ONESHOT
help
This options enables support for the ARM timer and watchdog unit
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] TWD: enable one-shot mode
Date: Fri, 14 Jan 2011 10:45:08 -0800 [thread overview]
Message-ID: <4D3099B4.40900@codeaurora.org> (raw)
In-Reply-To: <20110111115209.GA12781@n2100.arm.linux.org.uk>
On 01/11/2011 03:52 AM, Russell King - ARM Linux wrote:
> On Mon, Jan 10, 2011 at 09:12:36PM -0800, Stephen Boyd wrote:
>>
>> I see this patch was already tested and merged but can you elaborate on
>> why this was done? From what I understand, NOHZ selects one-shot (like
>> is done in this patch), so why don't the machines with a TWD choose NOHZ
>> or high res timers?
>
> You're right - so it's not actually required. It should probably be
> reverted, though it does no damage...
Now I'm wondering why there are other 'select TICK_ONESHOT' lines in
arch/arm/Kconfig. Can we just remove them all? Otherwise it feels like
we're making it confusing for others later on.
----->8---[cut here]----8<-----
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e2f8011..7750a78 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -532,7 +532,6 @@ config ARCH_MMP
select CLKDEV_LOOKUP
select GENERIC_CLOCKEVENTS
select HAVE_SCHED_CLOCK
- select TICK_ONESHOT
select PLAT_PXA
select SPARSE_IRQ
help
@@ -613,7 +612,6 @@ config ARCH_PXA
select ARCH_REQUIRE_GPIOLIB
select GENERIC_CLOCKEVENTS
select HAVE_SCHED_CLOCK
- select TICK_ONESHOT
select PLAT_PXA
select SPARSE_IRQ
help
@@ -668,7 +666,6 @@ config ARCH_SA1100
select GENERIC_CLOCKEVENTS
select HAVE_CLK
select HAVE_SCHED_CLOCK
- select TICK_ONESHOT
select ARCH_REQUIRE_GPIOLIB
help
Support for StrongARM 11x0 based boards.
@@ -1300,7 +1297,6 @@ config HAVE_ARM_SCU
config HAVE_ARM_TWD
bool
depends on SMP
- select TICK_ONESHOT
help
This options enables support for the ARM timer and watchdog unit
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-01-14 18:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-24 19:18 [PATCH] TWD: enable one-shot mode Russell King - ARM Linux
2010-12-24 19:18 ` Russell King - ARM Linux
2010-12-24 19:18 ` Russell King - ARM Linux
2010-12-28 1:17 ` Linus Walleij
2010-12-28 1:17 ` Linus Walleij
2011-01-11 5:12 ` Stephen Boyd
2011-01-11 5:12 ` Stephen Boyd
2011-01-11 11:52 ` Russell King - ARM Linux
2011-01-11 11:52 ` Russell King - ARM Linux
2011-01-14 18:45 ` Stephen Boyd [this message]
2011-01-14 18:45 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3099B4.40900@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=ccross@android.com \
--cc=davidb@codeaurora.org \
--cc=dwalker@codeaurora.org \
--cc=kgene.kim@samsung.com \
--cc=konkers@android.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=srinidhi.kasagar@stericsson.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.