From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 4/6] netfilter: reduce NF_VERDICT_MASK to 0xff
Date: Sat, 15 Jan 2011 15:29:02 +0100 [thread overview]
Message-ID: <4D31AF2E.8030305@netfilter.org> (raw)
In-Reply-To: <4D305836.8080007@trash.net>
On 14/01/11 15:05, Patrick McHardy wrote:
> On 12.01.2011 21:52, Florian Westphal wrote:
>> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>>>> /* only for userspace compatibility */
>>>> #ifndef __KERNEL__
>>>> @@ -41,6 +44,9 @@
>>>> <= 0x2000 is used for protocol-flags. */
>>>> #define NFC_UNKNOWN 0x4000
>>>> #define NFC_ALTERED 0x8000
>>>> +
>>>> +/* NF_VERDICT_BITS should be 8 now, but userspace might break if this changes */
>>>> +#define NF_VERDICT_BITS 16
>>>> #endif
>>>
>>> i don't find any use of this in user-space.
>>
>> Alright, I will simply remove it, then :-)
>
> I think we should still keep it around in the compat section,
> just because we don't know of any userspace code using this
> doesn't mean it doesn't exist.
Yes, that's true, but I don't fine any sane use of that macro in userspace.
next prev parent reply other threads:[~2011-01-15 14:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-26 23:58 [PATCH] NFQUEUE v2 target with 'queue bypass' support Florian Westphal
2010-12-26 23:58 ` [PATCH 1/6] netfilter: kconfig: NFQUEUE is useless without NETFILTER_NETLINK_QUEUE Florian Westphal
2010-12-27 8:41 ` Jan Engelhardt
2010-12-27 8:47 ` Michał Mirosław
2010-12-26 23:58 ` [PATCH 2/6] netfilter: nfnetlink_queue: return error number to caller Florian Westphal
2011-01-12 18:56 ` Pablo Neira Ayuso
2011-01-12 20:49 ` Florian Westphal
2011-01-12 21:59 ` Pablo Neira Ayuso
2011-01-13 0:14 ` Florian Westphal
2010-12-26 23:58 ` [PATCH 3/6] netfilter: nfnetlink_queue: do not free skb on error Florian Westphal
2011-01-12 19:01 ` Pablo Neira Ayuso
2011-01-12 20:50 ` Florian Westphal
2010-12-26 23:58 ` [PATCH 4/6] netfilter: reduce NF_VERDICT_MASK to 0xff Florian Westphal
2011-01-12 19:02 ` Pablo Neira Ayuso
2011-01-12 20:52 ` Florian Westphal
2011-01-14 14:05 ` Patrick McHardy
2011-01-15 14:29 ` Pablo Neira Ayuso [this message]
2011-01-15 14:33 ` Patrick McHardy
2010-12-26 23:58 ` [PATCH 5/6] netfilter: allow NFQUEUE bypass if no listener is available Florian Westphal
2011-01-12 19:03 ` Pablo Neira Ayuso
2010-12-26 23:58 ` [PATCH 6/6] netfilter: do not omit re-route check on NF_QUEUE verdict Florian Westphal
-- strict thread matches above, loose matches on Subject: below --
2011-01-16 13:19 [PATCH v2] NFQUEUE v2 target with 'queue bypass' support Florian Westphal
2011-01-16 13:19 ` [PATCH 4/6] netfilter: reduce NF_VERDICT_MASK to 0xff Florian Westphal
2011-01-18 14:52 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D31AF2E.8030305@netfilter.org \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.