From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>,
David Barr <david.barr@cordelta.com>,
Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: [PATCH] svndump.c: Fix a printf format compiler warning
Date: Sat, 15 Jan 2011 18:06:27 +0000 [thread overview]
Message-ID: <4D31E223.3080001@ramsay1.demon.co.uk> (raw)
In-Reply-To: <20110111183927.GF15133@burratino>
Jonathan Nieder wrote:
> Ramsay Jones wrote:
>
>> --- a/vcs-svn/svndump.c
>> +++ b/vcs-svn/svndump.c
>> @@ -211,7 +211,7 @@ void svndump_read(const char *url)
>> if (key == keys.svn_fs_dump_format_version) {
>> dump_ctx.version = atoi(val);
>> if (dump_ctx.version > 2)
>> - die("expected svn dump format version <= 2, found %d",
>> + die("expected svn dump format version <= 2, found %"PRIu32,
>> dump_ctx.version);
>
> Acked-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks!
> I think we should just use "int", but that is a wider sweeping change
> for another time. Thanks.
>
> Does gcc or sparse provide a warning that could have caught this
> mistake?
None that I know of, no ... :(
ATB,
Ramsay Jones
prev parent reply other threads:[~2011-01-15 18:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 18:17 [PATCH] svndump.c: Fix a printf format compiler warning Ramsay Jones
2011-01-11 18:39 ` Jonathan Nieder
2011-01-15 18:06 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D31E223.3080001@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=artagnon@gmail.com \
--cc=david.barr@cordelta.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.