[PATCH 2/2] sctp: Remove store to ret as it is not used

[PATCH 2/2] sctp: Remove store to ret as it is not used

[Holger Hans Peter Freyther]

From: Holger Hans Peter Freyther <zecke@selfish.org>

The store to ret is not needed. In case it is 0 the method
will be exited directly, if not ret will be assigned again
and then returned to the caller.

Signed-off-by: Holger Hans Peter Freyther <zecke@selfish.org>
---
 net/sctp/socket.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index e47e39e..b8dad82 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -393,7 +393,7 @@ SCTP_STATIC int sctp_do_bind(struct sock *sk, union sctp_addr *addr, int len)
 	 * detection.
 	 */
 	addr->v4.sin_port = htons(snum);
-	if ((ret = sctp_get_port_local(sk, addr))) {
+	if (sctp_get_port_local(sk, addr)) {
 		return -EADDRINUSE;
 	}
 
-- 
1.7.3.4

Re: [PATCH 2/2] sctp: Remove store to ret as it is not used

[Wei Yongjun]

> From: Holger Hans Peter Freyther <zecke@selfish.org>
>
> The store to ret is not needed. In case it is 0 the method
> will be exited directly, if not ret will be assigned again
> and then returned to the caller.
>
> Signed-off-by: Holger Hans Peter Freyther <zecke@selfish.org>
> ---
>  net/sctp/socket.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index e47e39e..b8dad82 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -393,7 +393,7 @@ SCTP_STATIC int sctp_do_bind(struct sock *sk, union sctp_addr *addr, int len)
>  	 * detection.
>  	 */
>  	addr->v4.sin_port = htons(snum);
> -	if ((ret = sctp_get_port_local(sk, addr))) {
> +	if (sctp_get_port_local(sk, addr)) {
>  		return -EADDRINUSE;
>  	}

shoud be change to:

-	if ((ret = sctp_get_port_local(sk, addr))) {
+	if (sctp_get_port_local(sk, addr))
  		return -EADDRINUSE;
-  	}

{} is not need.

Acked-by: Wei Yongjun <yjwei@cn.fujitsu.com>

You may need fix your patch and cc to David Miller <davem@davemloft.net>
with my ACK.


>