All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Kogan <ikogan@mythicnet.org>
To: linux-wireless@vger.kernel.org
Subject: [PATCH] Kernel Panic on Associate with brcm80211.
Date: Tue, 18 Jan 2011 00:15:41 -0500	[thread overview]
Message-ID: <4D3521FD.9020001@mythicnet.org> (raw)
In-Reply-To: <4D334D00.4030604@mythicnet.org>

I'm going to admit I'm fairly new to this but after some reading, I 
couldn't quite understand why there is an assertion ensuring that the 
sk_buff being sent is not cloned. I was going to see what exploded if I 
removed it and to my surprise...nothing did. In fact, except for a few

[12014.013409] wl0: wlc_d11hdrs_mac80211: AC_BE txop exceeded phylen 
382/256 dur 3562/1504

things seem to work fine. I'll be doing some more testing with this over 
the next couple of days. What obvious thing does this break horribly?

-- Ilya Kogan

  drivers/staging/brcm80211/sys/wlc_mac80211.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/brcm80211/sys/wlc_mac80211.c 
b/drivers/staging/brcm80211/sys/wlc_mac80211.c
index 1d5d01a..a130386 100644
--- a/drivers/staging/brcm80211/sys/wlc_mac80211.c
+++ b/drivers/staging/brcm80211/sys/wlc_mac80211.c
@@ -5126,7 +5126,6 @@ wlc_sendpkt_mac80211(struct wlc_info *wlc, struct 
sk_buff *sdu,
         fifo = prio2fifo[prio];

         ASSERT((uint) skb_headroom(sdu) >= TXOFF);
-       ASSERT(!(sdu->cloned));
         ASSERT(!(sdu->next));
         ASSERT(!(sdu->prev));
         ASSERT(fifo < NFIFO);



  reply	other threads:[~2011-01-18  5:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-16 19:54 Kernel Panic on Associate with brcm80211 Ilya Kogan
2011-01-18  5:15 ` Ilya Kogan [this message]
2011-01-20 11:21   ` [PATCH] " zach
2011-01-20 12:23     ` Arend Van Spriel
2011-01-20 13:51       ` Ilya Kogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3521FD.9020001@mythicnet.org \
    --to=ikogan@mythicnet.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.