All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: Will Newton <will.newton@gmail.com>
Cc: Chris Ball <cjb@laptop.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-mmc@vger.kernel.org, Matt Fleming <matt@console-pimps.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4] dw_mmc: Add Synopsys DesignWare mmc host driver.
Date: Tue, 18 Jan 2011 16:54:58 +0900	[thread overview]
Message-ID: <4D354752.3030401@samsung.com> (raw)
In-Reply-To: <AANLkTik7cMwgwXR1zK44HXC+1YtzpU3_zW2GUjcBMi8X@mail.gmail.com>

Hi Will.

I have some question...i'm testing dw_mmc in our environment.
but i didn't understand pdata->init(?)...what initialize in there?

plz let me know that..

Thanks
Jaehoon Chung

Will Newton wrote:

> +	host->pdev = pdev;
> +	host->pdata = pdata = pdev->dev.platform_data;
> +	if (!pdata || !pdata->init) {
> +		dev_err(&pdev->dev,
> +			"Platform data must supply init function\n");
> +		ret = -ENODEV;
> +		goto err_freehost;
> +	}
> +
> +	if (!pdata->select_slot && pdata->num_slots > 1) {
> +		dev_err(&pdev->dev,
> +			"Platform data must supply select_slot function\n");
> +		ret = -ENODEV;
> +		goto err_freehost;
> +	}
> +
>

WARNING: multiple messages have this Message-ID (diff)
From: jh80.chung@samsung.com (Jaehoon Chung)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] dw_mmc: Add Synopsys DesignWare mmc host driver.
Date: Tue, 18 Jan 2011 16:54:58 +0900	[thread overview]
Message-ID: <4D354752.3030401@samsung.com> (raw)
In-Reply-To: <AANLkTik7cMwgwXR1zK44HXC+1YtzpU3_zW2GUjcBMi8X@mail.gmail.com>

Hi Will.

I have some question...i'm testing dw_mmc in our environment.
but i didn't understand pdata->init(?)...what initialize in there?

plz let me know that..

Thanks
Jaehoon Chung

Will Newton wrote:

> +	host->pdev = pdev;
> +	host->pdata = pdata = pdev->dev.platform_data;
> +	if (!pdata || !pdata->init) {
> +		dev_err(&pdev->dev,
> +			"Platform data must supply init function\n");
> +		ret = -ENODEV;
> +		goto err_freehost;
> +	}
> +
> +	if (!pdata->select_slot && pdata->num_slots > 1) {
> +		dev_err(&pdev->dev,
> +			"Platform data must supply select_slot function\n");
> +		ret = -ENODEV;
> +		goto err_freehost;
> +	}
> +
>

  parent reply	other threads:[~2011-01-18  7:55 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 15:53 [RESEND PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver Will Newton
2010-12-08 11:55 ` Matt Fleming
2010-12-08 13:14   ` Will Newton
2010-12-08 14:21     ` [PATCH] " Will Newton
2010-12-08 16:07       ` Matt Fleming
2010-12-09  6:47       ` Chris Ball
2010-12-09 12:11         ` Will Newton
2010-12-09 16:01           ` Chris Ball
2010-12-09 17:24             ` Will Newton
2010-12-11 19:23               ` Chris Ball
2010-12-11 19:23                 ` Chris Ball
2010-12-12  8:41                 ` Russell King - ARM Linux
2010-12-12  8:41                   ` Russell King - ARM Linux
2010-12-12 11:15                   ` Russell King - ARM Linux
2010-12-12 11:15                     ` Russell King - ARM Linux
2010-12-12 10:57                 ` Will Newton
2010-12-12 10:57                   ` Will Newton
2010-12-12 13:52                   ` Chris Ball
2010-12-12 13:52                     ` Chris Ball
2010-12-12 14:03                     ` Will Newton
2010-12-12 14:03                       ` Will Newton
2010-12-12 14:11                       ` Russell King - ARM Linux
2010-12-12 14:11                         ` Russell King - ARM Linux
2010-12-12 14:31                         ` Will Newton
2010-12-12 14:31                           ` Will Newton
2010-12-12 14:47                           ` Russell King - ARM Linux
2010-12-12 14:47                             ` Russell King - ARM Linux
2010-12-12 15:17                             ` Will Newton
2010-12-12 15:17                               ` Will Newton
2010-12-16 17:04                 ` [PATCH v4] " Will Newton
2010-12-16 17:04                   ` Will Newton
2011-01-02  6:20                   ` Chris Ball
2011-01-02  6:20                     ` Chris Ball
2011-01-18  7:54                   ` Jaehoon Chung [this message]
2011-01-18  7:54                     ` Jaehoon Chung
2011-01-18 10:21                     ` Will Newton
2011-01-18 10:21                       ` Will Newton
2011-02-08  6:38                       ` Jaehoon Chung
2011-02-08  6:38                         ` Jaehoon Chung
2011-02-08 10:29                         ` Will Newton
2011-02-08 10:29                           ` Will Newton
2011-02-08 10:49                           ` Jaehoon Chung
2011-02-08 10:49                             ` Jaehoon Chung
2011-02-08 12:06                             ` Will Newton
2011-02-08 12:06                               ` Will Newton
2010-12-09 17:35             ` [PATCH] " Chris Ball
2010-12-09 17:35               ` Chris Ball
2010-12-09 17:46               ` Will Newton
2010-12-09 17:46                 ` Will Newton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D354752.3030401@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=cjb@laptop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=matt@console-pimps.org \
    --cc=will.newton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.