Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

[Anthony Liguori <anthony@codemonkey.ws>]

On 01/18/2011 03:20 AM, Markus Armbruster wrote:
> Jes.Sorensen@redhat.com writes:
>
>    
>> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>>
>> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
>> ---
>>   cutils.c |   10 +++++-----
>>   1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/cutils.c b/cutils.c
>> index 328738c..f2c8bbd 100644
>> --- a/cutils.c
>> +++ b/cutils.c
>> @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end, const char default_suffix)
>>           }
>>       }
>>       switch (toupper(d)) {
>> -    case 'B':
>> +    case STRTOSZ_DEFSUFFIX_B:
>>           mul = 1;
>>           if (mul_required) {
>>               goto fail;
>>           }
>>           break;
>> -    case 'K':
>> +    case STRTOSZ_DEFSUFFIX_KB:
>>           mul = 1<<  10;
>>           break;
>>       case 0:
>>           if (mul_required) {
>>               goto fail;
>>           }
>> -    case 'M':
>> +    case STRTOSZ_DEFSUFFIX_MB:
>>           mul = 1ULL<<  20;
>>           break;
>> -    case 'G':
>> +    case STRTOSZ_DEFSUFFIX_GB:
>>           mul = 1ULL<<  30;
>>           break;
>> -    case 'T':
>> +    case STRTOSZ_DEFSUFFIX_TB:
>>           mul = 1ULL<<  40;
>>           break;
>>       default:
>>      
> And this improves what?  Certainly not clarity.
>
> In my opinion, the STRTOSZ_DEFSUFFIX_TB are useless chaff.  Chacun à son
> goût.
>    

Yeah, I have to agree.  I'm not of the literals are evil camp.

BTW, a useful change would be to accept both upper and lower case letters.

Regards,

Anthony Liguori