Re: [PATCH 2/5] netreg: Add CPHS CSP PLMN mode implementation

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

Hi Aki,

On 01/18/2011 12:44 PM, Aki Niemi wrote:
> Hi Marcel,
> 
> 2011/1/18 Marcel Holtmann <marcel@holtmann.org>:
>>> +     if (netreg->settings) {
>>> +             g_key_file_set_boolean(netreg->settings, SETTINGS_GROUP,
>>> +                                     "ForcedAuto", netreg->forced_auto);
>>> +             storage_sync(netreg->imsi, SETTINGS_STORE, netreg->settings);
>>> +     }
>>
>> why are we bothering to store this value? Would it not be better to
>> re-read when bringing up the modem?
> 
> We read the value always, yes, but storing the last known value rids
> us of a superfluous PropertyChanged signal in the case when last value
> of forced_auto was true, and after reading is still true. This is
> because forced_auto is by default set to false.

Do you mean across atom instantiations here?  If so there are plenty of
other attributes that get emitted in a similar fashion, so my vote is to
just emit the signal.  Or are you worried about something else?

Regards,
-Denis