All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'
Date: Tue, 18 Jan 2011 15:03:02 -0600	[thread overview]
Message-ID: <4D360006.1040506@gmail.com> (raw)
In-Reply-To: <1295382667.3873.227.camel@aeonflux>

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

Hi Marcel,

>> The reason I ended up extending the Mode property was that once
>> forced_auto is true, no other Mode than auto is anyway possible. So in
>> a sense it is another type of Mode, which isn't to say a separate
>> property wouldn't work equally well.
>>
>> I'm really open to either option. The way the code is written makes it
>> very easy to just expose this as a separate property.
> 
> the extra "forced-auto" mode feels kinda forced into this property. So
> that is my main concern here.
> 
> However on the other hand the Mode property is actually read-only. If it
> would be a user changeable property then it would be pretty clear that
> we do not wanna intermix this here.
> 
> With this in mind, it might be just fine here from a UI interaction flow
> point of view.
> 
> Denis, what is your take on this?
> 

I'm fine with forced-auto, but we might want to add a new error type to
ofono.h (maybe something like ManualRegistrationNotAllowed) and return
that error when trying to use Scan or NetworkOperator.Register.

Regards,
-Denis

  parent reply	other threads:[~2011-01-18 21:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-18 13:19 [PATCH 0/5] Implement CPHS CSP support Aki Niemi
2011-01-18 13:19 ` [PATCH 1/5] simutil: Add EFcsp file and service group IDs Aki Niemi
2011-01-18 13:19 ` [PATCH 2/5] netreg: Add CPHS CSP PLMN mode implementation Aki Niemi
2011-01-18 14:29   ` Marcel Holtmann
2011-01-18 18:44     ` Aki Niemi
2011-01-18 18:51       ` Denis Kenzior
2011-01-18 18:54         ` Aki Niemi
2011-01-18 13:19 ` [PATCH 3/5] doc: Add documentation for 'forced-mode' Aki Niemi
2011-01-18 14:28   ` Marcel Holtmann
2011-01-18 19:02     ` Aki Niemi
2011-01-18 20:31       ` Marcel Holtmann
2011-01-18 20:35         ` Aki Niemi
2011-01-18 20:50           ` Marcel Holtmann
2011-01-18 21:03           ` Denis Kenzior
2011-01-18 21:03         ` Denis Kenzior [this message]
2011-01-19 13:00           ` Aki Niemi
2011-01-18 13:19 ` [PATCH 4/5] doc: Add short mention of CPHS under standards Aki Niemi
2011-01-18 14:25   ` Marcel Holtmann
2011-01-18 13:19 ` [PATCH 5/5] TODO: Remove completed CPHS CSP task Aki Niemi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D360006.1040506@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.