From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <tj@kernel.org>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
Roman Fietze <roman.fietze@telemotive.de>,
linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH #upstream-fixes] pata_mpc52xx: inherit from ata_bmdma_port_ops
Date: Tue, 18 Jan 2011 20:00:27 -0500 [thread overview]
Message-ID: <4D3637AB.2040202@pobox.com> (raw)
In-Reply-To: <20110109224820.GB26607@mtj.dyndns.org>
On 01/09/2011 05:48 PM, Tejun Heo wrote:
> pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which
> triggers BUG_ON() when a DMA command is issued. Fix it.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Reported-by: Roman Fietze<roman.fietze@telemotive.de>
> Cc: Sergei Shtylyov<sshtylyov@mvista.com>
> Cc: stable@kernel.org
> ---
> drivers/ata/pata_mpc52xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
> index 8cc536e..d7d8026 100644
> --- a/drivers/ata/pata_mpc52xx.c
> +++ b/drivers/ata/pata_mpc52xx.c
> @@ -610,7 +610,7 @@ static struct scsi_host_template mpc52xx_ata_sht = {
> };
>
> static struct ata_port_operations mpc52xx_ata_port_ops = {
> - .inherits =&ata_sff_port_ops,
> + .inherits =&ata_bmdma_port_ops,
> .sff_dev_select = mpc52xx_ata_dev_select,
> .set_piomode = mpc52xx_ata_set_piomode,
applied
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Sergei Shtylyov <sshtylyov@mvista.com>,
Roman Fietze <roman.fietze@telemotive.de>
Subject: Re: [PATCH #upstream-fixes] pata_mpc52xx: inherit from ata_bmdma_port_ops
Date: Tue, 18 Jan 2011 20:00:27 -0500 [thread overview]
Message-ID: <4D3637AB.2040202@pobox.com> (raw)
In-Reply-To: <20110109224820.GB26607@mtj.dyndns.org>
On 01/09/2011 05:48 PM, Tejun Heo wrote:
> pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which
> triggers BUG_ON() when a DMA command is issued. Fix it.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Reported-by: Roman Fietze<roman.fietze@telemotive.de>
> Cc: Sergei Shtylyov<sshtylyov@mvista.com>
> Cc: stable@kernel.org
> ---
> drivers/ata/pata_mpc52xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
> index 8cc536e..d7d8026 100644
> --- a/drivers/ata/pata_mpc52xx.c
> +++ b/drivers/ata/pata_mpc52xx.c
> @@ -610,7 +610,7 @@ static struct scsi_host_template mpc52xx_ata_sht = {
> };
>
> static struct ata_port_operations mpc52xx_ata_port_ops = {
> - .inherits =&ata_sff_port_ops,
> + .inherits =&ata_bmdma_port_ops,
> .sff_dev_select = mpc52xx_ata_dev_select,
> .set_piomode = mpc52xx_ata_set_piomode,
applied
next prev parent reply other threads:[~2011-01-19 1:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 13:45 PowerPC MPC5200B ATA MWDMA regression Roman Fietze
2011-01-03 13:59 ` Tejun Heo
2011-01-03 14:29 ` Sergei Shtylyov
2011-01-03 14:29 ` Sergei Shtylyov
2011-01-03 14:33 ` Tejun Heo
2011-01-03 14:33 ` Tejun Heo
2011-01-03 15:27 ` Sergei Shtylyov
2011-01-03 15:27 ` Sergei Shtylyov
2011-01-03 16:33 ` Sergei Shtylyov
2011-01-09 22:48 ` [PATCH #upstream-fixes] pata_mpc52xx: inherit from ata_bmdma_port_ops Tejun Heo
2011-01-09 22:48 ` Tejun Heo
2011-01-10 7:26 ` Roman Fietze
2011-01-10 7:26 ` Roman Fietze
2011-01-19 1:00 ` Jeff Garzik [this message]
2011-01-19 1:00 ` Jeff Garzik
2011-01-03 14:34 ` PowerPC MPC5200B ATA MWDMA regression Roman Fietze
2011-01-03 14:27 ` acrux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3637AB.2040202@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=roman.fietze@telemotive.de \
--cc=sshtylyov@mvista.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.