[LTP] [PATCH] dup203: fix error of not using O_ACCMODE

[LTP] [PATCH] dup203: fix error of not using O_ACCMODE

[Peng Haitao]

Hi Garrett,

The file access mode is extracted from the return value of function fcntl() using the mask O_ACCMODE.

Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>

---
 testcases/kernel/syscalls/dup2/dup203.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/dup2/dup203.c b/testcases/kernel/syscalls/dup2/dup203.c
index 51a3579..0df92b4 100644
--- a/testcases/kernel/syscalls/dup2/dup203.c
+++ b/testcases/kernel/syscalls/dup2/dup203.c
@@ -170,7 +170,7 @@ int main(int ac, char **av)
 				    "return value of 0x0, got %#x", rval);
 				break;
 			}
-			if (((rval = fcntl(fd0, F_GETFL, 0)) != O_WRONLY)) {
+			if ((rval = (fcntl(fd0, F_GETFL, 0) & O_ACCMODE)) != O_WRONLY) {
 				tst_resm(TFAIL, "fctnl F_GETFL bad rval on fd0 "
 					"Expected %#x got %#x", O_WRONLY, rval);
 			}
@@ -212,4 +212,4 @@ void cleanup()
 	TEST_CLEANUP;
 
 	tst_rmdir();
-}
\ No newline at end of file
+}
-- 
1.7.3.1

-- 
Best Regards,
Peng Haitao


------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] dup203: fix error of not using O_ACCMODE

[Garrett Cooper]

On Tue, Jan 18, 2011 at 10:53 PM, Peng Haitao <penght@cn.fujitsu.com> wrote:
> Hi Garrett,
>
> The file access mode is extracted from the return value of function fcntl() using the mask O_ACCMODE.

Committed -- thanks!
-Garrett

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list