From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: Shan Wei <shanwei@cn.fujitsu.com>
Cc: David Miller <davem@davemloft.net>,
vladislav.yasevich@hp.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH] sctp: user perfect name for Delayed SACK Timer option
Date: Wed, 19 Jan 2011 08:22:52 +0000 [thread overview]
Message-ID: <4D369F5C.80901@cn.fujitsu.com> (raw)
In-Reply-To: <4D369E03.2000109@cn.fujitsu.com>
> David Miller wrote, at 01/19/2011 03:39 PM:
>> From: Shan Wei <shanwei@cn.fujitsu.com>
>> Date: Wed, 19 Jan 2011 15:33:30 +0800
>>
>>> The option name of Delayed SACK Timer should be SCTP_DELAYED_SACK,
>>> not SCTP_DELAYED_ACK.
>>>
>>> Reference:
>>> 8.1.19. Get or Set Delayed SACK Timer (SCTP_DELAYED_SACK)
>>> （http://tools.ietf.org/html/draft-ietf-tsvwg-sctpsocket-25)
>>>
>>>
>>> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
>> You can't make this change, you'll break applications using the
>> existing definition.
> No documents guide user to use SCTP_DELAYED_ACK option.
> I double that there is no applications using this option.
>
> If, there be. How about keeping this be concomitant with SCTP_DELAYED_SACK?
You sould do as the same as the following patch, which has fixed the same
problem of lksctp-tools, but not lksctp:
http://git.kernel.org/?p=linux/kernel/git/vxy/lksctp-tools.git;a=commit;hìdc6c0d3c3e40843916427923a45a93d748c1c6
WARNING: multiple messages have this Message-ID (diff)
From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: Shan Wei <shanwei@cn.fujitsu.com>
Cc: David Miller <davem@davemloft.net>,
vladislav.yasevich@hp.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH] sctp: user perfect name for Delayed SACK Timer option
Date: Wed, 19 Jan 2011 16:22:52 +0800 [thread overview]
Message-ID: <4D369F5C.80901@cn.fujitsu.com> (raw)
In-Reply-To: <4D369E03.2000109@cn.fujitsu.com>
> David Miller wrote, at 01/19/2011 03:39 PM:
>> From: Shan Wei <shanwei@cn.fujitsu.com>
>> Date: Wed, 19 Jan 2011 15:33:30 +0800
>>
>>> The option name of Delayed SACK Timer should be SCTP_DELAYED_SACK,
>>> not SCTP_DELAYED_ACK.
>>>
>>> Reference:
>>> 8.1.19. Get or Set Delayed SACK Timer (SCTP_DELAYED_SACK)
>>> （http://tools.ietf.org/html/draft-ietf-tsvwg-sctpsocket-25)
>>>
>>>
>>> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
>> You can't make this change, you'll break applications using the
>> existing definition.
> No documents guide user to use SCTP_DELAYED_ACK option.
> I double that there is no applications using this option.
>
> If, there be. How about keeping this be concomitant with SCTP_DELAYED_SACK?
You sould do as the same as the following patch, which has fixed the same
problem of lksctp-tools, but not lksctp:
http://git.kernel.org/?p=linux/kernel/git/vxy/lksctp-tools.git;a=commit;h=ecdc6c0d3c3e40843916427923a45a93d748c1c6
next prev parent reply other threads:[~2011-01-19 8:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 7:33 [PATCH] sctp: user perfect name for Delayed SACK Timer option Shan Wei
2011-01-19 7:33 ` Shan Wei
2011-01-19 7:39 ` David Miller
2011-01-19 7:39 ` David Miller
2011-01-19 8:17 ` Shan Wei
2011-01-19 8:17 ` Shan Wei
2011-01-19 8:22 ` Wei Yongjun [this message]
2011-01-19 8:22 ` Wei Yongjun
2011-01-19 8:39 ` [PATCH-v2] " Shan Wei
2011-01-19 8:39 ` Shan Wei
2011-01-19 8:48 ` Wei Yongjun
2011-01-19 8:48 ` Wei Yongjun
2011-01-19 8:54 ` Shan Wei
2011-01-19 8:54 ` Shan Wei
2011-01-19 13:37 ` Vladislav Yasevich
2011-01-19 13:37 ` Vladislav Yasevich
2011-01-20 0:51 ` [PATCH-v2] sctp: user perfect name for Delayed SACK Timer David Miller
2011-01-20 0:51 ` [PATCH-v2] sctp: user perfect name for Delayed SACK Timer option David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D369F5C.80901@cn.fujitsu.com \
--to=yjwei@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shanwei@cn.fujitsu.com \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.