* [LTP] [PATCH] fix error of wrong return code in cases rt_sigsuspend01, sched_getaffinity01, ftest06, sem02 and hugemmap03
@ 2011-01-21 8:35 Peng Haitao
2011-01-21 8:43 ` Garrett Cooper
0 siblings, 1 reply; 5+ messages in thread
From: Peng Haitao @ 2011-01-21 8:35 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list
Hi Garrett,
"return 1" should be replaced with "tst_exit()" in the following cases.
Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
---
testcases/kernel/fs/ftest/ftest06.c | 4 ++--
testcases/kernel/ipc/semaphore/sem02.c | 4 ++--
testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c | 4 ++--
.../syscalls/rt_sigsuspend/rt_sigsuspend01.c | 4 ++--
.../sched_getaffinity/sched_getaffinity01.c | 5 ++---
5 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/testcases/kernel/fs/ftest/ftest06.c b/testcases/kernel/fs/ftest/ftest06.c
index b985a1d..d8ff8b6 100644
--- a/testcases/kernel/fs/ftest/ftest06.c
+++ b/testcases/kernel/fs/ftest/ftest06.c
@@ -249,7 +249,7 @@ int main(int ac, char *av[])
tst_resm(TPASS, "Test passed.");
cleanup();
- return 1;
+ tst_exit();
}
#define warn(val,m1,m2) if ((val) < 0) dowarn(me,m1,m2)
@@ -479,4 +479,4 @@ static void cleanup(void)
}
tst_rmdir();
-}
\ No newline at end of file
+}
diff --git a/testcases/kernel/ipc/semaphore/sem02.c b/testcases/kernel/ipc/semaphore/sem02.c
index 17645d8..5b9c58d 100644
--- a/testcases/kernel/ipc/semaphore/sem02.c
+++ b/testcases/kernel/ipc/semaphore/sem02.c
@@ -126,7 +126,7 @@ int main(int argc, char **argv)
tst_resm(TPASS, "passed");
cleanup();
- return 1;
+ tst_exit();
}
/* This thread sleeps 10 seconds then waits on the semaphore. As long
@@ -169,4 +169,4 @@ void cleanup(void)
{
TEST_CLEANUP;
-}
\ No newline at end of file
+}
diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c
index 209e40e..c1479fe 100644
--- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c
+++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c
@@ -134,7 +134,7 @@ main(int ac, char **av)
cleanup();
- return 1;
+ tst_exit();
#endif
}
@@ -178,4 +178,4 @@ cleanup()
unlink(TEMPFILE);
-}
\ No newline at end of file
+}
diff --git a/testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c b/testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c
index f9e3b34..60f63dd 100644
--- a/testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c
+++ b/testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c
@@ -182,5 +182,5 @@ int main(int ac, char **av) {
cleanup();
- return 1;
-}
\ No newline at end of file
+ tst_exit();
+}
diff --git a/testcases/kernel/syscalls/sched_getaffinity/sched_getaffinity01.c b/testcases/kernel/syscalls/sched_getaffinity/sched_getaffinity01.c
index d5182da..014acf2 100644
--- a/testcases/kernel/syscalls/sched_getaffinity/sched_getaffinity01.c
+++ b/testcases/kernel/syscalls/sched_getaffinity/sched_getaffinity01.c
@@ -236,6 +236,5 @@ realloc:
cleanup();
- return (1);
-
-}
\ No newline at end of file
+ tst_exit();
+}
--
1.7.3.1
--
Best Regards,
Peng Haitao
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] fix error of wrong return code in cases rt_sigsuspend01, sched_getaffinity01, ftest06, sem02 and hugemmap03
2011-01-21 8:35 [LTP] [PATCH] fix error of wrong return code in cases rt_sigsuspend01, sched_getaffinity01, ftest06, sem02 and hugemmap03 Peng Haitao
@ 2011-01-21 8:43 ` Garrett Cooper
2011-01-21 9:14 ` Peng Haitao
0 siblings, 1 reply; 5+ messages in thread
From: Garrett Cooper @ 2011-01-21 8:43 UTC (permalink / raw)
To: Peng Haitao; +Cc: ltp-list
On Fri, Jan 21, 2011 at 12:35 AM, Peng Haitao <penght@cn.fujitsu.com> wrote:
> Hi Garrett,
>
> "return 1" should be replaced with "tst_exit()" in the following cases.
Patch please?
Thanks,
-Garrett
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] fix error of wrong return code in cases rt_sigsuspend01, sched_getaffinity01, ftest06, sem02 and hugemmap03
2011-01-21 8:43 ` Garrett Cooper
@ 2011-01-21 9:14 ` Peng Haitao
2011-01-21 9:17 ` Garrett Cooper
0 siblings, 1 reply; 5+ messages in thread
From: Peng Haitao @ 2011-01-21 9:14 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
Hi Garrett,
Garrett Cooper said the following on 2011-1-21 16:43:
> On Fri, Jan 21, 2011 at 12:35 AM, Peng Haitao <penght@cn.fujitsu.com> wrote:
>> Hi Garrett,
>>
>> "return 1" should be replaced with "tst_exit()" in the following cases.
>
> Patch please?
The patch is in the first mail. Do you need an attached patch?
--
Best Regards,
Peng Haitao
[-- Attachment #2: 0001-rt_sigsuspend-fix-error-of-wrong-return-code.patch --]
[-- Type: text/plain, Size: 2894 bytes --]
"return 1" should be replaced with "tst_exit()".
Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
---
testcases/kernel/fs/ftest/ftest06.c | 4 ++--
testcases/kernel/ipc/semaphore/sem02.c | 4 ++--
testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c | 4 ++--
.../syscalls/rt_sigsuspend/rt_sigsuspend01.c | 4 ++--
.../sched_getaffinity/sched_getaffinity01.c | 5 ++---
5 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/testcases/kernel/fs/ftest/ftest06.c b/testcases/kernel/fs/ftest/ftest06.c
index b985a1d..d8ff8b6 100644
--- a/testcases/kernel/fs/ftest/ftest06.c
+++ b/testcases/kernel/fs/ftest/ftest06.c
@@ -249,7 +249,7 @@ int main(int ac, char *av[])
tst_resm(TPASS, "Test passed.");
cleanup();
- return 1;
+ tst_exit();
}
#define warn(val,m1,m2) if ((val) < 0) dowarn(me,m1,m2)
@@ -479,4 +479,4 @@ static void cleanup(void)
}
tst_rmdir();
-}
\ No newline at end of file
+}
diff --git a/testcases/kernel/ipc/semaphore/sem02.c b/testcases/kernel/ipc/semaphore/sem02.c
index 17645d8..5b9c58d 100644
--- a/testcases/kernel/ipc/semaphore/sem02.c
+++ b/testcases/kernel/ipc/semaphore/sem02.c
@@ -126,7 +126,7 @@ int main(int argc, char **argv)
tst_resm(TPASS, "passed");
cleanup();
- return 1;
+ tst_exit();
}
/* This thread sleeps 10 seconds then waits on the semaphore. As long
@@ -169,4 +169,4 @@ void cleanup(void)
{
TEST_CLEANUP;
-}
\ No newline at end of file
+}
diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c
index 209e40e..c1479fe 100644
--- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c
+++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c
@@ -134,7 +134,7 @@ main(int ac, char **av)
cleanup();
- return 1;
+ tst_exit();
#endif
}
@@ -178,4 +178,4 @@ cleanup()
unlink(TEMPFILE);
-}
\ No newline at end of file
+}
diff --git a/testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c b/testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c
index f9e3b34..60f63dd 100644
--- a/testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c
+++ b/testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c
@@ -182,5 +182,5 @@ int main(int ac, char **av) {
cleanup();
- return 1;
-}
\ No newline at end of file
+ tst_exit();
+}
diff --git a/testcases/kernel/syscalls/sched_getaffinity/sched_getaffinity01.c b/testcases/kernel/syscalls/sched_getaffinity/sched_getaffinity01.c
index d5182da..014acf2 100644
--- a/testcases/kernel/syscalls/sched_getaffinity/sched_getaffinity01.c
+++ b/testcases/kernel/syscalls/sched_getaffinity/sched_getaffinity01.c
@@ -236,6 +236,5 @@ realloc:
cleanup();
- return (1);
-
-}
\ No newline at end of file
+ tst_exit();
+}
--
1.7.3.1
[-- Attachment #3: Type: text/plain, Size: 382 bytes --]
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] fix error of wrong return code in cases rt_sigsuspend01, sched_getaffinity01, ftest06, sem02 and hugemmap03
2011-01-21 9:14 ` Peng Haitao
@ 2011-01-21 9:17 ` Garrett Cooper
2011-01-21 9:18 ` Garrett Cooper
0 siblings, 1 reply; 5+ messages in thread
From: Garrett Cooper @ 2011-01-21 9:17 UTC (permalink / raw)
To: Peng Haitao; +Cc: ltp-list
On Fri, Jan 21, 2011 at 1:14 AM, Peng Haitao <penght@cn.fujitsu.com> wrote:
> Hi Garrett,
>
> Garrett Cooper said the following on 2011-1-21 16:43:
>> On Fri, Jan 21, 2011 at 12:35 AM, Peng Haitao <penght@cn.fujitsu.com> wrote:
>>> Hi Garrett,
>>>
>>> "return 1" should be replaced with "tst_exit()" in the following cases.
>>
>> Patch please?
>
> The patch is in the first mail. Do you need an attached patch?
Please see the style guide ( doc/style-guide.rst ) for requested
behavior on what to do when contributing patches.
Thanks!
-Garrett
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] fix error of wrong return code in cases rt_sigsuspend01, sched_getaffinity01, ftest06, sem02 and hugemmap03
2011-01-21 9:17 ` Garrett Cooper
@ 2011-01-21 9:18 ` Garrett Cooper
0 siblings, 0 replies; 5+ messages in thread
From: Garrett Cooper @ 2011-01-21 9:18 UTC (permalink / raw)
To: Peng Haitao; +Cc: ltp-list
On Fri, Jan 21, 2011 at 1:17 AM, Garrett Cooper <yanegomi@gmail.com> wrote:
> On Fri, Jan 21, 2011 at 1:14 AM, Peng Haitao <penght@cn.fujitsu.com> wrote:
>> Hi Garrett,
>>
>> Garrett Cooper said the following on 2011-1-21 16:43:
>>> On Fri, Jan 21, 2011 at 12:35 AM, Peng Haitao <penght@cn.fujitsu.com> wrote:
>>>> Hi Garrett,
>>>>
>>>> "return 1" should be replaced with "tst_exit()" in the following cases.
>>>
>>> Patch please?
>>
>> The patch is in the first mail. Do you need an attached patch?
>
> Please see the style guide ( doc/style-guide.rst ) for requested
> behavior on what to do when contributing patches.
Oh yes... and I committed the fix. Thanks!
-Garrett
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-01-21 9:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-21 8:35 [LTP] [PATCH] fix error of wrong return code in cases rt_sigsuspend01, sched_getaffinity01, ftest06, sem02 and hugemmap03 Peng Haitao
2011-01-21 8:43 ` Garrett Cooper
2011-01-21 9:14 ` Peng Haitao
2011-01-21 9:17 ` Garrett Cooper
2011-01-21 9:18 ` Garrett Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.