From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "for 2.6.37" <stable@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Fix codec device id format used by some dai_links
Date: Sun, 23 Jan 2011 01:16:33 +0100 [thread overview]
Message-ID: <4D3B7361.3030800@metafoo.de> (raw)
In-Reply-To: <20110122233309.GA22799@opensource.wolfsonmicro.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/23/2011 01:01 AM, Mark Brown wrote:
> On Sun, Jan 23, 2011 at 12:58:02AM +0100, Lars-Peter Clausen wrote:
>
>> I just went through the whole list and the wm8994 codec is a platform driver as well.
>> And on the jive board the wm8750 is connected through SPI.
>
> Yeah, Liam made up a lot of this stuff through guesswork but as you can
> see a mechanical run through fixing them won't work as not everything is
> I2C based in the first place.
On the other hand a mechanical run wont break anything that is not already broken,
but potentially fixes it.
I could resend the patch with those three cases which were definitely wrong in the
current patch fixed to use the correct SPI or platform id. Or I could just send the
fix for the neo1973 and neo1973_gta02 boards. Which one do you prefer?
- - Lars
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk07c2EACgkQBX4mSR26RiNwkgCcCwFvSv2k4pH+2KwHeP7zHB+3
aMsAn1PYvQnTXM36+DTASMgFXfcj9hRV
=OQXL
-----END PGP SIGNATURE-----
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
"for 2.6.37" <stable@kernel.org>
Subject: Re: [PATCH] ASoC: Fix codec device id format used by some dai_links
Date: Sun, 23 Jan 2011 01:16:33 +0100 [thread overview]
Message-ID: <4D3B7361.3030800@metafoo.de> (raw)
In-Reply-To: <20110122233309.GA22799@opensource.wolfsonmicro.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/23/2011 01:01 AM, Mark Brown wrote:
> On Sun, Jan 23, 2011 at 12:58:02AM +0100, Lars-Peter Clausen wrote:
>
>> I just went through the whole list and the wm8994 codec is a platform driver as well.
>> And on the jive board the wm8750 is connected through SPI.
>
> Yeah, Liam made up a lot of this stuff through guesswork but as you can
> see a mechanical run through fixing them won't work as not everything is
> I2C based in the first place.
On the other hand a mechanical run wont break anything that is not already broken,
but potentially fixes it.
I could resend the patch with those three cases which were definitely wrong in the
current patch fixed to use the correct SPI or platform id. Or I could just send the
fix for the neo1973 and neo1973_gta02 boards. Which one do you prefer?
- - Lars
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk07c2EACgkQBX4mSR26RiNwkgCcCwFvSv2k4pH+2KwHeP7zHB+3
aMsAn1PYvQnTXM36+DTASMgFXfcj9hRV
=OQXL
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-01-23 0:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-22 22:38 [PATCH] ASoC: Fix codec device id format used by some dai_links Lars-Peter Clausen
2011-01-22 22:38 ` Lars-Peter Clausen
2011-01-22 22:38 ` [PATCH] SoC: Samsung: Fix outdated cpu_dai_name for s3c24xx i2s Lars-Peter Clausen
2011-01-22 22:38 ` Lars-Peter Clausen
2011-01-24 11:16 ` Liam Girdwood
2011-01-24 11:16 ` [alsa-devel] " Liam Girdwood
2011-01-24 11:31 ` Jassi Brar
2011-01-24 11:31 ` [alsa-devel] " Jassi Brar
2011-01-24 12:07 ` Mark Brown
2011-01-24 12:07 ` Mark Brown
2011-01-22 23:33 ` [PATCH] ASoC: Fix codec device id format used by some dai_links Mark Brown
2011-01-22 23:33 ` Mark Brown
2011-01-22 23:59 ` Lars-Peter Clausen
2011-01-22 23:59 ` Lars-Peter Clausen
2011-01-23 0:16 ` Lars-Peter Clausen [this message]
2011-01-23 0:16 ` Lars-Peter Clausen
2011-01-24 12:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3B7361.3030800@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.