From: Fabien Chouteau <chouteau@adacore.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/5][RFC] New SPARC machine: Leon3
Date: Mon, 24 Jan 2011 11:24:06 +0100 [thread overview]
Message-ID: <4D3D5346.6070805@adacore.com> (raw)
In-Reply-To: <AANLkTi=rqOQvb2qCM7YaTQ4qVUjq1vJ5mBJUTLwQBFH5@mail.gmail.com>
On 01/21/2011 08:04 PM, Blue Swirl wrote:
> On Fri, Jan 21, 2011 at 5:00 PM, Fabien Chouteau<chouteau@adacore.com> wrote:
>> Hello Qemu-devel,
>>
>> Here is the third version of Leon3 emulation patch-set.
>>
>> Modifications since v2:
>> - Tracepoints
>> - DEFINE_PROP_* macros
>> - New interface to trigger interrupts on Leon3 (set_pil_in:leon3.c)
>> - Minor reformating
>>
>> Please feel free to comment.
>
> The patches look fine to me now, except 4/5 had a small problem.
>
> Could you run them through checkpatch.pl and fix the issues? The lines
> like //#define DEBUG_LEON3 can stay despite the error if you don't
> convert them to tracepoints.
Sure, I will fix the two problems that you pointed out and run checkpatch.pl
to fix the remaining style issues.
--
Fabien Chouteau
prev parent reply other threads:[~2011-01-24 10:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 17:00 [Qemu-devel] [PATCH v3 0/5][RFC] New SPARC machine: Leon3 Fabien Chouteau
2011-01-21 17:00 ` [Qemu-devel] [PATCH v3 1/5] SPARC: Emulation of GRLIB GPTimer Fabien Chouteau
2011-01-21 17:00 ` [Qemu-devel] [PATCH v3 2/5] SPARC: Emulation of GRLIB IRQMP Fabien Chouteau
2011-01-21 17:00 ` [Qemu-devel] [PATCH v3 3/5] SPARC: Emulation of GRLIB APB UART Fabien Chouteau
2011-01-21 17:00 ` [Qemu-devel] [PATCH v3 4/5] SPARC: Emulation of Leon3 Fabien Chouteau
2011-01-21 19:02 ` Blue Swirl
2011-01-21 19:09 ` Blue Swirl
2011-01-21 17:00 ` [Qemu-devel] [PATCH v3 5/5] SPARC: Add asr17 register support Fabien Chouteau
2011-01-21 19:04 ` [Qemu-devel] [PATCH v3 0/5][RFC] New SPARC machine: Leon3 Blue Swirl
2011-01-24 10:24 ` Fabien Chouteau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3D5346.6070805@adacore.com \
--to=chouteau@adacore.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.