From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Yoichi Yuasa <yuasa@linux-mips.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mips <linux-mips@linux-mips.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix build error when CONFIG_SWAP is not set
Date: Mon, 24 Jan 2011 22:30:46 +0300 [thread overview]
Message-ID: <4D3DD366.8000704@mvista.com> (raw)
In-Reply-To: <20110124210813.ba743fc5.yuasa@linux-mips.org>
Hello.
Yoichi Yuasa wrote:
> In file included from
> linux-2.6/arch/mips/include/asm/tlb.h:21,
> from mm/pgtable-generic.c:9:
> include/asm-generic/tlb.h: In function 'tlb_flush_mmu':
> include/asm-generic/tlb.h:76: error: implicit declaration of function
> 'release_pages'
> include/asm-generic/tlb.h: In function 'tlb_remove_page':
> include/asm-generic/tlb.h:105: error: implicit declaration of function
> 'page_cache_release'
> make[1]: *** [mm/pgtable-generic.o] Error 1
>
> Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
[...]
> diff --git a/include/linux/swap.h b/include/linux/swap.h
> index 4d55932..92c1be6 100644
> --- a/include/linux/swap.h
> +++ b/include/linux/swap.h
> @@ -8,6 +8,7 @@
> #include <linux/memcontrol.h>
> #include <linux/sched.h>
> #include <linux/node.h>
> +#include <linux/pagemap.h>
Hm, if the errors are in <asm-generic/tlb.h>, why add #include in
<linux/swap.h>?
WBR. Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Yoichi Yuasa <yuasa@linux-mips.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mips <linux-mips@linux-mips.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix build error when CONFIG_SWAP is not set
Date: Mon, 24 Jan 2011 22:30:46 +0300 [thread overview]
Message-ID: <4D3DD366.8000704@mvista.com> (raw)
In-Reply-To: <20110124210813.ba743fc5.yuasa@linux-mips.org>
Hello.
Yoichi Yuasa wrote:
> In file included from
> linux-2.6/arch/mips/include/asm/tlb.h:21,
> from mm/pgtable-generic.c:9:
> include/asm-generic/tlb.h: In function 'tlb_flush_mmu':
> include/asm-generic/tlb.h:76: error: implicit declaration of function
> 'release_pages'
> include/asm-generic/tlb.h: In function 'tlb_remove_page':
> include/asm-generic/tlb.h:105: error: implicit declaration of function
> 'page_cache_release'
> make[1]: *** [mm/pgtable-generic.o] Error 1
>
> Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
[...]
> diff --git a/include/linux/swap.h b/include/linux/swap.h
> index 4d55932..92c1be6 100644
> --- a/include/linux/swap.h
> +++ b/include/linux/swap.h
> @@ -8,6 +8,7 @@
> #include <linux/memcontrol.h>
> #include <linux/sched.h>
> #include <linux/node.h>
> +#include <linux/pagemap.h>
Hm, if the errors are in <asm-generic/tlb.h>, why add #include in
<linux/swap.h>?
WBR. Sergei
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-24 19:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 12:08 [PATCH] fix build error when CONFIG_SWAP is not set Yoichi Yuasa
2011-01-24 12:08 ` Yoichi Yuasa
2011-01-24 13:15 ` Ralf Baechle
2011-01-24 13:15 ` Ralf Baechle
2011-01-24 19:30 ` Sergei Shtylyov [this message]
2011-01-24 19:30 ` Sergei Shtylyov
2011-01-24 20:44 ` Andrew Morton
2011-01-24 20:44 ` Andrew Morton
2011-01-24 21:07 ` Sam Ravnborg
2011-01-24 21:07 ` Sam Ravnborg
2011-01-25 6:24 ` Geert Uytterhoeven
2011-01-25 6:24 ` Geert Uytterhoeven
2011-01-25 6:33 ` Andrew Morton
2011-01-25 6:33 ` Andrew Morton
2011-01-25 7:41 ` Sam Ravnborg
2011-01-25 7:41 ` Sam Ravnborg
2011-01-25 12:41 ` Ralf Baechle
2011-01-25 12:41 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3DD366.8000704@mvista.com \
--to=sshtylyov@mvista.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=yuasa@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.