Re: [PATCH 1/1] send-pull-request: unset $TO and $CC from environment

[Darren Hart <dvhart@linux.intel.com>]

On 01/21/2011 04:22 PM, Scott Garman wrote:
> Darren Hart and I discovered that when $CC is set (which
> our meta-toolchain environment script sets up), the value
> leaks into the use of this script. Unsetting $TO as well
> just to be thorough.
>
> Signed-off-by: Scott Garman<scott.a.garman@intel.com>

Thanks Scott!

Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>   scripts/send-pull-request |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/send-pull-request b/scripts/send-pull-request
> index 9872c0d..a66d4dc 100755
> --- a/scripts/send-pull-request
> +++ b/scripts/send-pull-request
> @@ -6,6 +6,10 @@ if [ -z "$PULL_MTA" ]; then
>       PULL_MTA="sendmail"
>   fi
>
> +# Prevent environment leakage to these vars.
> +unset TO
> +unset CC
> +
>   usage()
>   {
>   cat<<EOM


-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel