[PATCH 0/1] send-pull-request bugfix

[PATCH 0/1] send-pull-request bugfix

[Scott Garman]

Hi Saul,

Darren Hart and I discovered that when $CC is set (which
our meta-toolchain environment script sets up), the value
leaks into the use of this script. Unsetting $TO as well
just to be thorough. This pull request fixes that.

Pull URL: git://git.pokylinux.org/poky-contrib.git
  Branch: sgarman/pull-request-fix
  Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/pull-request-fix

Thanks,
    Scott Garman <scott.a.garman@intel.com>
---


Scott Garman (1):
  send-pull-request: unset $TO and $CC from environment

 scripts/send-pull-request |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

[PATCH 1/1] send-pull-request: unset $TO and $CC from environment

[Scott Garman]

Darren Hart and I discovered that when $CC is set (which
our meta-toolchain environment script sets up), the value
leaks into the use of this script. Unsetting $TO as well
just to be thorough.

Signed-off-by: Scott Garman <scott.a.garman@intel.com>
---
 scripts/send-pull-request |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/scripts/send-pull-request b/scripts/send-pull-request
index 9872c0d..a66d4dc 100755
--- a/scripts/send-pull-request
+++ b/scripts/send-pull-request
@@ -6,6 +6,10 @@ if [ -z "$PULL_MTA" ]; then
     PULL_MTA="sendmail"
 fi
 
+# Prevent environment leakage to these vars.
+unset TO
+unset CC
+
 usage()
 {
 cat <<EOM
-- 
1.7.1

Re: [PATCH 1/1] send-pull-request: unset $TO and $CC from environment

[Darren Hart]

On 01/21/2011 04:22 PM, Scott Garman wrote:
> Darren Hart and I discovered that when $CC is set (which
> our meta-toolchain environment script sets up), the value
> leaks into the use of this script. Unsetting $TO as well
> just to be thorough.
>
> Signed-off-by: Scott Garman<scott.a.garman@intel.com>

Thanks Scott!

Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>   scripts/send-pull-request |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/send-pull-request b/scripts/send-pull-request
> index 9872c0d..a66d4dc 100755
> --- a/scripts/send-pull-request
> +++ b/scripts/send-pull-request
> @@ -6,6 +6,10 @@ if [ -z "$PULL_MTA" ]; then
>       PULL_MTA="sendmail"
>   fi
>
> +# Prevent environment leakage to these vars.
> +unset TO
> +unset CC
> +
>   usage()
>   {
>   cat<<EOM


-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 0/1] send-pull-request bugfix

[Saul Wold]

On 01/21/2011 04:21 PM, Scott Garman wrote:
> Hi Saul,
>
> Darren Hart and I discovered that when $CC is set (which
> our meta-toolchain environment script sets up), the value
> leaks into the use of this script. Unsetting $TO as well
> just to be thorough. This pull request fixes that.
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>    Branch: sgarman/pull-request-fix
>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/pull-request-fix
>
> Thanks,
>      Scott Garman<scott.a.garman@intel.com>
> ---
>
>
> Scott Garman (1):
>    send-pull-request: unset $TO and $CC from environment
>
>   scripts/send-pull-request |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>
Pulled into Master

Thanks
	Sau!