[PATCH] 68328serial: remove unsed m68k_serial->tqueue_hangup

[PATCH] 68328serial: remove unsed m68k_serial->tqueue_hangup

[Tejun Heo]

m68k_serial->tqueue_hangup is unused.  Remove it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Greg Ungerer <gerg@uclinux.org>
Cc: Greg Kroah-Hartman <greg@kroah.com>
---
 drivers/tty/serial/68328serial.c |   23 -----------------------
 drivers/tty/serial/68328serial.h |    1 -
 2 files changed, 24 deletions(-)

Index: work/drivers/tty/serial/68328serial.c
===================================================================
--- work.orig/drivers/tty/serial/68328serial.c
+++ work/drivers/tty/serial/68328serial.c
@@ -393,28 +393,6 @@ static void do_softint(struct work_struc
 #endif   
 }
 
-/*
- * This routine is called from the scheduler tqueue when the interrupt
- * routine has signalled that a hangup has occurred.  The path of
- * hangup processing is:
- *
- * 	serial interrupt routine -> (scheduler tqueue) ->
- * 	do_serial_hangup() -> tty->hangup() -> rs_hangup()
- * 
- */
-static void do_serial_hangup(struct work_struct *work)
-{
-	struct m68k_serial	*info = container_of(work, struct m68k_serial, tqueue_hangup);
-	struct tty_struct	*tty;
-	
-	tty = info->port.tty;
-	if (!tty)
-		return;
-
-	tty_hangup(tty);
-}
-
-
 static int startup(struct m68k_serial * info)
 {
 	m68328_uart *uart = &uart_addr[info->line];
@@ -1348,7 +1326,6 @@ rs68328_init(void)
 	    info->count = 0;
 	    info->blocked_open = 0;
 	    INIT_WORK(&info->tqueue, do_softint);
-	    INIT_WORK(&info->tqueue_hangup, do_serial_hangup);
 	    init_waitqueue_head(&info->open_wait);
 	    init_waitqueue_head(&info->close_wait);
 	    info->line = i;
Index: work/drivers/tty/serial/68328serial.h
===================================================================
--- work.orig/drivers/tty/serial/68328serial.h
+++ work/drivers/tty/serial/68328serial.h
@@ -159,7 +159,6 @@ struct m68k_serial {
 	int			xmit_tail;
 	int			xmit_cnt;
 	struct work_struct	tqueue;
-	struct work_struct	tqueue_hangup;
 	wait_queue_head_t	open_wait;
 	wait_queue_head_t	close_wait;
 };

Re: [PATCH] 68328serial: remove unsed m68k_serial->tqueue_hangup

[Alan Cox]

On Mon, 24 Jan 2011 17:53:41 +0100
Tejun Heo <tj@kernel.org> wrote:

> m68k_serial->tqueue_hangup is unused.  Remove it.

Curious - is anyone actually using this driver ?

Re: [PATCH] 68328serial: remove unsed m68k_serial->tqueue_hangup

[Greg Ungerer]

Hi Alan,

On 25/01/11 03:56, Alan Cox wrote:
> On Mon, 24 Jan 2011 17:53:41 +0100
> Tejun Heo<tj@kernel.org>  wrote:
>
>> m68k_serial->tqueue_hangup is unused.  Remove it.
>
> Curious - is anyone actually using this driver ?

It is the serial driver used with the Motorola/Freescale 68x328
family. I don't know that many people would be using the most
recent kernels on them. I compile it once in a while so that it
at least compiles, but I don't have any hardware myself based on it.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com