Re: [PATCH 05/25][v3] u-boot: disable -Os option not supported by gcc

[Darren Hart <dvhart@linux.intel.com>]

On 01/26/2011 10:55 AM, Adrian Alonso wrote:
> Yep that's correct all 25 patch's belong to xilinx bsp meta layer;
> I could define in the meta layer a revision inc file for all the recipes
> that set a SRCREV version.

Apologies, I missed that this was a layer. Putting the revisions in a 
layer default-revisions include isn't a bad idea - it would make merging 
anything into meta at a later date pretty easy. But there's nothing 
wrong with it as is.

--
Darren

>
> Regards
>
> On Wed, Jan 26, 2011 at 12:28 PM, Saul Wold <sgw@linux.intel.com
> <mailto:sgw@linux.intel.com>> wrote:
>
>     On 01/26/2011 10:00 AM, Darren Hart wrote:
>
>         On 01/26/2011 09:42 AM, Adrian Alonso wrote:
>
>             * Disable -Os optspace option not supported by gcc use
>             insted -O2
>             * v2 Remove Make file patch
>             * v3 use EXTRA_OEMAKE variable, override default OPTFLAGS
>             settings
>             in u-boot.inc, Powerpc targets build only with -O1, -O2 optflags
>             Build failures are related to gcc bugs #44392 and #45052
>             * Bump PR
>
>             Signed-off-by: Adrian Alonso<aalonso@secretlab.ca
>             <mailto:aalonso@secretlab.ca>>
>
>
>         Looks good for the -Os problem.
>
>         Reviewed-by: Darren Hart<dvhart@linux.intel.com
>         <mailto:dvhart@linux.intel.com>>
>
>         I noticed that the SRCREV is defined in this file.
>         Typically this should be in
>         meta/conf/distro/include/poky-default-revisions.inc
>
>     If I remember this correctly, these are in a layer, so the
>     default-revision.inc does not get updated.
>
>     Sau!
>
>
>         --
>         Darren
>
>
>             ---
>             recipes-bsp/uboot/u-boot-xilinx_git.bb
>             <http://u-boot-xilinx_git.bb> | 6 ++++--
>             1 files changed, 4 insertions(+), 2 deletions(-)
>
>             diff --git a/recipes-bsp/uboot/u-boot-xilinx_git.bb
>             <http://u-boot-xilinx_git.bb>
>             b/recipes-bsp/uboot/u-boot-xilinx_git.bb
>             <http://u-boot-xilinx_git.bb>
>             index 50d99e3..a373428 100644
>             --- a/recipes-bsp/uboot/u-boot-xilinx_git.bb
>             <http://u-boot-xilinx_git.bb>
>             +++ b/recipes-bsp/uboot/u-boot-xilinx_git.bb
>             <http://u-boot-xilinx_git.bb>
>             @@ -1,9 +1,11 @@
>             require ../meta/recipes-bsp/uboot/u-boot.inc
>             -PR = "r2"
>             +PR = "r3"
>
>             +EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS='-O2'"
>             BRANCH="master"
>             TAG="e094f2479ea339d7f48b6826f06f0be4984d9a98"
>             -SRC_URI =
>             "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git
>             <http://git.xilinx.com/u-boot-xlnx.git;branch=$%7BBRANCH%7D;protocol=git>"
>             +SRC_URI =
>             "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git
>             <http://git.xilinx.com/u-boot-xlnx.git;branch=$%7BBRANCH%7D;protocol=git>
>             \
>             + "
>             SRCREV = "${TAG}"
>
>             inherit xilinx-boot
>
>
>
>
>     _______________________________________________
>     poky mailing list
>     poky@yoctoproject.org <mailto:poky@yoctoproject.org>
>     https://lists.yoctoproject.org/listinfo/poky
>
>


-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel