* [PATCH] ARM: S5PV210: Add GONI board setup for CIF camera support @ 2011-01-07 16:57 ` Sylwester Nawrocki 0 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-07 16:57 UTC (permalink / raw) To: linux-arm-kernel, linux-samsung-soc Cc: kgene.kim, ben-linux, m.szyprowski, kyungmin.park, s.nawrocki Hello, the following patch series introduces changes in GONI board setup file required for the CIF camera sensor driver. The first patch adds the I2C0 bus driver, the second one adds the regulator supply definitions and the third one just increases virtual size of the framebuffer window 0 for preview double buffering. The patch series contains: [PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board [PATCH 3/3] ARM: S5PV210: Change framebuffer window 0 size on GONI Created against kgene-for-next branch at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git Regards, Sylwester -- Sylwester Nawrocki Samsung Poland R&D Center ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH] ARM: S5PV210: Add GONI board setup for CIF camera support @ 2011-01-07 16:57 ` Sylwester Nawrocki 0 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-07 16:57 UTC (permalink / raw) To: linux-arm-kernel Hello, the following patch series introduces changes in GONI board setup file required for the CIF camera sensor driver. The first patch adds the I2C0 bus driver, the second one adds the regulator supply definitions and the third one just increases virtual size of the framebuffer window 0 for preview double buffering. The patch series contains: [PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board [PATCH 3/3] ARM: S5PV210: Change framebuffer window 0 size on GONI Created against kgene-for-next branch at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git Regards, Sylwester -- Sylwester Nawrocki Samsung Poland R&D Center ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board 2011-01-07 16:57 ` Sylwester Nawrocki @ 2011-01-07 16:57 ` Sylwester Nawrocki -1 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-07 16:57 UTC (permalink / raw) To: linux-arm-kernel, linux-samsung-soc Cc: kgene.kim, ben-linux, m.szyprowski, kyungmin.park, s.nawrocki Add I2C0 bus platform device for camera sensors. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-s5pv210/Kconfig | 1 + arch/arm/mach-s5pv210/mach-goni.c | 4 ++++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig index 53aabef..b0aa462 100644 --- a/arch/arm/mach-s5pv210/Kconfig +++ b/arch/arm/mach-s5pv210/Kconfig @@ -75,6 +75,7 @@ config MACH_GONI bool "GONI" select CPU_S5PV210 select S5P_GPIO_INT + select S3C_DEV_I2C0 select S3C_DEV_FB select S5P_DEV_FIMC0 select S5P_DEV_FIMC1 diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c index e22d511..fc34575 100644 --- a/arch/arm/mach-s5pv210/mach-goni.c +++ b/arch/arm/mach-s5pv210/mach-goni.c @@ -800,6 +800,7 @@ static struct platform_device *goni_devices[] __initdata = { &s5pv210_device_iis0, &s3c_device_usb_hsotg, &samsung_device_keypad, + &s3c_device_i2c0, &s3c_device_i2c1, &s3c_device_i2c2, &wm8994_fixed_voltage0, @@ -827,6 +828,9 @@ static void __init goni_machine_init(void) /* Radio: call before I2C 1 registeration */ goni_radio_init(); + /* I2C0 */ + s3c_i2c0_set_platdata(NULL); + /* I2C1 */ s3c_i2c1_set_platdata(NULL); i2c_register_board_info(1, i2c1_devs, ARRAY_SIZE(i2c1_devs)); -- 1.7.3.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board @ 2011-01-07 16:57 ` Sylwester Nawrocki 0 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-07 16:57 UTC (permalink / raw) To: linux-arm-kernel Add I2C0 bus platform device for camera sensors. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-s5pv210/Kconfig | 1 + arch/arm/mach-s5pv210/mach-goni.c | 4 ++++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig index 53aabef..b0aa462 100644 --- a/arch/arm/mach-s5pv210/Kconfig +++ b/arch/arm/mach-s5pv210/Kconfig @@ -75,6 +75,7 @@ config MACH_GONI bool "GONI" select CPU_S5PV210 select S5P_GPIO_INT + select S3C_DEV_I2C0 select S3C_DEV_FB select S5P_DEV_FIMC0 select S5P_DEV_FIMC1 diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c index e22d511..fc34575 100644 --- a/arch/arm/mach-s5pv210/mach-goni.c +++ b/arch/arm/mach-s5pv210/mach-goni.c @@ -800,6 +800,7 @@ static struct platform_device *goni_devices[] __initdata = { &s5pv210_device_iis0, &s3c_device_usb_hsotg, &samsung_device_keypad, + &s3c_device_i2c0, &s3c_device_i2c1, &s3c_device_i2c2, &wm8994_fixed_voltage0, @@ -827,6 +828,9 @@ static void __init goni_machine_init(void) /* Radio: call before I2C 1 registeration */ goni_radio_init(); + /* I2C0 */ + s3c_i2c0_set_platdata(NULL); + /* I2C1 */ s3c_i2c1_set_platdata(NULL); i2c_register_board_info(1, i2c1_devs, ARRAY_SIZE(i2c1_devs)); -- 1.7.3.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* RE: [PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board 2011-01-07 16:57 ` Sylwester Nawrocki @ 2011-01-28 9:28 ` Kukjin Kim -1 siblings, 0 replies; 22+ messages in thread From: Kukjin Kim @ 2011-01-28 9:28 UTC (permalink / raw) To: 'Sylwester Nawrocki', linux-arm-kernel, linux-samsung-soc Cc: ben-linux, m.szyprowski, kyungmin.park Sylwester Nawrocki wrote: > > Add I2C0 bus platform device for camera sensors. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/mach-s5pv210/Kconfig | 1 + > arch/arm/mach-s5pv210/mach-goni.c | 4 ++++ > 2 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig > index 53aabef..b0aa462 100644 > --- a/arch/arm/mach-s5pv210/Kconfig > +++ b/arch/arm/mach-s5pv210/Kconfig > @@ -75,6 +75,7 @@ config MACH_GONI > bool "GONI" > select CPU_S5PV210 > select S5P_GPIO_INT > + select S3C_DEV_I2C0 NO...Where is S3C_DEV_I2C0? Basically, platform device of i2c0 which is in arch/arm/plat-samsung/dev-i2c0.c is always selected. > select S3C_DEV_FB > select S5P_DEV_FIMC0 > select S5P_DEV_FIMC1 > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach- > goni.c > index e22d511..fc34575 100644 > --- a/arch/arm/mach-s5pv210/mach-goni.c > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -800,6 +800,7 @@ static struct platform_device *goni_devices[] __initdata > = { > &s5pv210_device_iis0, > &s3c_device_usb_hsotg, > &samsung_device_keypad, > + &s3c_device_i2c0, > &s3c_device_i2c1, > &s3c_device_i2c2, > &wm8994_fixed_voltage0, > @@ -827,6 +828,9 @@ static void __init goni_machine_init(void) > /* Radio: call before I2C 1 registeration */ > goni_radio_init(); > > + /* I2C0 */ > + s3c_i2c0_set_platdata(NULL); > + > /* I2C1 */ > s3c_i2c1_set_platdata(NULL); > i2c_register_board_info(1, i2c1_devs, ARRAY_SIZE(i2c1_devs)); > -- > 1.7.3.5 Others, ok...please re-work this against on latest my for-next. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board @ 2011-01-28 9:28 ` Kukjin Kim 0 siblings, 0 replies; 22+ messages in thread From: Kukjin Kim @ 2011-01-28 9:28 UTC (permalink / raw) To: linux-arm-kernel Sylwester Nawrocki wrote: > > Add I2C0 bus platform device for camera sensors. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/mach-s5pv210/Kconfig | 1 + > arch/arm/mach-s5pv210/mach-goni.c | 4 ++++ > 2 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig > index 53aabef..b0aa462 100644 > --- a/arch/arm/mach-s5pv210/Kconfig > +++ b/arch/arm/mach-s5pv210/Kconfig > @@ -75,6 +75,7 @@ config MACH_GONI > bool "GONI" > select CPU_S5PV210 > select S5P_GPIO_INT > + select S3C_DEV_I2C0 NO...Where is S3C_DEV_I2C0? Basically, platform device of i2c0 which is in arch/arm/plat-samsung/dev-i2c0.c is always selected. > select S3C_DEV_FB > select S5P_DEV_FIMC0 > select S5P_DEV_FIMC1 > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach- > goni.c > index e22d511..fc34575 100644 > --- a/arch/arm/mach-s5pv210/mach-goni.c > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -800,6 +800,7 @@ static struct platform_device *goni_devices[] __initdata > = { > &s5pv210_device_iis0, > &s3c_device_usb_hsotg, > &samsung_device_keypad, > + &s3c_device_i2c0, > &s3c_device_i2c1, > &s3c_device_i2c2, > &wm8994_fixed_voltage0, > @@ -827,6 +828,9 @@ static void __init goni_machine_init(void) > /* Radio: call before I2C 1 registeration */ > goni_radio_init(); > > + /* I2C0 */ > + s3c_i2c0_set_platdata(NULL); > + > /* I2C1 */ > s3c_i2c1_set_platdata(NULL); > i2c_register_board_info(1, i2c1_devs, ARRAY_SIZE(i2c1_devs)); > -- > 1.7.3.5 Others, ok...please re-work this against on latest my for-next. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board 2011-01-28 9:28 ` Kukjin Kim @ 2011-01-28 14:18 ` Sylwester Nawrocki -1 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-28 14:18 UTC (permalink / raw) To: Kukjin Kim Cc: 'Sylwester Nawrocki', linux-arm-kernel, linux-samsung-soc, ben-linux, m.szyprowski, kyungmin.park Hi Kukjin, On 01/28/2011 06:28 PM, Kukjin Kim wrote: > Sylwester Nawrocki wrote: >> >> Add I2C0 bus platform device for camera sensors. >> >> Signed-off-by: Sylwester Nawrocki<s.nawrocki@samsung.com> >> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com> >> --- >> arch/arm/mach-s5pv210/Kconfig | 1 + >> arch/arm/mach-s5pv210/mach-goni.c | 4 ++++ >> 2 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig >> index 53aabef..b0aa462 100644 >> --- a/arch/arm/mach-s5pv210/Kconfig >> +++ b/arch/arm/mach-s5pv210/Kconfig >> @@ -75,6 +75,7 @@ config MACH_GONI >> bool "GONI" >> select CPU_S5PV210 >> select S5P_GPIO_INT >> + select S3C_DEV_I2C0 > > NO...Where is S3C_DEV_I2C0? > Basically, platform device of i2c0 which is in > arch/arm/plat-samsung/dev-i2c0.c is always selected. Oh, sorry about that omission. I'll resend that one corrected. Thanks, Sylwester ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board @ 2011-01-28 14:18 ` Sylwester Nawrocki 0 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-28 14:18 UTC (permalink / raw) To: linux-arm-kernel Hi Kukjin, On 01/28/2011 06:28 PM, Kukjin Kim wrote: > Sylwester Nawrocki wrote: >> >> Add I2C0 bus platform device for camera sensors. >> >> Signed-off-by: Sylwester Nawrocki<s.nawrocki@samsung.com> >> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com> >> --- >> arch/arm/mach-s5pv210/Kconfig | 1 + >> arch/arm/mach-s5pv210/mach-goni.c | 4 ++++ >> 2 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig >> index 53aabef..b0aa462 100644 >> --- a/arch/arm/mach-s5pv210/Kconfig >> +++ b/arch/arm/mach-s5pv210/Kconfig >> @@ -75,6 +75,7 @@ config MACH_GONI >> bool "GONI" >> select CPU_S5PV210 >> select S5P_GPIO_INT >> + select S3C_DEV_I2C0 > > NO...Where is S3C_DEV_I2C0? > Basically, platform device of i2c0 which is in > arch/arm/plat-samsung/dev-i2c0.c is always selected. Oh, sorry about that omission. I'll resend that one corrected. Thanks, Sylwester ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board 2011-01-07 16:57 ` Sylwester Nawrocki @ 2011-01-07 16:57 ` Sylwester Nawrocki -1 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-07 16:57 UTC (permalink / raw) To: linux-arm-kernel, linux-samsung-soc Cc: kgene.kim, ben-linux, m.szyprowski, kyungmin.park, s.nawrocki Add regulator supplies required for NOON010PC30 CIF sensor. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-s5pv210/mach-goni.c | 24 +++++++++++++++++++++--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c index fc34575..2051cee 100644 --- a/arch/arm/mach-s5pv210/mach-goni.c +++ b/arch/arm/mach-s5pv210/mach-goni.c @@ -273,6 +273,18 @@ static struct regulator_consumer_supply goni_ldo5_consumers[] = { REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"), }; +static struct regulator_consumer_supply goni_ldo11_consumers[] = { + REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */ +}; + +static struct regulator_consumer_supply goni_ldo13_consumers[] = { + REGULATOR_SUPPLY("vdda", "0-0030"), /* "CAM_A_2.8V" */ +}; + +static struct regulator_consumer_supply goni_ldo14_consumers[] = { + REGULATOR_SUPPLY("vdd_core", "0-0030"), /* "CAM_CIF_1.8V" */ +}; + static struct regulator_init_data goni_ldo2_data = { .constraints = { .name = "VALIVE_1.1V", @@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = { .min_uV = 2800000, .max_uV = 2800000, .apply_uV = 1, - .always_on = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, }, + .num_consumer_supplies = ARRAY_SIZE(goni_ldo11_consumers), + .consumer_supplies = goni_ldo11_consumers, }; static struct regulator_init_data goni_ldo12_data = { @@ -391,8 +405,10 @@ static struct regulator_init_data goni_ldo13_data = { .min_uV = 2800000, .max_uV = 2800000, .apply_uV = 1, - .always_on = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, }, + .num_consumer_supplies = ARRAY_SIZE(goni_ldo13_consumers), + .consumer_supplies = goni_ldo13_consumers, }; static struct regulator_init_data goni_ldo14_data = { @@ -401,8 +417,10 @@ static struct regulator_init_data goni_ldo14_data = { .min_uV = 1800000, .max_uV = 1800000, .apply_uV = 1, - .always_on = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, }, + .num_consumer_supplies = ARRAY_SIZE(goni_ldo14_consumers), + .consumer_supplies = goni_ldo14_consumers, }; static struct regulator_init_data goni_ldo15_data = { -- 1.7.3.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board @ 2011-01-07 16:57 ` Sylwester Nawrocki 0 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-07 16:57 UTC (permalink / raw) To: linux-arm-kernel Add regulator supplies required for NOON010PC30 CIF sensor. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-s5pv210/mach-goni.c | 24 +++++++++++++++++++++--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c index fc34575..2051cee 100644 --- a/arch/arm/mach-s5pv210/mach-goni.c +++ b/arch/arm/mach-s5pv210/mach-goni.c @@ -273,6 +273,18 @@ static struct regulator_consumer_supply goni_ldo5_consumers[] = { REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"), }; +static struct regulator_consumer_supply goni_ldo11_consumers[] = { + REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */ +}; + +static struct regulator_consumer_supply goni_ldo13_consumers[] = { + REGULATOR_SUPPLY("vdda", "0-0030"), /* "CAM_A_2.8V" */ +}; + +static struct regulator_consumer_supply goni_ldo14_consumers[] = { + REGULATOR_SUPPLY("vdd_core", "0-0030"), /* "CAM_CIF_1.8V" */ +}; + static struct regulator_init_data goni_ldo2_data = { .constraints = { .name = "VALIVE_1.1V", @@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = { .min_uV = 2800000, .max_uV = 2800000, .apply_uV = 1, - .always_on = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, }, + .num_consumer_supplies = ARRAY_SIZE(goni_ldo11_consumers), + .consumer_supplies = goni_ldo11_consumers, }; static struct regulator_init_data goni_ldo12_data = { @@ -391,8 +405,10 @@ static struct regulator_init_data goni_ldo13_data = { .min_uV = 2800000, .max_uV = 2800000, .apply_uV = 1, - .always_on = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, }, + .num_consumer_supplies = ARRAY_SIZE(goni_ldo13_consumers), + .consumer_supplies = goni_ldo13_consumers, }; static struct regulator_init_data goni_ldo14_data = { @@ -401,8 +417,10 @@ static struct regulator_init_data goni_ldo14_data = { .min_uV = 1800000, .max_uV = 1800000, .apply_uV = 1, - .always_on = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, }, + .num_consumer_supplies = ARRAY_SIZE(goni_ldo14_consumers), + .consumer_supplies = goni_ldo14_consumers, }; static struct regulator_init_data goni_ldo15_data = { -- 1.7.3.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* RE: [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board 2011-01-07 16:57 ` Sylwester Nawrocki @ 2011-01-28 9:32 ` Kukjin Kim -1 siblings, 0 replies; 22+ messages in thread From: Kukjin Kim @ 2011-01-28 9:32 UTC (permalink / raw) To: 'Sylwester Nawrocki', linux-arm-kernel, linux-samsung-soc Cc: ben-linux, m.szyprowski, kyungmin.park Sylwester Nawrocki wrote: > > Add regulator supplies required for NOON010PC30 CIF sensor. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/mach-s5pv210/mach-goni.c | 24 +++++++++++++++++++++--- > 1 files changed, 21 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach- > goni.c > index fc34575..2051cee 100644 > --- a/arch/arm/mach-s5pv210/mach-goni.c > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -273,6 +273,18 @@ static struct regulator_consumer_supply > goni_ldo5_consumers[] = { > REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"), > }; > > +static struct regulator_consumer_supply goni_ldo11_consumers[] = { > + REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */ > +}; Need array in goni_ldo11_consumers? +static struct regulator_consumer_supply goni_ldo11_consumers = + REGULATOR_SUPPLY("vddio", "0-0030"); /* "CAM_IO_2.8V" */ > + > +static struct regulator_consumer_supply goni_ldo13_consumers[] = { > + REGULATOR_SUPPLY("vdda", "0-0030"), /* "CAM_A_2.8V" */ > +}; Same above. > + > +static struct regulator_consumer_supply goni_ldo14_consumers[] = { > + REGULATOR_SUPPLY("vdd_core", "0-0030"), /* "CAM_CIF_1.8V" */ > +}; Same above. > + > static struct regulator_init_data goni_ldo2_data = { > .constraints = { > .name = "VALIVE_1.1V", > @@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = { > .min_uV = 2800000, > .max_uV = 2800000, > .apply_uV = 1, > - .always_on = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > }, > + .num_consumer_supplies = ARRAY_SIZE(goni_ldo11_consumers), > + .consumer_supplies = goni_ldo11_consumers, If you modify as per my suggestion, then need to change this like following. + .num_consumer_supplies = 1, + .consumer_supplies = &goni_ldo11_consumers, > }; > > static struct regulator_init_data goni_ldo12_data = { > @@ -391,8 +405,10 @@ static struct regulator_init_data goni_ldo13_data = { > .min_uV = 2800000, > .max_uV = 2800000, > .apply_uV = 1, > - .always_on = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > }, > + .num_consumer_supplies = ARRAY_SIZE(goni_ldo13_consumers), > + .consumer_supplies = goni_ldo13_consumers, Same above. > }; > > static struct regulator_init_data goni_ldo14_data = { > @@ -401,8 +417,10 @@ static struct regulator_init_data goni_ldo14_data = { > .min_uV = 1800000, > .max_uV = 1800000, > .apply_uV = 1, > - .always_on = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > }, > + .num_consumer_supplies = ARRAY_SIZE(goni_ldo14_consumers), > + .consumer_supplies = goni_ldo14_consumers, Same above. > }; > > static struct regulator_init_data goni_ldo15_data = { > -- > 1.7.3.5 If required array in there, please let me know. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board @ 2011-01-28 9:32 ` Kukjin Kim 0 siblings, 0 replies; 22+ messages in thread From: Kukjin Kim @ 2011-01-28 9:32 UTC (permalink / raw) To: linux-arm-kernel Sylwester Nawrocki wrote: > > Add regulator supplies required for NOON010PC30 CIF sensor. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/mach-s5pv210/mach-goni.c | 24 +++++++++++++++++++++--- > 1 files changed, 21 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach- > goni.c > index fc34575..2051cee 100644 > --- a/arch/arm/mach-s5pv210/mach-goni.c > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -273,6 +273,18 @@ static struct regulator_consumer_supply > goni_ldo5_consumers[] = { > REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"), > }; > > +static struct regulator_consumer_supply goni_ldo11_consumers[] = { > + REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */ > +}; Need array in goni_ldo11_consumers? +static struct regulator_consumer_supply goni_ldo11_consumers = + REGULATOR_SUPPLY("vddio", "0-0030"); /* "CAM_IO_2.8V" */ > + > +static struct regulator_consumer_supply goni_ldo13_consumers[] = { > + REGULATOR_SUPPLY("vdda", "0-0030"), /* "CAM_A_2.8V" */ > +}; Same above. > + > +static struct regulator_consumer_supply goni_ldo14_consumers[] = { > + REGULATOR_SUPPLY("vdd_core", "0-0030"), /* "CAM_CIF_1.8V" */ > +}; Same above. > + > static struct regulator_init_data goni_ldo2_data = { > .constraints = { > .name = "VALIVE_1.1V", > @@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = { > .min_uV = 2800000, > .max_uV = 2800000, > .apply_uV = 1, > - .always_on = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > }, > + .num_consumer_supplies = ARRAY_SIZE(goni_ldo11_consumers), > + .consumer_supplies = goni_ldo11_consumers, If you modify as per my suggestion, then need to change this like following. + .num_consumer_supplies = 1, + .consumer_supplies = &goni_ldo11_consumers, > }; > > static struct regulator_init_data goni_ldo12_data = { > @@ -391,8 +405,10 @@ static struct regulator_init_data goni_ldo13_data = { > .min_uV = 2800000, > .max_uV = 2800000, > .apply_uV = 1, > - .always_on = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > }, > + .num_consumer_supplies = ARRAY_SIZE(goni_ldo13_consumers), > + .consumer_supplies = goni_ldo13_consumers, Same above. > }; > > static struct regulator_init_data goni_ldo14_data = { > @@ -401,8 +417,10 @@ static struct regulator_init_data goni_ldo14_data = { > .min_uV = 1800000, > .max_uV = 1800000, > .apply_uV = 1, > - .always_on = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > }, > + .num_consumer_supplies = ARRAY_SIZE(goni_ldo14_consumers), > + .consumer_supplies = goni_ldo14_consumers, Same above. > }; > > static struct regulator_init_data goni_ldo15_data = { > -- > 1.7.3.5 If required array in there, please let me know. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board 2011-01-28 9:32 ` Kukjin Kim @ 2011-01-28 10:53 ` Kyungmin Park -1 siblings, 0 replies; 22+ messages in thread From: Kyungmin Park @ 2011-01-28 10:53 UTC (permalink / raw) To: Kukjin Kim Cc: Sylwester Nawrocki, linux-arm-kernel, linux-samsung-soc, ben-linux, m.szyprowski, Mark Brown On Fri, Jan 28, 2011 at 6:32 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Sylwester Nawrocki wrote: >> >> Add regulator supplies required for NOON010PC30 CIF sensor. >> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> arch/arm/mach-s5pv210/mach-goni.c | 24 +++++++++++++++++++++--- >> 1 files changed, 21 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/mach-s5pv210/mach-goni.c > b/arch/arm/mach-s5pv210/mach- >> goni.c >> index fc34575..2051cee 100644 >> --- a/arch/arm/mach-s5pv210/mach-goni.c >> +++ b/arch/arm/mach-s5pv210/mach-goni.c >> @@ -273,6 +273,18 @@ static struct regulator_consumer_supply >> goni_ldo5_consumers[] = { >> REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"), >> }; >> >> +static struct regulator_consumer_supply goni_ldo11_consumers[] = { >> + REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */ >> +}; > > Need array in goni_ldo11_consumers? Yes, it's required for consistency and most consumers use this style. Look smdk board file http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git;a=blob;f=arch/arm/mach-s3c64xx/mach-smdk6410.c;h=e85192a86fbe1a9f51bb9da15f20899bf0b4ab3e;hb=refs/heads/for-next 303 #ifdef CONFIG_REGULATOR 304 /* ARM core */ 305 static struct regulator_consumer_supply smdk6410_vddarm_consumers[] = { 306 { 307 .supply = "vddarm", 308 } 309 }; 310 311 /* VDDARM, BUCK1 on J5 */ 312 static struct regulator_init_data smdk6410_vddarm = { 313 .constraints = { 314 .name = "PVDD_ARM", 315 .min_uV = 1000000, 316 .max_uV = 1300000, 317 .always_on = 1, 318 .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE, 319 }, 320 .num_consumer_supplies = ARRAY_SIZE(smdk6410_vddarm_consumers), 321 .consumer_supplies = smdk6410_vddarm_consumers, 322 }; > > +static struct regulator_consumer_supply goni_ldo11_consumers = > + REGULATOR_SUPPLY("vddio", "0-0030"); /* "CAM_IO_2.8V" */ > >> + >> +static struct regulator_consumer_supply goni_ldo13_consumers[] = { >> + REGULATOR_SUPPLY("vdda", "0-0030"), /* "CAM_A_2.8V" */ >> +}; > > Same above. > >> + >> +static struct regulator_consumer_supply goni_ldo14_consumers[] = { >> + REGULATOR_SUPPLY("vdd_core", "0-0030"), /* "CAM_CIF_1.8V" */ >> +}; > > Same above. > >> + >> static struct regulator_init_data goni_ldo2_data = { >> .constraints = { >> .name = "VALIVE_1.1V", >> @@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = { >> .min_uV = 2800000, >> .max_uV = 2800000, >> .apply_uV = 1, >> - .always_on = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> }, >> + .num_consumer_supplies = ARRAY_SIZE(goni_ldo11_consumers), >> + .consumer_supplies = goni_ldo11_consumers, > > If you modify as per my suggestion, then need to change this like following. Same, I want to use the same style even though it has one consumer. and If it has one consumer, ARRAY_SIZE(some_consumers) has 1 at compile time. > > + .num_consumer_supplies = 1, > + .consumer_supplies = &goni_ldo11_consumers, > >> }; >> >> static struct regulator_init_data goni_ldo12_data = { >> @@ -391,8 +405,10 @@ static struct regulator_init_data goni_ldo13_data = { >> .min_uV = 2800000, >> .max_uV = 2800000, >> .apply_uV = 1, >> - .always_on = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> }, >> + .num_consumer_supplies = ARRAY_SIZE(goni_ldo13_consumers), >> + .consumer_supplies = goni_ldo13_consumers, > > Same above. > >> }; >> >> static struct regulator_init_data goni_ldo14_data = { >> @@ -401,8 +417,10 @@ static struct regulator_init_data goni_ldo14_data = { >> .min_uV = 1800000, >> .max_uV = 1800000, >> .apply_uV = 1, >> - .always_on = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> }, >> + .num_consumer_supplies = ARRAY_SIZE(goni_ldo14_consumers), >> + .consumer_supplies = goni_ldo14_consumers, > > Same above. > >> }; >> >> static struct regulator_init_data goni_ldo15_data = { >> -- >> 1.7.3.5 > > If required array in there, please let me know. > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board @ 2011-01-28 10:53 ` Kyungmin Park 0 siblings, 0 replies; 22+ messages in thread From: Kyungmin Park @ 2011-01-28 10:53 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jan 28, 2011 at 6:32 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Sylwester Nawrocki wrote: >> >> Add regulator supplies required for NOON010PC30 CIF sensor. >> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> ?arch/arm/mach-s5pv210/mach-goni.c | ? 24 +++++++++++++++++++++--- >> ?1 files changed, 21 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/mach-s5pv210/mach-goni.c > b/arch/arm/mach-s5pv210/mach- >> goni.c >> index fc34575..2051cee 100644 >> --- a/arch/arm/mach-s5pv210/mach-goni.c >> +++ b/arch/arm/mach-s5pv210/mach-goni.c >> @@ -273,6 +273,18 @@ static struct regulator_consumer_supply >> goni_ldo5_consumers[] = { >> ? ? ? REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"), >> ?}; >> >> +static struct regulator_consumer_supply goni_ldo11_consumers[] = { >> + ? ? REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */ >> +}; > > Need array in goni_ldo11_consumers? Yes, it's required for consistency and most consumers use this style. Look smdk board file http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git;a=blob;f=arch/arm/mach-s3c64xx/mach-smdk6410.c;h=e85192a86fbe1a9f51bb9da15f20899bf0b4ab3e;hb=refs/heads/for-next 303 #ifdef CONFIG_REGULATOR 304 /* ARM core */ 305 static struct regulator_consumer_supply smdk6410_vddarm_consumers[] = { 306 { 307 .supply = "vddarm", 308 } 309 }; 310 311 /* VDDARM, BUCK1 on J5 */ 312 static struct regulator_init_data smdk6410_vddarm = { 313 .constraints = { 314 .name = "PVDD_ARM", 315 .min_uV = 1000000, 316 .max_uV = 1300000, 317 .always_on = 1, 318 .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE, 319 }, 320 .num_consumer_supplies = ARRAY_SIZE(smdk6410_vddarm_consumers), 321 .consumer_supplies = smdk6410_vddarm_consumers, 322 }; > > +static struct regulator_consumer_supply goni_ldo11_consumers = > + ? ? ? REGULATOR_SUPPLY("vddio", "0-0030"); /* "CAM_IO_2.8V" */ > >> + >> +static struct regulator_consumer_supply goni_ldo13_consumers[] = { >> + ? ? REGULATOR_SUPPLY("vdda", "0-0030"), /* "CAM_A_2.8V" */ >> +}; > > Same above. > >> + >> +static struct regulator_consumer_supply goni_ldo14_consumers[] = { >> + ? ? REGULATOR_SUPPLY("vdd_core", "0-0030"), /* "CAM_CIF_1.8V" */ >> +}; > > Same above. > >> + >> ?static struct regulator_init_data goni_ldo2_data = { >> ? ? ? .constraints ? ?= { >> ? ? ? ? ? ? ? .name ? ? ? ? ? = "VALIVE_1.1V", >> @@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = { >> ? ? ? ? ? ? ? .min_uV ? ? ? ? = 2800000, >> ? ? ? ? ? ? ? .max_uV ? ? ? ? = 2800000, >> ? ? ? ? ? ? ? .apply_uV ? ? ? = 1, >> - ? ? ? ? ? ? .always_on ? ? ?= 1, >> + ? ? ? ? ? ? .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> ? ? ? }, >> + ? ? .num_consumer_supplies ?= ARRAY_SIZE(goni_ldo11_consumers), >> + ? ? .consumer_supplies ? ? ?= goni_ldo11_consumers, > > If you modify as per my suggestion, then need to change this like following. Same, I want to use the same style even though it has one consumer. and If it has one consumer, ARRAY_SIZE(some_consumers) has 1 at compile time. > > + ? ? ? .num_consumer_supplies ?= 1, > + ? ? ? .consumer_supplies ? ? ?= &goni_ldo11_consumers, > >> ?}; >> >> ?static struct regulator_init_data goni_ldo12_data = { >> @@ -391,8 +405,10 @@ static struct regulator_init_data goni_ldo13_data = { >> ? ? ? ? ? ? ? .min_uV ? ? ? ? = 2800000, >> ? ? ? ? ? ? ? .max_uV ? ? ? ? = 2800000, >> ? ? ? ? ? ? ? .apply_uV ? ? ? = 1, >> - ? ? ? ? ? ? .always_on ? ? ?= 1, >> + ? ? ? ? ? ? .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> ? ? ? }, >> + ? ? .num_consumer_supplies ?= ARRAY_SIZE(goni_ldo13_consumers), >> + ? ? .consumer_supplies ? ? ?= goni_ldo13_consumers, > > Same above. > >> ?}; >> >> ?static struct regulator_init_data goni_ldo14_data = { >> @@ -401,8 +417,10 @@ static struct regulator_init_data goni_ldo14_data = { >> ? ? ? ? ? ? ? .min_uV ? ? ? ? = 1800000, >> ? ? ? ? ? ? ? .max_uV ? ? ? ? = 1800000, >> ? ? ? ? ? ? ? .apply_uV ? ? ? = 1, >> - ? ? ? ? ? ? .always_on ? ? ?= 1, >> + ? ? ? ? ? ? .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> ? ? ? }, >> + ? ? .num_consumer_supplies ?= ARRAY_SIZE(goni_ldo14_consumers), >> + ? ? .consumer_supplies ? ? ?= goni_ldo14_consumers, > > Same above. > >> ?}; >> >> ?static struct regulator_init_data goni_ldo15_data = { >> -- >> 1.7.3.5 > > If required array in there, please let me know. > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at ?http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board 2011-01-28 9:32 ` Kukjin Kim @ 2011-01-28 11:49 ` Sylwester Nawrocki -1 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-28 11:49 UTC (permalink / raw) To: Kukjin Kim Cc: 'Sylwester Nawrocki', linux-arm-kernel, linux-samsung-soc, ben-linux, m.szyprowski, kyungmin.park On 01/28/2011 06:32 PM, Kukjin Kim wrote: > Sylwester Nawrocki wrote: >> >> Add regulator supplies required for NOON010PC30 CIF sensor. >> >> Signed-off-by: Sylwester Nawrocki<s.nawrocki@samsung.com> >> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com> >> --- >> arch/arm/mach-s5pv210/mach-goni.c | 24 +++++++++++++++++++++--- >> 1 files changed, 21 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/mach-s5pv210/mach-goni.c > b/arch/arm/mach-s5pv210/mach- >> goni.c >> index fc34575..2051cee 100644 >> --- a/arch/arm/mach-s5pv210/mach-goni.c >> +++ b/arch/arm/mach-s5pv210/mach-goni.c >> @@ -273,6 +273,18 @@ static struct regulator_consumer_supply >> goni_ldo5_consumers[] = { >> REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"), >> }; >> >> +static struct regulator_consumer_supply goni_ldo11_consumers[] = { >> + REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */ >> +}; > > Need array in goni_ldo11_consumers? > > +static struct regulator_consumer_supply goni_ldo11_consumers = > + REGULATOR_SUPPLY("vddio", "0-0030"); /* "CAM_IO_2.8V" */ > >> + ... >> + >> static struct regulator_init_data goni_ldo2_data = { >> .constraints = { >> .name = "VALIVE_1.1V", >> @@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = { >> .min_uV = 2800000, >> .max_uV = 2800000, >> .apply_uV = 1, >> - .always_on = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> }, >> + .num_consumer_supplies = ARRAY_SIZE(goni_ldo11_consumers), >> + .consumer_supplies = goni_ldo11_consumers, > > If you modify as per my suggestion, then need to change this like following. > > + .num_consumer_supplies = 1, > + .consumer_supplies =&goni_ldo11_consumers, > >> }; Although the current state of this file is not reflecting it, there is more devices sharing the regulators I've added supply definitions for, e.g the second camera in the system. So the arrays are really needed. If I modify it as you as you are suggesting then it will have to be changed when the other supplies are added. Thanks, Sylwester ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board @ 2011-01-28 11:49 ` Sylwester Nawrocki 0 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-28 11:49 UTC (permalink / raw) To: linux-arm-kernel On 01/28/2011 06:32 PM, Kukjin Kim wrote: > Sylwester Nawrocki wrote: >> >> Add regulator supplies required for NOON010PC30 CIF sensor. >> >> Signed-off-by: Sylwester Nawrocki<s.nawrocki@samsung.com> >> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com> >> --- >> arch/arm/mach-s5pv210/mach-goni.c | 24 +++++++++++++++++++++--- >> 1 files changed, 21 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/mach-s5pv210/mach-goni.c > b/arch/arm/mach-s5pv210/mach- >> goni.c >> index fc34575..2051cee 100644 >> --- a/arch/arm/mach-s5pv210/mach-goni.c >> +++ b/arch/arm/mach-s5pv210/mach-goni.c >> @@ -273,6 +273,18 @@ static struct regulator_consumer_supply >> goni_ldo5_consumers[] = { >> REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"), >> }; >> >> +static struct regulator_consumer_supply goni_ldo11_consumers[] = { >> + REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */ >> +}; > > Need array in goni_ldo11_consumers? > > +static struct regulator_consumer_supply goni_ldo11_consumers = > + REGULATOR_SUPPLY("vddio", "0-0030"); /* "CAM_IO_2.8V" */ > >> + ... >> + >> static struct regulator_init_data goni_ldo2_data = { >> .constraints = { >> .name = "VALIVE_1.1V", >> @@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = { >> .min_uV = 2800000, >> .max_uV = 2800000, >> .apply_uV = 1, >> - .always_on = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> }, >> + .num_consumer_supplies = ARRAY_SIZE(goni_ldo11_consumers), >> + .consumer_supplies = goni_ldo11_consumers, > > If you modify as per my suggestion, then need to change this like following. > > + .num_consumer_supplies = 1, > + .consumer_supplies =&goni_ldo11_consumers, > >> }; Although the current state of this file is not reflecting it, there is more devices sharing the regulators I've added supply definitions for, e.g the second camera in the system. So the arrays are really needed. If I modify it as you as you are suggesting then it will have to be changed when the other supplies are added. Thanks, Sylwester ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 3/3] ARM: S5PV210: Change framebuffer window 0 size on GONI 2011-01-07 16:57 ` Sylwester Nawrocki @ 2011-01-07 16:57 ` Sylwester Nawrocki -1 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-07 16:57 UTC (permalink / raw) To: linux-arm-kernel, linux-samsung-soc Cc: kgene.kim, ben-linux, m.szyprowski, kyungmin.park, s.nawrocki Increase virtual size of the frambuffer window 0 for the display panning support. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-s5pv210/mach-goni.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c index 2051cee..ed06f20 100644 --- a/arch/arm/mach-s5pv210/mach-goni.c +++ b/arch/arm/mach-s5pv210/mach-goni.c @@ -108,6 +108,8 @@ static struct s3c_fb_pd_win goni_fb_win0 = { }, .max_bpp = 32, .default_bpp = 16, + .virtual_x = 480, + .virtual_y = 2 * 800, }; static struct s3c_fb_platdata goni_lcd_pdata __initdata = { -- 1.7.3.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 3/3] ARM: S5PV210: Change framebuffer window 0 size on GONI @ 2011-01-07 16:57 ` Sylwester Nawrocki 0 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-07 16:57 UTC (permalink / raw) To: linux-arm-kernel Increase virtual size of the frambuffer window 0 for the display panning support. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-s5pv210/mach-goni.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c index 2051cee..ed06f20 100644 --- a/arch/arm/mach-s5pv210/mach-goni.c +++ b/arch/arm/mach-s5pv210/mach-goni.c @@ -108,6 +108,8 @@ static struct s3c_fb_pd_win goni_fb_win0 = { }, .max_bpp = 32, .default_bpp = 16, + .virtual_x = 480, + .virtual_y = 2 * 800, }; static struct s3c_fb_platdata goni_lcd_pdata __initdata = { -- 1.7.3.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* RE: [PATCH 3/3] ARM: S5PV210: Change framebuffer window 0 size on GONI 2011-01-07 16:57 ` Sylwester Nawrocki @ 2011-01-28 9:35 ` Kukjin Kim -1 siblings, 0 replies; 22+ messages in thread From: Kukjin Kim @ 2011-01-28 9:35 UTC (permalink / raw) To: 'Sylwester Nawrocki', linux-arm-kernel, linux-samsung-soc Cc: ben-linux, m.szyprowski, kyungmin.park Sylwester Nawrocki wrote: > > Increase virtual size of the frambuffer window 0 > for the display panning support. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/mach-s5pv210/mach-goni.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach- > goni.c > index 2051cee..ed06f20 100644 > --- a/arch/arm/mach-s5pv210/mach-goni.c > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -108,6 +108,8 @@ static struct s3c_fb_pd_win goni_fb_win0 = { > }, > .max_bpp = 32, > .default_bpp = 16, > + .virtual_x = 480, > + .virtual_y = 2 * 800, > }; > > static struct s3c_fb_platdata goni_lcd_pdata __initdata = { > -- > 1.7.3.5 Looks ok...but I want to apply with your other 1/3 and 2/3 patches. Will apply this after getting your other patches. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 3/3] ARM: S5PV210: Change framebuffer window 0 size on GONI @ 2011-01-28 9:35 ` Kukjin Kim 0 siblings, 0 replies; 22+ messages in thread From: Kukjin Kim @ 2011-01-28 9:35 UTC (permalink / raw) To: linux-arm-kernel Sylwester Nawrocki wrote: > > Increase virtual size of the frambuffer window 0 > for the display panning support. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/mach-s5pv210/mach-goni.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach- > goni.c > index 2051cee..ed06f20 100644 > --- a/arch/arm/mach-s5pv210/mach-goni.c > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -108,6 +108,8 @@ static struct s3c_fb_pd_win goni_fb_win0 = { > }, > .max_bpp = 32, > .default_bpp = 16, > + .virtual_x = 480, > + .virtual_y = 2 * 800, > }; > > static struct s3c_fb_platdata goni_lcd_pdata __initdata = { > -- > 1.7.3.5 Looks ok...but I want to apply with your other 1/3 and 2/3 patches. Will apply this after getting your other patches. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] ARM: S5PV210: Add GONI board setup for CIF camera support 2011-01-07 16:57 ` Sylwester Nawrocki @ 2011-01-26 12:52 ` Sylwester Nawrocki -1 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-26 12:52 UTC (permalink / raw) To: Sylwester Nawrocki Cc: linux-arm-kernel, linux-samsung-soc, kgene.kim, ben-linux, m.szyprowski, kyungmin.park Hello, On 01/08/2011 01:57 AM, Sylwester Nawrocki wrote: > Hello, > > the following patch series introduces changes in GONI board setup file > required for the CIF camera sensor driver. > The first patch adds the I2C0 bus driver, the second one adds the regulator > supply definitions and the third one just increases virtual size > of the framebuffer window 0 for preview double buffering. > > > The patch series contains: > > [PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board > [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board > [PATCH 3/3] ARM: S5PV210: Change framebuffer window 0 size on GONI > > Created against kgene-for-next branch at: > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > Any comments about these patches? Regards, Sylwester ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH] ARM: S5PV210: Add GONI board setup for CIF camera support @ 2011-01-26 12:52 ` Sylwester Nawrocki 0 siblings, 0 replies; 22+ messages in thread From: Sylwester Nawrocki @ 2011-01-26 12:52 UTC (permalink / raw) To: linux-arm-kernel Hello, On 01/08/2011 01:57 AM, Sylwester Nawrocki wrote: > Hello, > > the following patch series introduces changes in GONI board setup file > required for the CIF camera sensor driver. > The first patch adds the I2C0 bus driver, the second one adds the regulator > supply definitions and the third one just increases virtual size > of the framebuffer window 0 for preview double buffering. > > > The patch series contains: > > [PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board > [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board > [PATCH 3/3] ARM: S5PV210: Change framebuffer window 0 size on GONI > > Created against kgene-for-next branch at: > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > Any comments about these patches? Regards, Sylwester ^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2011-01-28 14:18 UTC | newest] Thread overview: 22+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-01-07 16:57 [PATCH] ARM: S5PV210: Add GONI board setup for CIF camera support Sylwester Nawrocki 2011-01-07 16:57 ` Sylwester Nawrocki 2011-01-07 16:57 ` [PATCH 1/3] ARM: S5PV210: Enable I2C0 bus on GONI board Sylwester Nawrocki 2011-01-07 16:57 ` Sylwester Nawrocki 2011-01-28 9:28 ` Kukjin Kim 2011-01-28 9:28 ` Kukjin Kim 2011-01-28 14:18 ` Sylwester Nawrocki 2011-01-28 14:18 ` Sylwester Nawrocki 2011-01-07 16:57 ` [PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera " Sylwester Nawrocki 2011-01-07 16:57 ` Sylwester Nawrocki 2011-01-28 9:32 ` Kukjin Kim 2011-01-28 9:32 ` Kukjin Kim 2011-01-28 10:53 ` Kyungmin Park 2011-01-28 10:53 ` Kyungmin Park 2011-01-28 11:49 ` Sylwester Nawrocki 2011-01-28 11:49 ` Sylwester Nawrocki 2011-01-07 16:57 ` [PATCH 3/3] ARM: S5PV210: Change framebuffer window 0 size on GONI Sylwester Nawrocki 2011-01-07 16:57 ` Sylwester Nawrocki 2011-01-28 9:35 ` Kukjin Kim 2011-01-28 9:35 ` Kukjin Kim 2011-01-26 12:52 ` [PATCH] ARM: S5PV210: Add GONI board setup for CIF camera support Sylwester Nawrocki 2011-01-26 12:52 ` Sylwester Nawrocki
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.