All of lore.kernel.org
 help / color / mirror / Atom feed
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] add pwmlib support
Date: Sat, 29 Jan 2011 21:53:50 +0100	[thread overview]
Message-ID: <4D447E5E.6060007@metafoo.de> (raw)
In-Reply-To: <1296217283-14531-1-git-send-email-s.hauer@pengutronix.de>

On 01/28/2011 01:21 PM, Sascha Hauer wrote:
> Hi all,
> 
> While implementing just another pwm driver I thought it's time to implement
> generic pwm support. The following series adds drivers/pwm/pwmlib.c and
> a i.MX23/28 pwm driver which serves as a usage example for pwmlib. The
> code is inspired by gpiolib support and tested using the backlight pwm
> driver by Eric Miao.
> 
> Currently the pwm_request, pwm_add, pwm_remove and pwm_free operations are
> protected with a single mutex wherea the pwm_enable, pwm_disable and
> pwm_config operations are unlocked. It is assumed that the owners of the
> pwm handle the serialization of the pwm accesses. This may not be enough, so
> i'd like to discuss the locking (and type of locking) here.
> 
> I Cced the people working with PWMs in the kernel in the hope that they can
> give input on what's missing / wrong in this implementation
> 
> Sascha
> 

Hi

There have been two other proposals for a generic PWM api during the last year.
You might want to take a look at them.

https://lkml.org/lkml/2010/2/9/275
https://lkml.org/lkml/2010/9/28/107

I've added Bill Gatliff and Arun Murthy to Cc.

- Lars

WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Eric Miao <eric.miao@linaro.org>,
	Ben Dooks <ben-linux@fluff.org>,
	Kukjin Kim <kgene.kim@samsung.com>, Hemanth V <hemanthv@ti.com>,
	Jean Delvare <khali@linux-fr.org>,
	linux-arm-kernel@lists.infradead.org,
	Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>,
	Shawn Guo <shawn.guo@freescale.com>,
	Arun Murthy <arun.murthy@stericsson.com>,
	Bill Gatliff <bgat@billgatliff.com>
Subject: Re: [RFC] add pwmlib support
Date: Sat, 29 Jan 2011 21:53:50 +0100	[thread overview]
Message-ID: <4D447E5E.6060007@metafoo.de> (raw)
In-Reply-To: <1296217283-14531-1-git-send-email-s.hauer@pengutronix.de>

On 01/28/2011 01:21 PM, Sascha Hauer wrote:
> Hi all,
> 
> While implementing just another pwm driver I thought it's time to implement
> generic pwm support. The following series adds drivers/pwm/pwmlib.c and
> a i.MX23/28 pwm driver which serves as a usage example for pwmlib. The
> code is inspired by gpiolib support and tested using the backlight pwm
> driver by Eric Miao.
> 
> Currently the pwm_request, pwm_add, pwm_remove and pwm_free operations are
> protected with a single mutex wherea the pwm_enable, pwm_disable and
> pwm_config operations are unlocked. It is assumed that the owners of the
> pwm handle the serialization of the pwm accesses. This may not be enough, so
> i'd like to discuss the locking (and type of locking) here.
> 
> I Cced the people working with PWMs in the kernel in the hope that they can
> give input on what's missing / wrong in this implementation
> 
> Sascha
> 

Hi

There have been two other proposals for a generic PWM api during the last year.
You might want to take a look at them.

https://lkml.org/lkml/2010/2/9/275
https://lkml.org/lkml/2010/9/28/107

I've added Bill Gatliff and Arun Murthy to Cc.

- Lars

  parent reply	other threads:[~2011-01-29 20:53 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-28 12:21 [RFC] add pwmlib support Sascha Hauer
2011-01-28 12:21 ` Sascha Hauer
2011-01-28 12:21 ` [PATCH 1/2] pwmlib: add pwm support Sascha Hauer
2011-01-28 12:21   ` Sascha Hauer
2011-01-30 20:52   ` Ryan Mallon
2011-01-30 20:52     ` Ryan Mallon
2011-01-31  7:49     ` Sascha Hauer
2011-01-31  7:49       ` Sascha Hauer
2011-01-28 12:21 ` [PATCH 2/2] pwm: Add a i.MX23/28 pwm driver Sascha Hauer
2011-01-28 12:21   ` Sascha Hauer
2011-01-28 14:12 ` [RFC] add pwmlib support root
2011-01-28 14:12   ` root
2011-01-29  0:21   ` Matt Sealey
2011-01-29  0:21     ` Matt Sealey
2011-01-29 20:38 ` Jean Delvare
2011-01-29 20:38   ` Jean Delvare
2011-01-29 21:51   ` Wolfram Sang
2011-01-29 21:51     ` Wolfram Sang
2011-01-30  3:49     ` arden jay
2011-01-30  3:49       ` arden jay
2011-01-31  7:58       ` Sascha Hauer
2011-01-31  7:58         ` Sascha Hauer
2011-02-06 13:22         ` Linus Walleij
2011-02-06 13:22           ` Linus Walleij
2011-01-29 20:53 ` Lars-Peter Clausen [this message]
2011-01-29 20:53   ` Lars-Peter Clausen
2011-01-31  3:35   ` Arun MURTHY
2011-01-31  3:35     ` Arun MURTHY
2011-01-31  7:54     ` Sascha Hauer
2011-01-31  7:54       ` Sascha Hauer
2011-01-31 12:48       ` Lars-Peter Clausen
2011-01-31 12:48         ` Lars-Peter Clausen
2011-01-31 13:00         ` Sascha Hauer
2011-01-31 13:00           ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D447E5E.6060007@metafoo.de \
    --to=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.