From: Daniel Lezcano <daniel.lezcano@free.fr>
To: Oleg Nesterov <oleg@redhat.com>
Cc: akpm@linux-foundation.org, ebiederm@xmission.com,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, clg@fr.ibm.com
Subject: Re: [PATCH 2/4] pidns: Call pid_ns_prepare_proc from create_pid_namespace
Date: Mon, 31 Jan 2011 14:33:25 +0100 [thread overview]
Message-ID: <4D46BA25.8080201@free.fr> (raw)
In-Reply-To: <20110131132207.GA26995@redhat.com>
On 01/31/2011 02:22 PM, Oleg Nesterov wrote:
> On 01/31, Daniel Lezcano wrote:
>> @@ -96,6 +97,9 @@ static struct pid_namespace *create_pid_namespace(struct pid_namespace *parent_p
>> for (i = 1; i< PIDMAP_ENTRIES; i++)
>> atomic_set(&ns->pidmap[i].nr_free, BITS_PER_PAGE);
>>
>> + if (pid_ns_prepare_proc(ns))
>> + goto out_free_map;
>> +
>> return ns;
> This is not right, afaics. I already sent the similar patches, but
> they were ignored ;)
>
> Please see http://marc.info/?l=linux-kernel&m=127697484000334
>
> If pid_ns_prepare_proc() fails we shouldn't blindly return ENOMEM
> and, more importantly, we need put_pid_ns(parent_ns).
Oh, ok. Right. Thanks for the pointer.
Are you ok if I replace the patch 2/4 with your patch ?
next prev parent reply other threads:[~2011-01-31 13:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 10:25 Prepare for the unshare support of the pid namespace Daniel Lezcano
2011-01-31 10:25 ` [PATCH 1/4] pid: Remove the child_reaper special case in init/main.c Daniel Lezcano
2011-01-31 10:25 ` [PATCH 2/4] pidns: Call pid_ns_prepare_proc from create_pid_namespace Daniel Lezcano
2011-01-31 13:22 ` Oleg Nesterov
2011-01-31 13:33 ` Daniel Lezcano [this message]
2011-01-31 14:02 ` Oleg Nesterov
[not found] ` <20110131140257.GA28827-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-01-31 14:21 ` Daniel Lezcano
2011-01-31 14:21 ` Daniel Lezcano
[not found] ` <4D46BA25.8080201-GANU6spQydw@public.gmane.org>
2011-01-31 14:02 ` Oleg Nesterov
[not found] ` <20110131132207.GA26995-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-01-31 13:33 ` Daniel Lezcano
[not found] ` <1296469525-30111-3-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-01-31 13:22 ` Oleg Nesterov
[not found] ` <1296469525-30111-1-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-01-31 10:25 ` [PATCH 1/4] pid: Remove the child_reaper special case in init/main.c Daniel Lezcano
2011-01-31 10:25 ` [PATCH 2/4] pidns: Call pid_ns_prepare_proc from create_pid_namespace Daniel Lezcano
2011-01-31 10:25 ` [PATCH 3/4] procfs: kill the global proc_mnt variable Daniel Lezcano
2011-01-31 10:25 ` [PATCH 4/4] pidns: Use task_active_pid_ns where appropriate Daniel Lezcano
2011-01-31 10:25 ` [PATCH 3/4] procfs: kill the global proc_mnt variable Daniel Lezcano
2011-01-31 10:25 ` [PATCH 4/4] pidns: Use task_active_pid_ns where appropriate Daniel Lezcano
[not found] ` <1296469525-30111-5-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-01-31 11:26 ` Alexey Dobriyan
2011-01-31 11:26 ` Alexey Dobriyan
2011-01-31 14:47 ` Daniel Lezcano
[not found] ` <4D46CB9E.1090802-GANU6spQydw@public.gmane.org>
2011-01-31 15:36 ` Oleg Nesterov
2011-01-31 15:36 ` Oleg Nesterov
2011-02-01 10:07 ` Daniel Lezcano
[not found] ` <20110131153653.GA32392-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-02-01 10:07 ` Daniel Lezcano
[not found] ` <AANLkTikjcou-0b4NejpY66qXeZuzsC-M+oNTyHk=OE-Z-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-01-31 14:47 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D46BA25.8080201@free.fr \
--to=daniel.lezcano@free.fr \
--cc=akpm@linux-foundation.org \
--cc=clg@fr.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.