From: Daniel Lezcano <daniel.lezcano@free.fr>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
akpm@linux-foundation.org, ebiederm@xmission.com,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, clg@fr.ibm.com
Subject: Re: [PATCH 4/4] pidns: Use task_active_pid_ns where appropriate
Date: Tue, 01 Feb 2011 11:07:02 +0100 [thread overview]
Message-ID: <4D47DB46.70203@free.fr> (raw)
In-Reply-To: <20110131153653.GA32392@redhat.com>
On 01/31/2011 04:36 PM, Oleg Nesterov wrote:
> On 01/31, Daniel Lezcano wrote:
>> On 01/31/2011 12:26 PM, Alexey Dobriyan wrote:
>>> This task_active_pid_ns() is misnamed(?) because it does matter only
>>> for dead tasks?
>> Actually this function is later used, for the unshare, to get the pid_ns
>> of a specific task, not the current one.
> Well, it is already used to get the pid_ns of !current task.
>
>> http://kerneltrap.org/mailarchive/linux-kernel/2010/6/20/4585095
> The actual need for this change is that you are going to complicate
> the things so that current->proxy->pid_ns != task_active_pid_ns().
> This makes me cry ;)
Mmh, ok that makes sense.
> Please don't forget, this patch is buggy, iirc...
Ok, I will resend the cleanup patchset without this patch.
next prev parent reply other threads:[~2011-02-01 10:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 10:25 Prepare for the unshare support of the pid namespace Daniel Lezcano
2011-01-31 10:25 ` [PATCH 1/4] pid: Remove the child_reaper special case in init/main.c Daniel Lezcano
2011-01-31 10:25 ` [PATCH 2/4] pidns: Call pid_ns_prepare_proc from create_pid_namespace Daniel Lezcano
[not found] ` <1296469525-30111-3-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-01-31 13:22 ` Oleg Nesterov
2011-01-31 13:22 ` Oleg Nesterov
[not found] ` <20110131132207.GA26995-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-01-31 13:33 ` Daniel Lezcano
2011-01-31 13:33 ` Daniel Lezcano
2011-01-31 14:02 ` Oleg Nesterov
2011-01-31 14:21 ` Daniel Lezcano
[not found] ` <20110131140257.GA28827-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-01-31 14:21 ` Daniel Lezcano
[not found] ` <4D46BA25.8080201-GANU6spQydw@public.gmane.org>
2011-01-31 14:02 ` Oleg Nesterov
2011-01-31 10:25 ` [PATCH 3/4] procfs: kill the global proc_mnt variable Daniel Lezcano
[not found] ` <1296469525-30111-1-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-01-31 10:25 ` [PATCH 1/4] pid: Remove the child_reaper special case in init/main.c Daniel Lezcano
2011-01-31 10:25 ` [PATCH 2/4] pidns: Call pid_ns_prepare_proc from create_pid_namespace Daniel Lezcano
2011-01-31 10:25 ` [PATCH 3/4] procfs: kill the global proc_mnt variable Daniel Lezcano
2011-01-31 10:25 ` [PATCH 4/4] pidns: Use task_active_pid_ns where appropriate Daniel Lezcano
2011-01-31 10:25 ` Daniel Lezcano
[not found] ` <1296469525-30111-5-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-01-31 11:26 ` Alexey Dobriyan
2011-01-31 11:26 ` Alexey Dobriyan
2011-01-31 14:47 ` Daniel Lezcano
2011-01-31 15:36 ` Oleg Nesterov
2011-02-01 10:07 ` Daniel Lezcano [this message]
[not found] ` <20110131153653.GA32392-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-02-01 10:07 ` Daniel Lezcano
[not found] ` <4D46CB9E.1090802-GANU6spQydw@public.gmane.org>
2011-01-31 15:36 ` Oleg Nesterov
[not found] ` <AANLkTikjcou-0b4NejpY66qXeZuzsC-M+oNTyHk=OE-Z-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-01-31 14:47 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D47DB46.70203@free.fr \
--to=daniel.lezcano@free.fr \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=clg@fr.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.