Re: [PATCH][SVM] Fix 32bit Windows guest VMs save/restore

[Wei Huang <wei.huang2@amd.com>]

Hi Keir,

My comments inline below.

-Wei
On 01/31/2011 03:13 PM, Keir Fraser wrote:
> On 31/01/2011 18:33, "Wei Huang"<wei.huang2@amd.com>  wrote:
>
>> The attached patch fixes the save/restore issue seen with 32bit Windows
>> guest VMs. The root cause is that current Xen doesn't intercept
>> SYSENTER-related MSRs for 32bit guest VMs. As a result, the
>> guest_sysenter_xxx fields contain incorrect values and shouldn't be used
>> for save/restore. This patch checks the LMA bit of EFER register in the
>> save/restore code path.
>>
>> Please apply it to both Xen-4.0 and Xen-unstable trees.
>>
>> Reported-by: James Harper<james.harper@bendigoit.com.au>
>> Signed-off-by: Wei Huang<wei.huang2@amd.com>
>> Acked-by: Christoph Egger<christoph.egger@amd.com>
> Nacked-by: Keir Fraser<keir@xen.org>
>
> This handling of the SYSENTER MSRs is overly complicated. I suggest
> reverting a bunch of the original handling of cross-vendor migration as
> follows:
>   * Never intercept the SYSENTER MSRs.
The reason for Christoph to create this patch is AMD doesn't support 
SYSENTER in long mode. If we don't intercept MSRs under long mode, we 
will get stuck with #UD after migration from Intel platform. Did you 
actually mean "* Always intercept the SYSENTER MSRs" here?
>   * Remove the vcpu->arch.hvm_svm.guest_sysenter_* fields.
>   * Always hvm save/restore from/to the values in the vmcb.
>   * Modify svm_msr_read_intercept(MSR_IA32_SYSENTER_*) to svm_sync_vmcb() and
> then read the sysenter msr value from vmcb
>   * Modify svm_msr_write_intercept(MSR_IA32_SYSENTER_*) to svm_sync_vmcb(),
> then modify the sysenter msr in the vmcb, and then svm_vmload().
>
> Result is that we get rid of some redundant fields from the vcpu structure
> and have one canonical place we always keep the sysenter msr values, in the
> vmcb. The extra cost in the msr read/write functions is totally
> inconsequential, and only used after guest migration from an Intel CPU
> anyway. Hardly something to optimise for.
>
>   -- Keir
>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>