All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Huang <wei.huang2@amd.com>
To: Keir Fraser <keir@xen.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"james.harper@bendigoit.com.au" <james.harper@bendigoit.com.au>
Subject: Re: [PATCH][SVM] Fix 32bit Windows guest VMs save/restore
Date: Mon, 31 Jan 2011 15:43:10 -0600	[thread overview]
Message-ID: <4D472CEE.6060802@amd.com> (raw)
In-Reply-To: <C96CE57D.165CF%keir@xen.org>

This is true. I thought about it. Some problematic code path can be 
"enter 32bit mode => execute sysenter => turn on long mode" (or vice 
versa). In this case, SYSENTER MSRs should be copied from VMCB to vcpu 
fields. But current Xen doesn't do so.

-Wei

On 01/31/2011 03:17 PM, Keir Fraser wrote:
>   suspect the current approach has
> further bugs because I don't believe the canonical sysenter msr values are
> correctly shuffled between the vmcb and vcpu structures

  reply	other threads:[~2011-01-31 21:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31 17:33 [PATCH][SVM] Fix 32bit Windows guest VMs save/restore Wei Huang
2011-01-31 21:13 ` Keir Fraser
2011-01-31 21:17   ` Keir Fraser
2011-01-31 21:43     ` Wei Huang [this message]
2011-01-31 21:38   ` Wei Huang
2011-02-01  6:14     ` Keir Fraser
2011-02-01  6:25       ` Wei Huang
2011-02-01  8:14         ` Keir Fraser
2011-02-01 21:06           ` Wei Huang
2011-02-01 22:35             ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D472CEE.6060802@amd.com \
    --to=wei.huang2@amd.com \
    --cc=james.harper@bendigoit.com.au \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.