Policy on (committing) large (1MB) machine specific patches?

Policy on (committing) large (1MB) machine specific patches?

[Leon Woestenberg]

Hello,

I would like to submit another machine to OE, but I need to bring in
vendor patches (which do not apply cleanly) modified by me, so they
have no Internet presence.
The patches measure in 1MB of plain source text.

Is it policy to commit this? Where is the limit?


I see we have lots of large patches:

cd openembedded.git/recipes/linux/
ls -Sshr `find . -type f -regex .*patch$`

...many of them appearing multiple times in the checkout:

ls -Shr `find . -type f -regex .*patch$` | xargs -L1 md5sum

eating disk space on the build machine.


Regards,
-- 
Leon

Re: Policy on (committing) large (1MB) machine specific patches?

[Tom Rini]

On 02/01/2011 04:15 PM, Leon Woestenberg wrote:
> Hello,
>
> I would like to submit another machine to OE, but I need to bring in
> vendor patches (which do not apply cleanly) modified by me, so they
> have no Internet presence.
> The patches measure in 1MB of plain source text.
>
> Is it policy to commit this? Where is the limit?
>
>
> I see we have lots of large patches:
>
> cd openembedded.git/recipes/linux/
> ls -Sshr `find . -type f -regex .*patch$`
>
> ...many of them appearing multiple times in the checkout:
>
> ls -Shr `find . -type f -regex .*patch$` | xargs -L1 md5sum
>
> eating disk space on the build machine.

I am of the opinion that these things should be heavily compressed and 
appropriate comments used in the recipe like:
# Vendor Foo's release $identifier patchset updated to apply cleanly to
# 2.6.blah.

With any further bugfixes/etc done as regular and separate patches.

-- 
Tom Rini
Mentor Graphics Corporation