PR and .bbappend

PR and .bbappend

[Gary Thomas]

Should .bbappend files have a PR in them?  If so, must it
match the one in the main .bb file?

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: PR and .bbappend

[Chris Larson]

On Wed, Feb 2, 2011 at 8:03 AM, Gary Thomas <gary@mlbassoc.com> wrote:
> Should .bbappend files have a PR in them?  If so, must it
> match the one in the main .bb file?

All metadata in a .bbappend is essentially concatenated to the recipe.
 If you define PR in the .bbappend, it will override the one in the
recipe, which is unlikely what you want, as that loses information.
The better route is to do something like PR .= ".1" in the .bbappend,
and bump that when changing the bbappend file.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

Re: PR and .bbappend

[Mark Hatle]

On 2/2/11 9:13 AM, Chris Larson wrote:
> On Wed, Feb 2, 2011 at 8:03 AM, Gary Thomas <gary@mlbassoc.com> wrote:
>> Should .bbappend files have a PR in them?  If so, must it
>> match the one in the main .bb file?
> 
> All metadata in a .bbappend is essentially concatenated to the recipe.
>  If you define PR in the .bbappend, it will override the one in the
> recipe, which is unlikely what you want, as that loses information.
> The better route is to do something like PR .= ".1" in the .bbappend,
> and bump that when changing the bbappend file.

I was going to suggest the same thing.  A good approach is to append a value to
the existing PR.  (I suggest this get added as a best practice in the
documentation on bbappend...  I'm not sure who the correct person is to point
this out to though.)

--Mark

Re: PR and .bbappend

[Darren Hart]

On 02/02/2011 07:17 AM, Mark Hatle wrote:
> On 2/2/11 9:13 AM, Chris Larson wrote:
>> On Wed, Feb 2, 2011 at 8:03 AM, Gary Thomas<gary@mlbassoc.com>  wrote:
>>> Should .bbappend files have a PR in them?  If so, must it
>>> match the one in the main .bb file?
>>
>> All metadata in a .bbappend is essentially concatenated to the recipe.
>>   If you define PR in the .bbappend, it will override the one in the
>> recipe, which is unlikely what you want, as that loses information.
>> The better route is to do something like PR .= ".1" in the .bbappend,
>> and bump that when changing the bbappend file.
>
> I was going to suggest the same thing.  A good approach is to append a value to
> the existing PR.  (I suggest this get added as a best practice in the
> documentation on bbappend...  I'm not sure who the correct person is to point
> this out to though.)

That would be Scott R, on CC.

>
> --Mark
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky


-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel