From: Jan Kiszka <jan.kiszka@web.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Avi Kivity <avi@redhat.com>, Huang Ying <ying.huang@intel.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Jin Dongming <jin.dongming@np.css.fujitsu.com>
Subject: [PATCH] x86: Fix MCA broadcast parameters for TCG case
Date: Wed, 02 Feb 2011 21:35:26 +0100 [thread overview]
Message-ID: <4D49C00E.6090104@web.de> (raw)
In-Reply-To: <AANLkTikmyu4jiB27yUhE-fZ4ZbiHG3WkBL-8vPv94HUV@mail.gmail.com>
On 2011-02-02 20:05, Blue Swirl wrote:
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> target-i386/helper.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index 1217452..4bbf9b1 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -1148,7 +1148,7 @@ void cpu_inject_x86_mce(CPUState *cenv, int
> bank, uint64_t status,
> continue;
> }
>
> - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
> + qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0, 0);
> }
> }
> }
Let's fix this for real, the value is wrong anyway:
----------8<----------
From: Jan Kiszka <jan.kiszka@siemens.com>
When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like
it is done for KVM. Use the symbolic constants at this chance.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
target-i386/helper.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index d74b6e3..f41416f 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -1145,8 +1145,8 @@ void cpu_inject_x86_mce(CPUState *cenv, int bank, uint64_t status,
if (cenv == env) {
continue;
}
-
- qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
+ qemu_inject_x86_mce(env, 1, MCI_STATUS_VAL | MCI_STATUS_UC,
+ MCG_STATUS_MCIP | MCG_STATUS_RIPV, 0, 0);
}
}
}
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
kvm <kvm@vger.kernel.org>, Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>,
Huang Ying <ying.huang@intel.com>,
Jin Dongming <jin.dongming@np.css.fujitsu.com>
Subject: [Qemu-devel] [PATCH] x86: Fix MCA broadcast parameters for TCG case
Date: Wed, 02 Feb 2011 21:35:26 +0100 [thread overview]
Message-ID: <4D49C00E.6090104@web.de> (raw)
In-Reply-To: <AANLkTikmyu4jiB27yUhE-fZ4ZbiHG3WkBL-8vPv94HUV@mail.gmail.com>
On 2011-02-02 20:05, Blue Swirl wrote:
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> target-i386/helper.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index 1217452..4bbf9b1 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -1148,7 +1148,7 @@ void cpu_inject_x86_mce(CPUState *cenv, int
> bank, uint64_t status,
> continue;
> }
>
> - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
> + qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0, 0);
> }
> }
> }
Let's fix this for real, the value is wrong anyway:
----------8<----------
From: Jan Kiszka <jan.kiszka@siemens.com>
When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like
it is done for KVM. Use the symbolic constants at this chance.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
target-i386/helper.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index d74b6e3..f41416f 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -1145,8 +1145,8 @@ void cpu_inject_x86_mce(CPUState *cenv, int bank, uint64_t status,
if (cenv == env) {
continue;
}
-
- qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
+ qemu_inject_x86_mce(env, 1, MCI_STATUS_VAL | MCI_STATUS_UC,
+ MCG_STATUS_MCIP | MCG_STATUS_RIPV, 0, 0);
}
}
}
--
1.7.1
next prev parent reply other threads:[~2011-02-02 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 19:05 [Qemu-devel] [PATCH 0.14] Fix build on 32 bit hosts Blue Swirl
2011-02-02 20:35 ` Jan Kiszka [this message]
2011-02-02 20:35 ` [Qemu-devel] [PATCH] x86: Fix MCA broadcast parameters for TCG case Jan Kiszka
2011-02-04 13:58 ` Marcelo Tosatti
2011-02-04 13:58 ` [Qemu-devel] " Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D49C00E.6090104@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.