Re: [PATCH] stemodem: Check for ok in voicecall_initialize.

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

Hi Marit,

On 02/03/2011 07:13 AM, Marit Henriksen wrote:
> From: Marit Henriksen <marit.henriksen@stericsson.com>
> 
> ---
>  drivers/stemodem/voicecall.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/stemodem/voicecall.c b/drivers/stemodem/voicecall.c
> index fa078a8..2eaba8c 100644
> --- a/drivers/stemodem/voicecall.c
> +++ b/drivers/stemodem/voicecall.c
> @@ -522,6 +522,10 @@ static void ste_voicecall_initialized(gboolean ok, GAtResult *result,
>  	struct ofono_voicecall *vc = user_data;
>  	struct voicecall_data *vd = ofono_voicecall_get_data(vc);
>  
> +	if (!ok)
> +		ofono_error("*ECAV not enabled. "
> +				"Do not have proper call handling");
> +

Why do you still register the atom here? Should you also call
ofono_voicecall_remove() and return here?

>  	g_at_chat_register(vd->chat, "*ECAV:", ecav_notify, FALSE, vc, NULL);
>  	ofono_voicecall_register(vc);
>  }

Regards,
-Denis