* [PATCH] stemodem: Check for ok in voicecall_initialize.
@ 2011-02-03 13:13 Marit Henriksen
2011-02-03 16:13 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Marit Henriksen @ 2011-02-03 13:13 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
From: Marit Henriksen <marit.henriksen@stericsson.com>
---
drivers/stemodem/voicecall.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/stemodem/voicecall.c b/drivers/stemodem/voicecall.c
index fa078a8..2eaba8c 100644
--- a/drivers/stemodem/voicecall.c
+++ b/drivers/stemodem/voicecall.c
@@ -522,6 +522,10 @@ static void ste_voicecall_initialized(gboolean ok, GAtResult *result,
struct ofono_voicecall *vc = user_data;
struct voicecall_data *vd = ofono_voicecall_get_data(vc);
+ if (!ok)
+ ofono_error("*ECAV not enabled. "
+ "Do not have proper call handling");
+
g_at_chat_register(vd->chat, "*ECAV:", ecav_notify, FALSE, vc, NULL);
ofono_voicecall_register(vc);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] stemodem: Check for ok in voicecall_initialize.
2011-02-03 13:13 [PATCH] stemodem: Check for ok in voicecall_initialize Marit Henriksen
@ 2011-02-03 16:13 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2011-02-03 16:13 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 974 bytes --]
Hi Marit,
On 02/03/2011 07:13 AM, Marit Henriksen wrote:
> From: Marit Henriksen <marit.henriksen@stericsson.com>
>
> ---
> drivers/stemodem/voicecall.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/stemodem/voicecall.c b/drivers/stemodem/voicecall.c
> index fa078a8..2eaba8c 100644
> --- a/drivers/stemodem/voicecall.c
> +++ b/drivers/stemodem/voicecall.c
> @@ -522,6 +522,10 @@ static void ste_voicecall_initialized(gboolean ok, GAtResult *result,
> struct ofono_voicecall *vc = user_data;
> struct voicecall_data *vd = ofono_voicecall_get_data(vc);
>
> + if (!ok)
> + ofono_error("*ECAV not enabled. "
> + "Do not have proper call handling");
> +
Why do you still register the atom here? Should you also call
ofono_voicecall_remove() and return here?
> g_at_chat_register(vd->chat, "*ECAV:", ecav_notify, FALSE, vc, NULL);
> ofono_voicecall_register(vc);
> }
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-03 16:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-03 13:13 [PATCH] stemodem: Check for ok in voicecall_initialize Marit Henriksen
2011-02-03 16:13 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.