From: Christophe Lyon <christophe.lyon@st.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 6/8] target-arm: Fix Neon VQ(R)SHRN instructions.
Date: Mon, 7 Feb 2011 17:50:46 +0100 [thread overview]
Message-ID: <4D5022E6.4040704@st.com> (raw)
In-Reply-To: <AANLkTi=FNncmFTFDCBgazeWVvUOyWjEeytOgr5DMrJX7@mail.gmail.com>
On 07.02.2011 17:08, Peter Maydell wrote:
> On 31 January 2011 18:06, <christophe.lyon@st.com> wrote:
>> From: Christophe Lyon <christophe.lyon@st.com>
>>
>> Handle unsigned variant of VQ(R)SHRN instructions.
>
> This patch appears to be modifying a section of code
> that was already patched by 2/8 in this series. That's
> too confusing to review -- please combine them into
> one patch.
>
That's because I borrowed patch 2/8 from your meego tree. It was incomplete, but as I preferred to keep it as-is, I completed it in a separate patch.
>From your other comments it looks like I'd have had better ignore the patches from Meego and rewrite the patches on my own ;-)
next prev parent reply other threads:[~2011-02-07 16:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 18:06 [Qemu-devel] [PATCH v2 0/8] target-arm: Fix Neon instructions VQMOVUN VQRSHL VQRSHRN VQRSHRUN VQSHRN VQSHRUN VSLI VSRI christophe.lyon
2011-01-31 18:06 ` [Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA christophe.lyon
2011-02-07 15:57 ` Peter Maydell
2011-02-09 12:16 ` Christophe Lyon
2011-01-31 18:06 ` [Qemu-devel] [PATCH 2/8] target-arm: Create and use neon_unarrow_sat* helpers christophe.lyon
2011-01-31 18:06 ` [Qemu-devel] [PATCH 3/8] target-arm: VQRSHRN related changes christophe.lyon
2011-02-08 13:41 ` Peter Maydell
2011-01-31 18:06 ` [Qemu-devel] [PATCH 4/8] target-arm: fiddle decoding of 64 bit shift by imm and narrow christophe.lyon
2011-02-08 13:49 ` Peter Maydell
2011-01-31 18:06 ` [Qemu-devel] [PATCH 5/8] target-arm: fix neon vqrshl instruction christophe.lyon
2011-01-31 18:06 ` [Qemu-devel] [PATCH 6/8] target-arm: Fix Neon VQ(R)SHRN instructions christophe.lyon
2011-02-07 16:08 ` Peter Maydell
2011-02-07 16:50 ` Christophe Lyon [this message]
2011-02-07 17:01 ` Peter Maydell
2011-01-31 18:06 ` [Qemu-devel] [PATCH 7/8] target-arm: implement vsli.64, vsri.64 christophe.lyon
2011-02-07 15:55 ` Peter Maydell
2011-02-07 16:14 ` Peter Maydell
2011-01-31 18:06 ` [Qemu-devel] [PATCH 8/8] target-arm: Fix VQRSHL Neon instructions (signed/unsigned 64 bits and signed 32 bits variants) christophe.lyon
-- strict thread matches above, loose matches on Subject: below --
2011-01-28 15:50 [Qemu-devel] [PATCH 0/8] target-arm: Fix Neon instructions VQMOVUN VQRSHL VQRSHRN VQRSHRUN VQSHRN VQSHRUN VSLI VSRI christophe.lyon
2011-01-28 15:51 ` [Qemu-devel] [PATCH 6/8] target-arm: Fix Neon VQ(R)SHRN instructions christophe.lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5022E6.4040704@st.com \
--to=christophe.lyon@st.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.