Re: [PATCH] voicecall: fix transfer

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

Hi Andre,

> @@ -1350,11 +1351,12 @@ static DBusMessage *manager_transfer(DBusConnection *conn,
>  	 * implementing the call transfer operation for a call that is
>  	 * still dialing/alerting.
>  	 */
> -	numactive += voicecalls_num_connecting(vc);
> +	numconn = voicecalls_num_connecting(vc);
>  
>  	numheld = voicecalls_num_held(vc);
>  
> -	if ((numactive != 1) && (numheld != 1))

I don't get it, isn't the above condition taking care of this already?
Its been a while but the precondition of ECT is:

Held Call
Outgoing or an Active call.  You cannot have an Outgoing and an Active
call at the same time.  Hence numactive == 1 && numheld == 1 should work
just fine.

> +	if ((numactive > 1 || numheld > 1) ||
> +		((numheld + numactive + numconn) != 2))
>  		return __ofono_error_failed(msg);
>  
>  	if (vc->driver->transfer == NULL)

Regards,
-Denis