Re: [PATCH] voicecall: fix transfer

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 942 bytes --]

Hi Andre,

>     when submitting patches please follow our coding style guidelines.  You
>     had at least 1 style violation, namely rule M4.
> 
> 
> That is strange i run checkpatch  on the code i did not get any warning.
> Is there a  better script for the checking the patches before sending?

We follow Linux kernel coding style + a few extra rules.  These are not
covered by checkpatch.  See doc/coding-style.txt for a fairly
comprehensive list of them.

Nobody has yet volunteered to maintain a checkpatch style script for
oFono specifically, so today we rely on the review process to find most
of these violations.  Much of the codebase is consistent with these
rules, but you will find some inconsistencies in the code that was
written before some of these rules went into effect.  If you do, then
feel free to send a patch ;)

If in doubt check doc/coding-style.txt or the rest of the code.

Regards,
-Denis