DISTRO_FEATURES only extendable?

DISTRO_FEATURES only extendable?

[Gary Thomas]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

I have my own distribution which is an extension of Poky
(my DISTRO.conf is based on poky.conf via requires)

Is there some reason that DISTRO_FEATURES is fixed by poky.conf
and not overridable?  e.g. my systems seldom have WiFi or PCMCIA,
so it's silly to include that support.

Would the attached patch be acceptable to the mainstream?

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

[-- Attachment #2: poky-distro.patch --]
[-- Type: text/plain, Size: 581 bytes --]

diff --git a/meta/conf/distro/poky.conf b/meta/conf/distro/poky.conf
index aeab039..64a2b1d 100644
--- a/meta/conf/distro/poky.conf
+++ b/meta/conf/distro/poky.conf
@@ -111,7 +111,7 @@ LIMIT_BUILT_LOCALES ?= "POSIX en_US en_GB"
 ENABLE_BINARY_LOCALE_GENERATION ?= "1"
 LOCALE_UTF8_ONLY = "0"
 
-DISTRO_FEATURES = "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci"
+DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci"
 
 POKY_EXTRA_RDEPENDS = "task-poky-boot"
 POKY_EXTRA_RDEPENDS_qemuarm = "qemu-config"

Re: DISTRO_FEATURES only extendable?

[Chris Larson]

On Mon, Feb 7, 2011 at 2:32 PM, Gary Thomas <gary@mlbassoc.com> wrote:
> I have my own distribution which is an extension of Poky
> (my DISTRO.conf is based on poky.conf via requires)
>
> Is there some reason that DISTRO_FEATURES is fixed by poky.conf
> and not overridable?  e.g. my systems seldom have WiFi or PCMCIA,
> so it's silly to include that support.
>
> Would the attached patch be acceptable to the mainstream?

Note that there's no reason you can't override it now, just do it
after the require of poky.conf :)  Of course, using ?= makes it easier
to override it from local.conf without using an override, but they are
*distro* features after all, its intended to be in the distro's hands.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics