From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] stemodem: fix possible memory leak
Date: Mon, 07 Feb 2011 21:58:58 -0600 [thread overview]
Message-ID: <4D50BF82.9060607@gmail.com> (raw)
In-Reply-To: <1297119772-17987-1-git-send-email-jeevaka.badrappan@elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
Hi Jeevaka,
On 02/07/2011 05:02 PM, Jeevaka Badrappan wrote:
> ---
> drivers/stemodem/voicecall.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/stemodem/voicecall.c b/drivers/stemodem/voicecall.c
> index ca275cd..dd5d009 100644
> --- a/drivers/stemodem/voicecall.c
> +++ b/drivers/stemodem/voicecall.c
> @@ -491,6 +491,7 @@ static void ecav_notify(GAtResult *result, gpointer user_data)
>
> vd->local_release &= ~(1 << existing_call->id);
> vd->calls = g_slist_remove(vd->calls, l->data);
> + g_free(existing_call);
> break;
> }
>
Sure looks like a leak to me. Patch has been applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2011-02-08 3:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 23:02 [PATCH] stemodem: fix possible memory leak Jeevaka Badrappan
2011-02-08 3:58 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D50BF82.9060607@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.