All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] stemodem: fix possible memory leak
@ 2011-02-07 23:02 Jeevaka Badrappan
  2011-02-08  3:58 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: Jeevaka Badrappan @ 2011-02-07 23:02 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

---
 drivers/stemodem/voicecall.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/stemodem/voicecall.c b/drivers/stemodem/voicecall.c
index ca275cd..dd5d009 100644
--- a/drivers/stemodem/voicecall.c
+++ b/drivers/stemodem/voicecall.c
@@ -491,6 +491,7 @@ static void ecav_notify(GAtResult *result, gpointer user_data)
 
 		vd->local_release &= ~(1 << existing_call->id);
 		vd->calls = g_slist_remove(vd->calls, l->data);
+		g_free(existing_call);
 		break;
 	}
 
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] stemodem: fix possible memory leak
  2011-02-07 23:02 [PATCH] stemodem: fix possible memory leak Jeevaka Badrappan
@ 2011-02-08  3:58 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2011-02-08  3:58 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]

Hi Jeevaka,

On 02/07/2011 05:02 PM, Jeevaka Badrappan wrote:
> ---
>  drivers/stemodem/voicecall.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/stemodem/voicecall.c b/drivers/stemodem/voicecall.c
> index ca275cd..dd5d009 100644
> --- a/drivers/stemodem/voicecall.c
> +++ b/drivers/stemodem/voicecall.c
> @@ -491,6 +491,7 @@ static void ecav_notify(GAtResult *result, gpointer user_data)
>  
>  		vd->local_release &= ~(1 << existing_call->id);
>  		vd->calls = g_slist_remove(vd->calls, l->data);
> +		g_free(existing_call);
>  		break;
>  	}
>  

Sure looks like a leak to me.  Patch has been applied, thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-02-08  3:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-07 23:02 [PATCH] stemodem: fix possible memory leak Jeevaka Badrappan
2011-02-08  3:58 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.