From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 21/20] ata_piix: add new PIIX_FLAG_* flags
Date: Tue, 08 Feb 2011 20:12:12 +0300 [thread overview]
Message-ID: <4D51796C.8020008@ru.mvista.com> (raw)
In-Reply-To: <201102081652.36752.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
> Turn open-coded checks in piix_set_timings() into PIIX_FLAG_* flags
> per suggestion from Alan Cox.
> Suggested-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
[...]
> Index: b/drivers/ata/ata_piix.c
> ===================================================================
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -133,6 +133,8 @@ enum {
>
> PIIX_FLAG_CHECKINTR = (1 << 28), /* make sure PCI INTx enabled */
> PIIX_FLAG_SIDPR = (1 << 29), /* SATA idx/data pair regs */
> + PIIX_FLAG_NO_SITRE = (1 << 30), /* no SITRE register */
The register in question is called SIDETIM, SITRE is a bit that enables its use.
WBR, Sergei
next prev parent reply other threads:[~2011-02-08 17:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 15:52 [PATCH 21/20] ata_piix: add new PIIX_FLAG_* flags Bartlomiej Zolnierkiewicz
2011-02-08 16:03 ` Bartlomiej Zolnierkiewicz
2011-02-08 17:12 ` Sergei Shtylyov [this message]
2011-02-08 18:18 ` Bartlomiej Zolnierkiewicz
2011-02-08 18:30 ` Sergei Shtylyov
2011-02-09 9:10 ` Bartlomiej Zolnierkiewicz
2011-02-11 13:04 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D51796C.8020008@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.