* 2.6.27.58-rc1 build error Re: [PATCH 21/23] hvc_console: Fix race between hvc_close and hvc_remove
@ 2011-02-09 3:20 Jayson R. King
2011-02-09 5:52 ` [stable] " Willy Tarreau
2011-02-09 9:44 ` Alan Cox
0 siblings, 2 replies; 4+ messages in thread
From: Jayson R. King @ 2011-02-09 3:20 UTC (permalink / raw)
To: LKML, Stable team
drivers/char/hvc_console.c: In function 'hvc_open':
drivers/char/hvc_console.c:315: error: implicit declaration of function
'tty_kref_get'
drivers/char/hvc_console.c:324: warning: assignment makes pointer from
integer without a cast
drivers/char/hvc_console.c:341: error: implicit declaration of function
'tty_kref_put'
drivers/char/hvc_console.c: In function 'hvc_poll':
drivers/char/hvc_console.c:558: warning: assignment makes pointer from
integer without a cast
drivers/char/hvc_console.c: In function 'hvc_remove':
drivers/char/hvc_console.c:759: warning: assignment makes pointer from
integer without a cast
I don't see a tty_kref_get or tty_kref_put on 2.6.27. Those functions
first appeared in 2.6.28.
Jayson
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [stable] 2.6.27.58-rc1 build error Re: [PATCH 21/23] hvc_console: Fix race between hvc_close and hvc_remove
2011-02-09 3:20 2.6.27.58-rc1 build error Re: [PATCH 21/23] hvc_console: Fix race between hvc_close and hvc_remove Jayson R. King
@ 2011-02-09 5:52 ` Willy Tarreau
2011-02-09 9:44 ` Alan Cox
1 sibling, 0 replies; 4+ messages in thread
From: Willy Tarreau @ 2011-02-09 5:52 UTC (permalink / raw)
To: Jayson R. King; +Cc: LKML, Stable team
On Tue, Feb 08, 2011 at 09:20:42PM -0600, Jayson R. King wrote:
> drivers/char/hvc_console.c: In function 'hvc_open':
> drivers/char/hvc_console.c:315: error: implicit declaration of function
> 'tty_kref_get'
> drivers/char/hvc_console.c:324: warning: assignment makes pointer from
> integer without a cast
> drivers/char/hvc_console.c:341: error: implicit declaration of function
> 'tty_kref_put'
> drivers/char/hvc_console.c: In function 'hvc_poll':
> drivers/char/hvc_console.c:558: warning: assignment makes pointer from
> integer without a cast
> drivers/char/hvc_console.c: In function 'hvc_remove':
> drivers/char/hvc_console.c:759: warning: assignment makes pointer from
> integer without a cast
>
> I don't see a tty_kref_get or tty_kref_put on 2.6.27. Those functions
> first appeared in 2.6.28.
Oh indeed, and the ->kref struct member did not even exist in 2.6.27.
Let's drop the patch then, we don't want to add the kref everywhere,
it would have to be ported to other users.
Thanks!
Willy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.6.27.58-rc1 build error Re: [PATCH 21/23] hvc_console: Fix race between hvc_close and hvc_remove
2011-02-09 3:20 2.6.27.58-rc1 build error Re: [PATCH 21/23] hvc_console: Fix race between hvc_close and hvc_remove Jayson R. King
2011-02-09 5:52 ` [stable] " Willy Tarreau
@ 2011-02-09 9:44 ` Alan Cox
2011-02-09 10:34 ` [stable] " Willy Tarreau
1 sibling, 1 reply; 4+ messages in thread
From: Alan Cox @ 2011-02-09 9:44 UTC (permalink / raw)
To: Jayson R. King; +Cc: LKML, Stable team
On Tue, 08 Feb 2011 21:20:42 -0600
"Jayson R. King" <dev@jaysonking.com> wrote:
> drivers/char/hvc_console.c: In function 'hvc_open':
> drivers/char/hvc_console.c:315: error: implicit declaration of function
> 'tty_kref_get'
> drivers/char/hvc_console.c:324: warning: assignment makes pointer from
> integer without a cast
> drivers/char/hvc_console.c:341: error: implicit declaration of function
> 'tty_kref_put'
> drivers/char/hvc_console.c: In function 'hvc_poll':
> drivers/char/hvc_console.c:558: warning: assignment makes pointer from
> integer without a cast
> drivers/char/hvc_console.c: In function 'hvc_remove':
> drivers/char/hvc_console.c:759: warning: assignment makes pointer from
> integer without a cast
>
> I don't see a tty_kref_get or tty_kref_put on 2.6.27. Those functions
> first appeared in 2.6.28.
Correct - for 2.6.27 I don't think you *can* make the tty layer
non-exploitable without a major backport
Alan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [stable] 2.6.27.58-rc1 build error Re: [PATCH 21/23] hvc_console: Fix race between hvc_close and hvc_remove
2011-02-09 9:44 ` Alan Cox
@ 2011-02-09 10:34 ` Willy Tarreau
0 siblings, 0 replies; 4+ messages in thread
From: Willy Tarreau @ 2011-02-09 10:34 UTC (permalink / raw)
To: Alan Cox; +Cc: Jayson R. King, LKML, Stable team
On Wed, Feb 09, 2011 at 09:44:34AM +0000, Alan Cox wrote:
> On Tue, 08 Feb 2011 21:20:42 -0600
> "Jayson R. King" <dev@jaysonking.com> wrote:
>
> > drivers/char/hvc_console.c: In function 'hvc_open':
> > drivers/char/hvc_console.c:315: error: implicit declaration of function
> > 'tty_kref_get'
> > drivers/char/hvc_console.c:324: warning: assignment makes pointer from
> > integer without a cast
> > drivers/char/hvc_console.c:341: error: implicit declaration of function
> > 'tty_kref_put'
> > drivers/char/hvc_console.c: In function 'hvc_poll':
> > drivers/char/hvc_console.c:558: warning: assignment makes pointer from
> > integer without a cast
> > drivers/char/hvc_console.c: In function 'hvc_remove':
> > drivers/char/hvc_console.c:759: warning: assignment makes pointer from
> > integer without a cast
> >
> > I don't see a tty_kref_get or tty_kref_put on 2.6.27. Those functions
> > first appeared in 2.6.28.
>
> Correct - for 2.6.27 I don't think you *can* make the tty layer
> non-exploitable without a major backport
So unless the bug is critical (I don't think it is), I'd rather avoid
a major backport at this stage.
Willy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-09 10:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-09 3:20 2.6.27.58-rc1 build error Re: [PATCH 21/23] hvc_console: Fix race between hvc_close and hvc_remove Jayson R. King
2011-02-09 5:52 ` [stable] " Willy Tarreau
2011-02-09 9:44 ` Alan Cox
2011-02-09 10:34 ` [stable] " Willy Tarreau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.