From: Mark Hatle <mark.hatle@windriver.com>
To: Gary Thomas <gary@mlbassoc.com>
Cc: "yocto@yoctoproject.org" <yocto@yoctoproject.org>
Subject: Re: Master build error caused a small typo by commit today : fetch2: unpack revision
Date: Sat, 12 Feb 2011 16:38:26 -0600 [thread overview]
Message-ID: <4D570BE2.4020900@windriver.com> (raw)
In-Reply-To: <4D56DCB5.2070205@mlbassoc.com>
On 2/12/11 1:17 PM, Gary Thomas wrote:
> On 02/12/2011 12:08 PM, Koen Kooi wrote:
>>
>> Op 12 feb 2011, om 19:09 heeft Mark Hatle het volgende geschreven:
>>
>>> On 2/12/11 3:30 AM, Cui, Dexuan wrote:
>>>> Hi Mark,
>>>> As Liping said, the following change breaks building xorg-minimal-fonts as destdir is not correct.
>>>> Can you please explain the actual different between cp and tar here? I think "cp -p" is similar to "tar -x -p" here?
>>>>
>>>
>>> We can revert the change. But the reason for it is tar preserves hard links,
>>> while cp does not.
>>
>> The problem is that people can hit things like this:
>>
>> | NOTE: Unpacking /OE/tentacle/sources/angstrom-layers/BSP/TI/recipes-bsp/linux/linux-omap-psp-2.6.32/beagleboard/defconfig to /OE/tentacle/build/tmp-angstrom_2010_x/work/beagleboard-angstrom-linux-gnueabi/linux-omap-psp-2.6.32-r99+gitr5fc29e7b2a76a64a739f857858ef0b98294aa155/
>> | ERROR: Error executing a python function in /OE/tentacle/sources/angstrom-layers/BSP/TI/recipes-bsp/linux/linux-omap-psp_2.6.32.bb:
>> | TypeError: %d format: a number is required, not str
>> |
>> | ERROR: The stack trace of python calls that resulted in this exception/failure was:
>> | ERROR: File "base_do_unpack", line 19, in<module>
>> | ERROR:
>> | ERROR: File "base_do_unpack", line 14, in base_do_unpack
>> | ERROR:
>> | ERROR: File "/OE/tentacle/sources/bitbake/lib/bb/fetch2/__init__.py", line 1015, in unpack
>> | ERROR: ud.method.unpack(ud, root, self.d)
>> | ERROR:
>> | ERROR: File "/OE/tentacle/sources/bitbake/lib/bb/fetch2/__init__.py", line 724, in unpack
>> | ERROR: cmd = 'tar -cf - -C "%d" -ps . | tar -xf - -C "%s/%s/"' % (file, rootdir, destdir)
>
> Does not changing this "%d" to "%s" work?
Yes, this is the correct fix. Nobody has been around today to push the fix into
the tree however.
It was a simple typo.
--Mark
>> | ERROR:
>> | ERROR: The code that was being executed was:
>> | ERROR: 0015: except bb.fetch2.BBFetchException, e:
>> | ERROR: 0016: raise bb.build.FuncFailed(e)
>> | ERROR: 0017:
>> | ERROR: 0018:
>> | ERROR: *** 0019:base_do_unpack(d)
>> | ERROR: 0020:
>> | ERROR: (file: 'base_do_unpack', lineno: 19, function:<module>)
>> | ERROR: 0010: rootdir = bb.data.getVar('WORKDIR', localdata, True)
>> | ERROR: 0011:
>> | ERROR: 0012: try:
>> | ERROR: 0013: fetcher = bb.fetch2.Fetch(src_uri, localdata)
>> | ERROR: *** 0014: fetcher.unpack(rootdir)
>> | ERROR: 0015: except bb.fetch2.BBFetchException, e:
>> | ERROR: 0016: raise bb.build.FuncFailed(e)
>> | ERROR: 0017:
>> | ERROR: 0018:
>> | ERROR: (file: 'base_do_unpack', lineno: 14, function: base_do_unpack)
>> | ERROR: Function 'base_do_unpack' failed
>>
>> Not sure what triggers it, but it breaks my build. It could be entirely my own fault for having buggy recipes in a BSP :)
>>
>> regards,
>>
>> Koen
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>
next prev parent reply other threads:[~2011-02-12 22:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 5:05 Master build error caused a small typo by commit today : fetch2: unpack revision Ke, Liping
2011-02-12 7:53 ` Ke, Liping
2011-02-12 9:30 ` Cui, Dexuan
2011-02-12 18:09 ` Mark Hatle
2011-02-12 19:08 ` Koen Kooi
2011-02-12 19:17 ` Gary Thomas
2011-02-12 22:38 ` Mark Hatle [this message]
2011-02-13 1:02 ` Scott Garman
2011-02-13 7:12 ` Ke, Liping
2011-02-13 19:27 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D570BE2.4020900@windriver.com \
--to=mark.hatle@windriver.com \
--cc=gary@mlbassoc.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.