All of lore.kernel.org
 help / color / mirror / Atom feed
* Master build error caused a small typo by commit today : fetch2: unpack revision
@ 2011-02-12  5:05 Ke, Liping
  2011-02-12  7:53 ` Ke, Liping
  0 siblings, 1 reply; 10+ messages in thread
From: Ke, Liping @ 2011-02-12  5:05 UTC (permalink / raw)
  To: richard.purdie@linuxfoundation.org, mark.hatle@windriver.com
  Cc: yocto@yoctoproject.org

Hi, all

Just found a small typo which caused built error today. The "%d" (file) should be changed to "%s", otherwise, compile error.

Anybody could help to modify the small bug if you're happening sending patches.

Thanks a lot for your help!
criping





author	Mark Hatle <mark.hatle@windriver.com>	2011-02-11 17:43:54 (GMT)
committer	 Richard Purdie <richard.purdie@linuxfoundation.org>	2011-02-12 00:30:29 (GMT)
commit	3faa635fd408695dd5b754fda3f6060dd670b81d (patch) (side-by-side diff)
tree	d0ba5d2d4acca9f7748029116f3a74877ee899c9
parent	e56f63a2843e5a7d70fd60e0aaed4d962a277da7 (diff)
download	poky-3faa635fd408695dd5b754fda3f6060dd670b81d.zip
poky-3faa635fd408695dd5b754fda3f6060dd670b81d.tar.gz
poky-3faa635fd408695dd5b754fda3f6060dd670b81d.tar.bz2



@@ -706,17 +720,17 @@ class FetchMethod(object):
                             destdir = "."
                         elif not os.access("%s/%s" % (rootdir, destdir), os.F_OK):
                             os.makedirs("%s/%s" % (rootdir, destdir))
-                    cmd = 'cp -pPR %s %s/%s/' % (file, rootdir, destdir)
+                    #cmd = 'cp -pPR %s %s/%s/' % (file, rootdir, destdir)
+                    cmd = 'tar -cf - -C "%d" -ps . | tar -xf - -C "%s/%s/"' % (file, rootdir, destdir)






^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Master build error caused a small typo by commit today : fetch2: unpack revision
  2011-02-12  5:05 Master build error caused a small typo by commit today : fetch2: unpack revision Ke, Liping
@ 2011-02-12  7:53 ` Ke, Liping
  2011-02-12  9:30   ` Cui, Dexuan
  0 siblings, 1 reply; 10+ messages in thread
From: Ke, Liping @ 2011-02-12  7:53 UTC (permalink / raw)
  To: Ke, Liping, richard.purdie@linuxfoundation.org,
	mark.hatle@windriver.com
  Cc: yocto@yoctoproject.org

Hi, Mark

After fixing this typo, I found another error when bitbake xorg-minimal-fonts,
It will report
ERROR: Function 'org-minial-fonts: LIC_FILES_CHKSUM points to invalid file: ../misc/fonts/alias' failed

I checked the folder of build/tmp/work/all-poky-linux/xorg-minimal-fonts-1_1.0-r0, fonts.alias fonts.dir
Cursor.pcf.gz we not under misc subfolder as its expectation, but on the outer folder, 
seems the SRC_URI="file://misc" defined in the Xorg-minimal-fonts.bb does not work.

Thanks a lot!
criping


> -----Original Message-----
> From: yocto-bounces@yoctoproject.org [mailto:yocto-
> bounces@yoctoproject.org] On Behalf Of Ke, Liping
> Sent: Saturday, February 12, 2011 1:06 PM
> To: richard.purdie@linuxfoundation.org; mark.hatle@windriver.com
> Cc: yocto@yoctoproject.org
> Subject: [yocto] Master build error caused a small typo by commit
> today : fetch2: unpack revision
> 
> Hi, all
> 
> Just found a small typo which caused built error today. The "%d" (file)
> should be changed to "%s", otherwise, compile error.
> 
> Anybody could help to modify the small bug if you're happening sending
> patches.
> 
> Thanks a lot for your help!
> criping
> 
> 
> 
> 
> 
> author	Mark Hatle <mark.hatle@windriver.com>	2011-02-11
> 17:43:54 (GMT)
> committer	 Richard Purdie <richard.purdie@linuxfoundation.org>	2011-
> 02-12 00:30:29 (GMT)
> commit	3faa635fd408695dd5b754fda3f6060dd670b81d (patch) (side-by-
> side diff)
> tree	d0ba5d2d4acca9f7748029116f3a74877ee899c9
> parent	e56f63a2843e5a7d70fd60e0aaed4d962a277da7 (diff)
> download	poky-3faa635fd408695dd5b754fda3f6060dd670b81d.zip
> poky-3faa635fd408695dd5b754fda3f6060dd670b81d.tar.gz
> poky-3faa635fd408695dd5b754fda3f6060dd670b81d.tar.bz2
> 
> 
> 
> @@ -706,17 +720,17 @@ class FetchMethod(object):
>                              destdir = "."
>                          elif not os.access("%s/%s" % (rootdir,
> destdir), os.F_OK):
>                              os.makedirs("%s/%s" % (rootdir, destdir))
> -                    cmd = 'cp -pPR %s %s/%s/' % (file, rootdir,
> destdir)
> +                    #cmd = 'cp -pPR %s %s/%s/' % (file, rootdir,
> destdir)
> +                    cmd = 'tar -cf - -C "%d" -ps . | tar -xf - -C
> "%s/%s/"' % (file, rootdir, destdir)
> 
> 
> 
> 
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Master build error caused a small typo by commit today : fetch2: unpack revision
  2011-02-12  7:53 ` Ke, Liping
@ 2011-02-12  9:30   ` Cui, Dexuan
  2011-02-12 18:09     ` Mark Hatle
  0 siblings, 1 reply; 10+ messages in thread
From: Cui, Dexuan @ 2011-02-12  9:30 UTC (permalink / raw)
  To: Ke, Liping, Ke, Liping, richard.purdie@linuxfoundation.org,
	mark.hatle@windriver.com
  Cc: yocto@yoctoproject.org

Hi Mark,
As Liping said, the following change breaks building xorg-minimal-fonts as destdir is not correct.
Can you please explain the actual different between cp and tar here? I think "cp -p" is similar to "tar -x -p" here?

@@ -706,17 +720,17 @@ class FetchMethod(object):
                             destdir = "."
                         elif not os.access("%s/%s" % (rootdir, destdir), os.F_OK):
                             os.makedirs("%s/%s" % (rootdir, destdir))
-                    cmd = 'cp -pPR %s %s/%s/' % (file, rootdir, destdir)
+                    #cmd = 'cp -pPR %s %s/%s/' % (file, rootdir, destdir)
+                    cmd = 'tar -cf - -C "%d" -ps . | tar -xf - -C "%s/%s/"' % (file, rootdir, destdir)


Thanks,
-- Dexuan

-----Original Message-----
From: yocto-bounces@yoctoproject.org [mailto:yocto-bounces@yoctoproject.org] On Behalf Of Ke, Liping
Sent: 2011年2月12日 15:53
To: Ke, Liping; richard.purdie@linuxfoundation.org; mark.hatle@windriver.com
Cc: yocto@yoctoproject.org
Subject: Re: [yocto] Master build error caused a small typo by commit today : fetch2: unpack revision

Hi, Mark

After fixing this typo, I found another error when bitbake xorg-minimal-fonts,
It will report
ERROR: Function 'org-minial-fonts: LIC_FILES_CHKSUM points to invalid file: ../misc/fonts/alias' failed

I checked the folder of build/tmp/work/all-poky-linux/xorg-minimal-fonts-1_1.0-r0, fonts.alias fonts.dir
Cursor.pcf.gz we not under misc subfolder as its expectation, but on the outer folder, 
seems the SRC_URI="file://misc" defined in the Xorg-minimal-fonts.bb does not work.

Thanks a lot!
criping


> -----Original Message-----
> From: yocto-bounces@yoctoproject.org [mailto:yocto-
> bounces@yoctoproject.org] On Behalf Of Ke, Liping
> Sent: Saturday, February 12, 2011 1:06 PM
> To: richard.purdie@linuxfoundation.org; mark.hatle@windriver.com
> Cc: yocto@yoctoproject.org
> Subject: [yocto] Master build error caused a small typo by commit
> today : fetch2: unpack revision
> 
> Hi, all
> 
> Just found a small typo which caused built error today. The "%d" (file)
> should be changed to "%s", otherwise, compile error.
> 
> Anybody could help to modify the small bug if you're happening sending
> patches.
> 
> Thanks a lot for your help!
> criping
> 
> 
> 
> 
> 
> author	Mark Hatle <mark.hatle@windriver.com>	2011-02-11
> 17:43:54 (GMT)
> committer	 Richard Purdie <richard.purdie@linuxfoundation.org>	2011-
> 02-12 00:30:29 (GMT)
> commit	3faa635fd408695dd5b754fda3f6060dd670b81d (patch) (side-by-
> side diff)
> tree	d0ba5d2d4acca9f7748029116f3a74877ee899c9
> parent	e56f63a2843e5a7d70fd60e0aaed4d962a277da7 (diff)
> download	poky-3faa635fd408695dd5b754fda3f6060dd670b81d.zip
> poky-3faa635fd408695dd5b754fda3f6060dd670b81d.tar.gz
> poky-3faa635fd408695dd5b754fda3f6060dd670b81d.tar.bz2
> 
> 
> 
> @@ -706,17 +720,17 @@ class FetchMethod(object):
>                              destdir = "."
>                          elif not os.access("%s/%s" % (rootdir,
> destdir), os.F_OK):
>                              os.makedirs("%s/%s" % (rootdir, destdir))
> -                    cmd = 'cp -pPR %s %s/%s/' % (file, rootdir,
> destdir)
> +                    #cmd = 'cp -pPR %s %s/%s/' % (file, rootdir,
> destdir)
> +                    cmd = 'tar -cf - -C "%d" -ps . | tar -xf - -C
> "%s/%s/"' % (file, rootdir, destdir)
> 
> 
> 
> 
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Master build error caused a small typo by commit today : fetch2: unpack revision
  2011-02-12  9:30   ` Cui, Dexuan
@ 2011-02-12 18:09     ` Mark Hatle
  2011-02-12 19:08       ` Koen Kooi
  0 siblings, 1 reply; 10+ messages in thread
From: Mark Hatle @ 2011-02-12 18:09 UTC (permalink / raw)
  To: Cui, Dexuan; +Cc: yocto@yoctoproject.org

On 2/12/11 3:30 AM, Cui, Dexuan wrote:
> Hi Mark,
> As Liping said, the following change breaks building xorg-minimal-fonts as destdir is not correct.
> Can you please explain the actual different between cp and tar here? I think "cp -p" is similar to "tar -x -p" here?
> 

We can revert the change.  But the reason for it is tar preserves hard links,
while cp does not.

So if a directory being copied contain foo, foo1, foo2, and foo3  all hardlinks
of each other, they will end up still being hard links of each other on the
target side.

I previously went through the classes and updated almost all cases of CP to the
tar method.  (Obviously without the %d typo...)  This reduced over 200MB from
the eglibc build.. (mostly in locale info)

--Mark

> @@ -706,17 +720,17 @@ class FetchMethod(object):
>                              destdir = "."
>                          elif not os.access("%s/%s" % (rootdir, destdir), os.F_OK):
>                              os.makedirs("%s/%s" % (rootdir, destdir))
> -                    cmd = 'cp -pPR %s %s/%s/' % (file, rootdir, destdir)
> +                    #cmd = 'cp -pPR %s %s/%s/' % (file, rootdir, destdir)
> +                    cmd = 'tar -cf - -C "%d" -ps . | tar -xf - -C "%s/%s/"' % (file, rootdir, destdir)
> 
> 
> Thanks,
> -- Dexuan
> 
> -----Original Message-----
> From: yocto-bounces@yoctoproject.org [mailto:yocto-bounces@yoctoproject.org] On Behalf Of Ke, Liping
> Sent: 2011年2月12日 15:53
> To: Ke, Liping; richard.purdie@linuxfoundation.org; mark.hatle@windriver.com
> Cc: yocto@yoctoproject.org
> Subject: Re: [yocto] Master build error caused a small typo by commit today : fetch2: unpack revision
> 
> Hi, Mark
> 
> After fixing this typo, I found another error when bitbake xorg-minimal-fonts,
> It will report
> ERROR: Function 'org-minial-fonts: LIC_FILES_CHKSUM points to invalid file: ../misc/fonts/alias' failed
> 
> I checked the folder of build/tmp/work/all-poky-linux/xorg-minimal-fonts-1_1.0-r0, fonts.alias fonts.dir
> Cursor.pcf.gz we not under misc subfolder as its expectation, but on the outer folder, 
> seems the SRC_URI="file://misc" defined in the Xorg-minimal-fonts.bb does not work.
> 
> Thanks a lot!
> criping
> 
> 
>> -----Original Message-----
>> From: yocto-bounces@yoctoproject.org [mailto:yocto-
>> bounces@yoctoproject.org] On Behalf Of Ke, Liping
>> Sent: Saturday, February 12, 2011 1:06 PM
>> To: richard.purdie@linuxfoundation.org; mark.hatle@windriver.com
>> Cc: yocto@yoctoproject.org
>> Subject: [yocto] Master build error caused a small typo by commit
>> today : fetch2: unpack revision
>>
>> Hi, all
>>
>> Just found a small typo which caused built error today. The "%d" (file)
>> should be changed to "%s", otherwise, compile error.
>>
>> Anybody could help to modify the small bug if you're happening sending
>> patches.
>>
>> Thanks a lot for your help!
>> criping
>>
>>
>>
>>
>>
>> author	Mark Hatle <mark.hatle@windriver.com>	2011-02-11
>> 17:43:54 (GMT)
>> committer	 Richard Purdie <richard.purdie@linuxfoundation.org>	2011-
>> 02-12 00:30:29 (GMT)
>> commit	3faa635fd408695dd5b754fda3f6060dd670b81d (patch) (side-by-
>> side diff)
>> tree	d0ba5d2d4acca9f7748029116f3a74877ee899c9
>> parent	e56f63a2843e5a7d70fd60e0aaed4d962a277da7 (diff)
>> download	poky-3faa635fd408695dd5b754fda3f6060dd670b81d.zip
>> poky-3faa635fd408695dd5b754fda3f6060dd670b81d.tar.gz
>> poky-3faa635fd408695dd5b754fda3f6060dd670b81d.tar.bz2
>>
>>
>>
>> @@ -706,17 +720,17 @@ class FetchMethod(object):
>>                              destdir = "."
>>                          elif not os.access("%s/%s" % (rootdir,
>> destdir), os.F_OK):
>>                              os.makedirs("%s/%s" % (rootdir, destdir))
>> -                    cmd = 'cp -pPR %s %s/%s/' % (file, rootdir,
>> destdir)
>> +                    #cmd = 'cp -pPR %s %s/%s/' % (file, rootdir,
>> destdir)
>> +                    cmd = 'tar -cf - -C "%d" -ps . | tar -xf - -C
>> "%s/%s/"' % (file, rootdir, destdir)
>>
>>
>>
>>
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Master build error caused a small typo by commit today : fetch2: unpack revision
  2011-02-12 18:09     ` Mark Hatle
@ 2011-02-12 19:08       ` Koen Kooi
  2011-02-12 19:17         ` Gary Thomas
  0 siblings, 1 reply; 10+ messages in thread
From: Koen Kooi @ 2011-02-12 19:08 UTC (permalink / raw)
  To: Mark Hatle; +Cc: yocto@yoctoproject.org


Op 12 feb 2011, om 19:09 heeft Mark Hatle het volgende geschreven:

> On 2/12/11 3:30 AM, Cui, Dexuan wrote:
>> Hi Mark,
>> As Liping said, the following change breaks building xorg-minimal-fonts as destdir is not correct.
>> Can you please explain the actual different between cp and tar here? I think "cp -p" is similar to "tar -x -p" here?
>> 
> 
> We can revert the change.  But the reason for it is tar preserves hard links,
> while cp does not.

The problem is that people can hit things like this:

| NOTE: Unpacking /OE/tentacle/sources/angstrom-layers/BSP/TI/recipes-bsp/linux/linux-omap-psp-2.6.32/beagleboard/defconfig to /OE/tentacle/build/tmp-angstrom_2010_x/work/beagleboard-angstrom-linux-gnueabi/linux-omap-psp-2.6.32-r99+gitr5fc29e7b2a76a64a739f857858ef0b98294aa155/
| ERROR: Error executing a python function in /OE/tentacle/sources/angstrom-layers/BSP/TI/recipes-bsp/linux/linux-omap-psp_2.6.32.bb:
| TypeError: %d format: a number is required, not str
|
| ERROR: The stack trace of python calls that resulted in this exception/failure was:
| ERROR:   File "base_do_unpack", line 19, in <module>
| ERROR:
| ERROR:   File "base_do_unpack", line 14, in base_do_unpack
| ERROR:
| ERROR:   File "/OE/tentacle/sources/bitbake/lib/bb/fetch2/__init__.py", line 1015, in unpack
| ERROR:     ud.method.unpack(ud, root, self.d)
| ERROR:
| ERROR:   File "/OE/tentacle/sources/bitbake/lib/bb/fetch2/__init__.py", line 724, in unpack
| ERROR:     cmd = 'tar -cf - -C "%d" -ps . | tar -xf - -C "%s/%s/"' % (file, rootdir, destdir)
| ERROR:
| ERROR: The code that was being executed was:
| ERROR:      0015:        except bb.fetch2.BBFetchException, e:
| ERROR:      0016:            raise bb.build.FuncFailed(e)
| ERROR:      0017:
| ERROR:      0018:
| ERROR:  *** 0019:base_do_unpack(d)
| ERROR:      0020:
| ERROR: (file: 'base_do_unpack', lineno: 19, function: <module>)
| ERROR:      0010:     rootdir = bb.data.getVar('WORKDIR', localdata, True)
| ERROR:      0011:
| ERROR:      0012:        try:
| ERROR:      0013:            fetcher = bb.fetch2.Fetch(src_uri, localdata)
| ERROR:  *** 0014:            fetcher.unpack(rootdir)
| ERROR:      0015:        except bb.fetch2.BBFetchException, e:
| ERROR:      0016:            raise bb.build.FuncFailed(e)
| ERROR:      0017:
| ERROR:      0018:
| ERROR: (file: 'base_do_unpack', lineno: 14, function: base_do_unpack)
| ERROR: Function 'base_do_unpack' failed

Not sure what triggers it, but it breaks my build. It could be entirely my own fault for having buggy recipes in a BSP :)

regards,

Koen

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Master build error caused a small typo by commit today : fetch2: unpack revision
  2011-02-12 19:08       ` Koen Kooi
@ 2011-02-12 19:17         ` Gary Thomas
  2011-02-12 22:38           ` Mark Hatle
  0 siblings, 1 reply; 10+ messages in thread
From: Gary Thomas @ 2011-02-12 19:17 UTC (permalink / raw)
  To: Koen Kooi; +Cc: yocto@yoctoproject.org

On 02/12/2011 12:08 PM, Koen Kooi wrote:
>
> Op 12 feb 2011, om 19:09 heeft Mark Hatle het volgende geschreven:
>
>> On 2/12/11 3:30 AM, Cui, Dexuan wrote:
>>> Hi Mark,
>>> As Liping said, the following change breaks building xorg-minimal-fonts as destdir is not correct.
>>> Can you please explain the actual different between cp and tar here? I think "cp -p" is similar to "tar -x -p" here?
>>>
>>
>> We can revert the change.  But the reason for it is tar preserves hard links,
>> while cp does not.
>
> The problem is that people can hit things like this:
>
> | NOTE: Unpacking /OE/tentacle/sources/angstrom-layers/BSP/TI/recipes-bsp/linux/linux-omap-psp-2.6.32/beagleboard/defconfig to /OE/tentacle/build/tmp-angstrom_2010_x/work/beagleboard-angstrom-linux-gnueabi/linux-omap-psp-2.6.32-r99+gitr5fc29e7b2a76a64a739f857858ef0b98294aa155/
> | ERROR: Error executing a python function in /OE/tentacle/sources/angstrom-layers/BSP/TI/recipes-bsp/linux/linux-omap-psp_2.6.32.bb:
> | TypeError: %d format: a number is required, not str
> |
> | ERROR: The stack trace of python calls that resulted in this exception/failure was:
> | ERROR:   File "base_do_unpack", line 19, in<module>
> | ERROR:
> | ERROR:   File "base_do_unpack", line 14, in base_do_unpack
> | ERROR:
> | ERROR:   File "/OE/tentacle/sources/bitbake/lib/bb/fetch2/__init__.py", line 1015, in unpack
> | ERROR:     ud.method.unpack(ud, root, self.d)
> | ERROR:
> | ERROR:   File "/OE/tentacle/sources/bitbake/lib/bb/fetch2/__init__.py", line 724, in unpack
> | ERROR:     cmd = 'tar -cf - -C "%d" -ps . | tar -xf - -C "%s/%s/"' % (file, rootdir, destdir)

Does not changing this "%d" to "%s" work?

> | ERROR:
> | ERROR: The code that was being executed was:
> | ERROR:      0015:        except bb.fetch2.BBFetchException, e:
> | ERROR:      0016:            raise bb.build.FuncFailed(e)
> | ERROR:      0017:
> | ERROR:      0018:
> | ERROR:  *** 0019:base_do_unpack(d)
> | ERROR:      0020:
> | ERROR: (file: 'base_do_unpack', lineno: 19, function:<module>)
> | ERROR:      0010:     rootdir = bb.data.getVar('WORKDIR', localdata, True)
> | ERROR:      0011:
> | ERROR:      0012:        try:
> | ERROR:      0013:            fetcher = bb.fetch2.Fetch(src_uri, localdata)
> | ERROR:  *** 0014:            fetcher.unpack(rootdir)
> | ERROR:      0015:        except bb.fetch2.BBFetchException, e:
> | ERROR:      0016:            raise bb.build.FuncFailed(e)
> | ERROR:      0017:
> | ERROR:      0018:
> | ERROR: (file: 'base_do_unpack', lineno: 14, function: base_do_unpack)
> | ERROR: Function 'base_do_unpack' failed
>
> Not sure what triggers it, but it breaks my build. It could be entirely my own fault for having buggy recipes in a BSP :)
>
> regards,
>
> Koen
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Master build error caused a small typo by commit today : fetch2: unpack revision
  2011-02-12 19:17         ` Gary Thomas
@ 2011-02-12 22:38           ` Mark Hatle
  2011-02-13  1:02             ` Scott Garman
  0 siblings, 1 reply; 10+ messages in thread
From: Mark Hatle @ 2011-02-12 22:38 UTC (permalink / raw)
  To: Gary Thomas; +Cc: yocto@yoctoproject.org

On 2/12/11 1:17 PM, Gary Thomas wrote:
> On 02/12/2011 12:08 PM, Koen Kooi wrote:
>>
>> Op 12 feb 2011, om 19:09 heeft Mark Hatle het volgende geschreven:
>>
>>> On 2/12/11 3:30 AM, Cui, Dexuan wrote:
>>>> Hi Mark,
>>>> As Liping said, the following change breaks building xorg-minimal-fonts as destdir is not correct.
>>>> Can you please explain the actual different between cp and tar here? I think "cp -p" is similar to "tar -x -p" here?
>>>>
>>>
>>> We can revert the change.  But the reason for it is tar preserves hard links,
>>> while cp does not.
>>
>> The problem is that people can hit things like this:
>>
>> | NOTE: Unpacking /OE/tentacle/sources/angstrom-layers/BSP/TI/recipes-bsp/linux/linux-omap-psp-2.6.32/beagleboard/defconfig to /OE/tentacle/build/tmp-angstrom_2010_x/work/beagleboard-angstrom-linux-gnueabi/linux-omap-psp-2.6.32-r99+gitr5fc29e7b2a76a64a739f857858ef0b98294aa155/
>> | ERROR: Error executing a python function in /OE/tentacle/sources/angstrom-layers/BSP/TI/recipes-bsp/linux/linux-omap-psp_2.6.32.bb:
>> | TypeError: %d format: a number is required, not str
>> |
>> | ERROR: The stack trace of python calls that resulted in this exception/failure was:
>> | ERROR:   File "base_do_unpack", line 19, in<module>
>> | ERROR:
>> | ERROR:   File "base_do_unpack", line 14, in base_do_unpack
>> | ERROR:
>> | ERROR:   File "/OE/tentacle/sources/bitbake/lib/bb/fetch2/__init__.py", line 1015, in unpack
>> | ERROR:     ud.method.unpack(ud, root, self.d)
>> | ERROR:
>> | ERROR:   File "/OE/tentacle/sources/bitbake/lib/bb/fetch2/__init__.py", line 724, in unpack
>> | ERROR:     cmd = 'tar -cf - -C "%d" -ps . | tar -xf - -C "%s/%s/"' % (file, rootdir, destdir)
> 
> Does not changing this "%d" to "%s" work?

Yes, this is the correct fix.  Nobody has been around today to push the fix into
the tree however.

It was a simple typo.

--Mark

>> | ERROR:
>> | ERROR: The code that was being executed was:
>> | ERROR:      0015:        except bb.fetch2.BBFetchException, e:
>> | ERROR:      0016:            raise bb.build.FuncFailed(e)
>> | ERROR:      0017:
>> | ERROR:      0018:
>> | ERROR:  *** 0019:base_do_unpack(d)
>> | ERROR:      0020:
>> | ERROR: (file: 'base_do_unpack', lineno: 19, function:<module>)
>> | ERROR:      0010:     rootdir = bb.data.getVar('WORKDIR', localdata, True)
>> | ERROR:      0011:
>> | ERROR:      0012:        try:
>> | ERROR:      0013:            fetcher = bb.fetch2.Fetch(src_uri, localdata)
>> | ERROR:  *** 0014:            fetcher.unpack(rootdir)
>> | ERROR:      0015:        except bb.fetch2.BBFetchException, e:
>> | ERROR:      0016:            raise bb.build.FuncFailed(e)
>> | ERROR:      0017:
>> | ERROR:      0018:
>> | ERROR: (file: 'base_do_unpack', lineno: 14, function: base_do_unpack)
>> | ERROR: Function 'base_do_unpack' failed
>>
>> Not sure what triggers it, but it breaks my build. It could be entirely my own fault for having buggy recipes in a BSP :)
>>
>> regards,
>>
>> Koen
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
> 



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Master build error caused a small typo by commit today : fetch2: unpack revision
  2011-02-12 22:38           ` Mark Hatle
@ 2011-02-13  1:02             ` Scott Garman
  2011-02-13  7:12               ` Ke, Liping
  0 siblings, 1 reply; 10+ messages in thread
From: Scott Garman @ 2011-02-13  1:02 UTC (permalink / raw)
  To: yocto

On 02/12/2011 02:38 PM, Mark Hatle wrote:
> On 2/12/11 1:17 PM, Gary Thomas wrote:
>> On 02/12/2011 12:08 PM, Koen Kooi wrote:
>>>
>>> Op 12 feb 2011, om 19:09 heeft Mark Hatle het volgende geschreven:
>>>
>>>> On 2/12/11 3:30 AM, Cui, Dexuan wrote:
>>>>> Hi Mark,
>>>>> As Liping said, the following change breaks building xorg-minimal-fonts as destdir is not correct.
>>>>> Can you please explain the actual different between cp and tar here? I think "cp -p" is similar to "tar -x -p" here?
>>>>>
>>>>
>>>> We can revert the change.  But the reason for it is tar preserves hard links,
>>>> while cp does not.
>>>
>>> The problem is that people can hit things like this:
>>>
>>> | NOTE: Unpacking /OE/tentacle/sources/angstrom-layers/BSP/TI/recipes-bsp/linux/linux-omap-psp-2.6.32/beagleboard/defconfig to /OE/tentacle/build/tmp-angstrom_2010_x/work/beagleboard-angstrom-linux-gnueabi/linux-omap-psp-2.6.32-r99+gitr5fc29e7b2a76a64a739f857858ef0b98294aa155/
>>> | ERROR: Error executing a python function in /OE/tentacle/sources/angstrom-layers/BSP/TI/recipes-bsp/linux/linux-omap-psp_2.6.32.bb:
>>> | TypeError: %d format: a number is required, not str
>>> |
>>> | ERROR: The stack trace of python calls that resulted in this exception/failure was:
>>> | ERROR:   File "base_do_unpack", line 19, in<module>
>>> | ERROR:
>>> | ERROR:   File "base_do_unpack", line 14, in base_do_unpack
>>> | ERROR:
>>> | ERROR:   File "/OE/tentacle/sources/bitbake/lib/bb/fetch2/__init__.py", line 1015, in unpack
>>> | ERROR:     ud.method.unpack(ud, root, self.d)
>>> | ERROR:
>>> | ERROR:   File "/OE/tentacle/sources/bitbake/lib/bb/fetch2/__init__.py", line 724, in unpack
>>> | ERROR:     cmd = 'tar -cf - -C "%d" -ps . | tar -xf - -C "%s/%s/"' % (file, rootdir, destdir)
>>
>> Does not changing this "%d" to "%s" work?
>
> Yes, this is the correct fix.  Nobody has been around today to push the fix into
> the tree however.
>
> It was a simple typo.

I managed to catch Richard on IRC about an hour ago and he pushed a fix 
to master.

Scott

-- 
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Master build error caused a small typo by commit today : fetch2: unpack revision
  2011-02-13  1:02             ` Scott Garman
@ 2011-02-13  7:12               ` Ke, Liping
  2011-02-13 19:27                 ` Mark Hatle
  0 siblings, 1 reply; 10+ messages in thread
From: Ke, Liping @ 2011-02-13  7:12 UTC (permalink / raw)
  To: Garman, Scott A, yocto@yoctoproject.org

> >> Does not changing this "%d" to "%s" work?
> >
> > Yes, this is the correct fix.  Nobody has been around today to push
> the fix into
> > the tree however.
> >
> > It was a simple typo.
> 
> I managed to catch Richard on IRC about an hour ago and he pushed a fix
> to master.
> 
> Scott

Hi, Scott and Mark,
After fixing the typo, we'll meet another error relates to the tar/untar change for preserving the hard link (mark's comments). I wrote it in another letter as below.
If we revert the patch, seems we need to rebuild from scratch, otherwise, I met other problems. Only for your info!

Thanks a lot!
Criping

Pasted Info:


After fixing this typo, I found another error when bitbake xorg-minimal-fonts, It will report
ERROR: Function 'org-minial-fonts: LIC_FILES_CHKSUM points to invalid file: ../misc/fonts/alias' failed

I checked the folder of build/tmp/work/all-poky-linux/xorg-minimal-fonts-1_1.0-r0, fonts.alias fonts.dir Cursor.pcf.gz we not under misc subfolder as its expectation, but on the outer folder, seems the SRC_URI="file://misc" defined in the Xorg-minimal-fonts.bb does not work.


> 
> --
> Scott Garman
> Embedded Linux Engineer - Yocto Project
> Intel Open Source Technology Center
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Master build error caused a small typo by commit today : fetch2: unpack revision
  2011-02-13  7:12               ` Ke, Liping
@ 2011-02-13 19:27                 ` Mark Hatle
  0 siblings, 0 replies; 10+ messages in thread
From: Mark Hatle @ 2011-02-13 19:27 UTC (permalink / raw)
  To: Ke, Liping; +Cc: yocto@yoctoproject.org, Garman, Scott A

I verified, I'm not getting this error on a clean checkout of Poky.  So the
issue has been reverted by going back to the 'cp'

I'll work on figuring out what the issue is and resolve it.

--Mark

On 2/13/11 1:12 AM, Ke, Liping wrote:
>>>> Does not changing this "%d" to "%s" work?
>>>
>>> Yes, this is the correct fix.  Nobody has been around today to push
>> the fix into
>>> the tree however.
>>>
>>> It was a simple typo.
>>
>> I managed to catch Richard on IRC about an hour ago and he pushed a fix
>> to master.
>>
>> Scott
> 
> Hi, Scott and Mark,
> After fixing the typo, we'll meet another error relates to the tar/untar change for preserving the hard link (mark's comments). I wrote it in another letter as below.
> If we revert the patch, seems we need to rebuild from scratch, otherwise, I met other problems. Only for your info!
> 
> Thanks a lot!
> Criping
> 
> Pasted Info:
> 
> 
> After fixing this typo, I found another error when bitbake xorg-minimal-fonts, It will report
> ERROR: Function 'org-minial-fonts: LIC_FILES_CHKSUM points to invalid file: ../misc/fonts/alias' failed
> 
> I checked the folder of build/tmp/work/all-poky-linux/xorg-minimal-fonts-1_1.0-r0, fonts.alias fonts.dir Cursor.pcf.gz we not under misc subfolder as its expectation, but on the outer folder, seems the SRC_URI="file://misc" defined in the Xorg-minimal-fonts.bb does not work.
> 
> 
>>
>> --
>> Scott Garman
>> Embedded Linux Engineer - Yocto Project
>> Intel Open Source Technology Center
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2011-02-13 19:27 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-12  5:05 Master build error caused a small typo by commit today : fetch2: unpack revision Ke, Liping
2011-02-12  7:53 ` Ke, Liping
2011-02-12  9:30   ` Cui, Dexuan
2011-02-12 18:09     ` Mark Hatle
2011-02-12 19:08       ` Koen Kooi
2011-02-12 19:17         ` Gary Thomas
2011-02-12 22:38           ` Mark Hatle
2011-02-13  1:02             ` Scott Garman
2011-02-13  7:12               ` Ke, Liping
2011-02-13 19:27                 ` Mark Hatle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.