From: fabio.estevam@freescale.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 16/17] mc13xxx: mfd_cell is now implicitly available to drivers
Date: Wed, 16 Feb 2011 10:31:10 -0200 [thread overview]
Message-ID: <4D5BC38E.1060009@freescale.com> (raw)
In-Reply-To: <20110216094154.GV13279@pengutronix.de>
Hi Uwe,
On 2/16/2011 7:41 AM, Uwe Kleine-K?nig wrote:
...
>> /* MC13783 */
>> -static struct mc13783_platform_data mc13783_pdata __initdata = {
> isn't using __initdata here broken already before your patch? Was
> introduced in c67a3e09. Fabio?
I followed the same approach as in mx31_3ds.c file.
> But in general I'd prefer to keep as much __initdata as possible because
> this occupies less memory when using a multi-machine kernel.
Ok, is the __initdata usage correct then? If not, I can change it. Just let me know.
Regards,
Fabio Estevam
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <fabio.estevam@freescale.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Andres Salomon <dilinger@queued.net>,
Samuel Ortiz <sameo@linux.intel.com>,
<linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Russell King <linux@arm.linux.org.uk>,
Sascha Hauer <kernel@pengutronix.de>,
Richard Purdie <rpurdie@rpsys.net>,
Liam Girdwood <lrg@slimlogic.co.uk>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 16/17] mc13xxx: mfd_cell is now implicitly available to drivers
Date: Wed, 16 Feb 2011 10:31:10 -0200 [thread overview]
Message-ID: <4D5BC38E.1060009@freescale.com> (raw)
In-Reply-To: <20110216094154.GV13279@pengutronix.de>
Hi Uwe,
On 2/16/2011 7:41 AM, Uwe Kleine-König wrote:
...
>> /* MC13783 */
>> -static struct mc13783_platform_data mc13783_pdata __initdata = {
> isn't using __initdata here broken already before your patch? Was
> introduced in c67a3e09. Fabio?
I followed the same approach as in mx31_3ds.c file.
> But in general I'd prefer to keep as much __initdata as possible because
> this occupies less memory when using a multi-machine kernel.
Ok, is the __initdata usage correct then? If not, I can change it. Just let me know.
Regards,
Fabio Estevam
next prev parent reply other threads:[~2011-02-16 12:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 2:19 [PATCH 16/17] mc13xxx: mfd_cell is now implicitly available to drivers Andres Salomon
2011-02-12 2:19 ` Andres Salomon
2011-02-16 9:41 ` Uwe Kleine-König
2011-02-16 9:41 ` Uwe Kleine-König
2011-02-16 12:26 ` Fabio Estevam
2011-02-16 12:26 ` Fabio Estevam
2011-02-16 12:31 ` Fabio Estevam [this message]
2011-02-16 12:31 ` Fabio Estevam
2011-02-16 12:58 ` Uwe Kleine-König
2011-02-17 11:53 ` Fabio Estevam
2011-02-17 13:10 ` Uwe Kleine-König
2011-02-19 3:31 ` Fabio Estevam
2011-02-16 17:00 ` Andres Salomon
2011-02-16 17:00 ` Andres Salomon
2011-02-18 8:39 ` Uwe Kleine-König
2011-02-18 8:39 ` Uwe Kleine-König
2011-02-18 17:50 ` Andres Salomon
2011-02-18 17:50 ` Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5BC38E.1060009@freescale.com \
--to=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.