All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] fix the build of mklibs-native on Ubuntu 9.04
@ 2011-02-16  9:35 Dexuan Cui
  2011-02-16  9:35 ` [PATCH 1/1] mklibs-native: fix the build on Ubuntu 9.04 by defining STT_GNU_IFUNC Dexuan Cui
  2011-02-16 21:32 ` [PATCH 0/1] fix the build of mklibs-native on Ubuntu 9.04 Tom Rini
  0 siblings, 2 replies; 5+ messages in thread
From: Dexuan Cui @ 2011-02-16  9:35 UTC (permalink / raw)
  To: poky

From: Dexuan Cui <dexuan.cui@intel.com>

libc6-dev in Ubuntu 9.04 is so old that the elf.h doesn't define
STT_GNU_IFUNC, so we have to define it ourselves.

Pull URL: git://git.pokylinux.org/poky-contrib.git
  Branch: dcui/master
  Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dcui/master

Thanks,
    Dexuan Cui <dexuan.cui@intel.com>
---


Dexuan Cui (1):
  mklibs-native: fix the build on Ubuntu 9.04 by defining STT_GNU_IFUNC

 .../mklibs/files/fix_STT_GNU_IFUNC.patch           |   23 ++++++++++++++++++++
 .../mklibs/mklibs-native_0.1.31.bb                 |    3 +-
 2 files changed, 25 insertions(+), 1 deletions(-)
 create mode 100644 meta/recipes-devtools/mklibs/files/fix_STT_GNU_IFUNC.patch

-- 
1.7.2



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/1] mklibs-native: fix the build on Ubuntu 9.04 by defining STT_GNU_IFUNC
  2011-02-16  9:35 [PATCH 0/1] fix the build of mklibs-native on Ubuntu 9.04 Dexuan Cui
@ 2011-02-16  9:35 ` Dexuan Cui
  2011-02-16 21:32 ` [PATCH 0/1] fix the build of mklibs-native on Ubuntu 9.04 Tom Rini
  1 sibling, 0 replies; 5+ messages in thread
From: Dexuan Cui @ 2011-02-16  9:35 UTC (permalink / raw)
  To: poky

From: Dexuan Cui <dexuan.cui@intel.com>

mklibs-native needs elf.h (that is supplied by libc6-dev).
since STAGING_INCDIR_NATIVE doesn't contain elf.h (we don't have eglibc-native),
so the host's /usr/include/elf.h is used.
Unluckily, the libc6-dev in Ubuntu 9.04 is so old that the elf.h doesn't
define STT_GNU_IFUNC, so we have to define it ourselves.

Fixes [BUGID #726]

Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
---
 .../mklibs/files/fix_STT_GNU_IFUNC.patch           |   23 ++++++++++++++++++++
 .../mklibs/mklibs-native_0.1.31.bb                 |    3 +-
 2 files changed, 25 insertions(+), 1 deletions(-)
 create mode 100644 meta/recipes-devtools/mklibs/files/fix_STT_GNU_IFUNC.patch

diff --git a/meta/recipes-devtools/mklibs/files/fix_STT_GNU_IFUNC.patch b/meta/recipes-devtools/mklibs/files/fix_STT_GNU_IFUNC.patch
new file mode 100644
index 0000000..88badde
--- /dev/null
+++ b/meta/recipes-devtools/mklibs/files/fix_STT_GNU_IFUNC.patch
@@ -0,0 +1,23 @@
+The libc6-dev in Ubuntu 9.04 is so old that the elf.h doesn't
+define STT_GNU_IFUNC, so we have to define it ourselves.
+-- Dexuan Cui (dexuan.cui@intel.com) Feb 16, 2011.
+
+diff --git a/src/mklibs-readelf/main.cpp b/src/mklibs-readelf/main.cpp
+index 2444c39..56d93f8 100644
+--- a/src/mklibs-readelf/main.cpp
++++ b/src/mklibs-readelf/main.cpp
+@@ -6,6 +6,14 @@
+ #include <vector>
+ 
+ #include <elf.h>
++/*
++ * The /usr/include/elf.h in some distributions(like Ubuntu 9.04) doesn't
++ * define the macro. We need to define it here.
++ */
++#ifndef STT_GNU_IFUNC
++#define STT_GNU_IFUNC   10              /* Symbol is indirect code object */
++#endif
++
+ #include <getopt.h>
+ 
+ #include "elf.hpp"
diff --git a/meta/recipes-devtools/mklibs/mklibs-native_0.1.31.bb b/meta/recipes-devtools/mklibs/mklibs-native_0.1.31.bb
index 2044d12..7f4afc0 100644
--- a/meta/recipes-devtools/mklibs/mklibs-native_0.1.31.bb
+++ b/meta/recipes-devtools/mklibs/mklibs-native_0.1.31.bb
@@ -5,10 +5,11 @@ LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://debian/copyright;md5=98d31037b13d896e33890738ef01af64"
 DEPENDS = "python-native"
 
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "http://ftp.de.debian.org/debian/pool/main/m/mklibs/${BPN}_${PV}.tar.gz \
 	file://ac_init_fix.patch\
+	file://fix_STT_GNU_IFUNC.patch\
 "
 
 SRC_URI[md5sum] = "f4df0307ccbdf60070e42277513f27ed"
-- 
1.7.2



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/1] fix the build of mklibs-native on Ubuntu 9.04
  2011-02-16  9:35 [PATCH 0/1] fix the build of mklibs-native on Ubuntu 9.04 Dexuan Cui
  2011-02-16  9:35 ` [PATCH 1/1] mklibs-native: fix the build on Ubuntu 9.04 by defining STT_GNU_IFUNC Dexuan Cui
@ 2011-02-16 21:32 ` Tom Rini
  2011-02-16 22:20   ` Mark Hatle
  1 sibling, 1 reply; 5+ messages in thread
From: Tom Rini @ 2011-02-16 21:32 UTC (permalink / raw)
  To: poky

On 02/16/2011 02:35 AM, Dexuan Cui wrote:
> From: Dexuan Cui<dexuan.cui@intel.com>
>
> libc6-dev in Ubuntu 9.04 is so old that the elf.h doesn't define
> STT_GNU_IFUNC, so we have to define it ourselves.
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>    Branch: dcui/master
>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dcui/master

Is this also an issue on 8.04?  9.04 isn't supported anymore (9.10, 
10.04, 10.10 are the top 3) but 8.04 is still under LTS in various 
configurations.

-- 
Tom Rini
Mentor Graphics Corporation


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/1] fix the build of mklibs-native on Ubuntu 9.04
  2011-02-16 21:32 ` [PATCH 0/1] fix the build of mklibs-native on Ubuntu 9.04 Tom Rini
@ 2011-02-16 22:20   ` Mark Hatle
  2011-02-17  6:42     ` Cui, Dexuan
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Hatle @ 2011-02-16 22:20 UTC (permalink / raw)
  To: poky

On 2/16/11 3:32 PM, Tom Rini wrote:
> On 02/16/2011 02:35 AM, Dexuan Cui wrote:
>> From: Dexuan Cui<dexuan.cui@intel.com>
>>
>> libc6-dev in Ubuntu 9.04 is so old that the elf.h doesn't define
>> STT_GNU_IFUNC, so we have to define it ourselves.
>>
>> Pull URL: git://git.pokylinux.org/poky-contrib.git
>>    Branch: dcui/master
>>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dcui/master
> 
> Is this also an issue on 8.04?  9.04 isn't supported anymore (9.10, 
> 10.04, 10.10 are the top 3) but 8.04 is still under LTS in various 
> configurations.
> 

9.04 may not be supported by Ubuntu anymore, but I've got lots of commercial
customers still using 9.04.. :(   (I suspect it is also a problem w/ 8.04)


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/1] fix the build of mklibs-native on Ubuntu 9.04
  2011-02-16 22:20   ` Mark Hatle
@ 2011-02-17  6:42     ` Cui, Dexuan
  0 siblings, 0 replies; 5+ messages in thread
From: Cui, Dexuan @ 2011-02-17  6:42 UTC (permalink / raw)
  To: 'Mark Hatle', poky@yoctoproject.org

Mark Hatle wrote:
> On 2/16/11 3:32 PM, Tom Rini wrote:
>> On 02/16/2011 02:35 AM, Dexuan Cui wrote:
>>> From: Dexuan Cui<dexuan.cui@intel.com>
>>> 
>>> libc6-dev in Ubuntu 9.04 is so old that the elf.h doesn't define
>>> STT_GNU_IFUNC, so we have to define it ourselves.
>>> 
>>> Pull URL: git://git.pokylinux.org/poky-contrib.git
>>>    Branch: dcui/master
>>>    Browse:
>>> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dcui/master 
>> 
>> Is this also an issue on 8.04?  9.04 isn't supported anymore (9.10,
>> 10.04, 10.10 are the top 3) but 8.04 is still under LTS in various
>> configurations. 
>> 
> 
> 9.04 may not be supported by Ubuntu anymore, but I've got lots of
> commercial customers still using 9.04.. :(  
Me too...
I'll try to update to 11.04 in three months when it's released. :-)

> (I suspect it is also a problem w/ 8.04) 
I also suspect that though I can't find a 8.04 host to try it.

Thanks,
-- Dexuan

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-02-17  6:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-16  9:35 [PATCH 0/1] fix the build of mklibs-native on Ubuntu 9.04 Dexuan Cui
2011-02-16  9:35 ` [PATCH 1/1] mklibs-native: fix the build on Ubuntu 9.04 by defining STT_GNU_IFUNC Dexuan Cui
2011-02-16 21:32 ` [PATCH 0/1] fix the build of mklibs-native on Ubuntu 9.04 Tom Rini
2011-02-16 22:20   ` Mark Hatle
2011-02-17  6:42     ` Cui, Dexuan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.