All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengzhe Zhang <fengzhe.zhang@intel.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel <xen-devel@lists.xensource.com>,
	"Dong, Eddie" <eddie.dong@intel.com>,
	"Li, Xin" <xin.li@intel.com>,
	yunhong.jiang@intel.com
Subject: Re: [PATCH] iomem: Prevent Dom0 pci bus from allocating RAM as I/O space
Date: Thu, 17 Feb 2011 13:32:15 +0800	[thread overview]
Message-ID: <4D5CB2DF.80604@intel.com> (raw)
In-Reply-To: <20110216154759.GA3921@dumpdata.com>

On 2011/2/16 23:47, Konrad Rzeszutek Wilk wrote:
> On Wed, Feb 16, 2011 at 10:20:21AM -0500, Konrad Rzeszutek Wilk wrote:
>> On Wed, Feb 16, 2011 at 10:06:38AM -0500, Konrad Rzeszutek Wilk wrote:
>>> On Wed, Feb 16, 2011 at 10:26:20PM +0800, Zhang, Fengzhe wrote:
>>>> iomem: Prevent Dom0 pci bus from allocating RAM as I/O space
>>>
>>> Is there a bug # associated with this? Is this associated with the intel-agp
>>> driver trying to ioremap the scratch page and bombing out?
>
> Also did you try to revert 0b56d9994ebe34df77fa156d2068ad93b7877b44 and see
> how that works? Here is the revert attached
>

I tried this patch and it can indeed avoid system crash.

However, I still doubt if the igb device is working correctly. The 
sequence that igb driver do ioremap is like this:

1. igb calls function pci_ubs_alloc_resource to get some non-RAM pages.
2. igb sets the phys_addr of the pages in some BAR.
3. igb ioremaps these pages.

After patching, it looks like ioremap gets some mfn allocated by Xen. 
But what set in BAR is still phys_addr. If igb device tries to access 
the pages directly, would Xen be able to intercept and translate it? And 
also, how the contiguity of mfns be guaranteed?

-Fengzhe

  reply	other threads:[~2011-02-17  5:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-16 14:26 [PATCH] iomem: Prevent Dom0 pci bus from allocating RAM as I/O space Zhang, Fengzhe
2011-02-16 15:06 ` Konrad Rzeszutek Wilk
2011-02-16 15:20   ` Konrad Rzeszutek Wilk
2011-02-16 15:47     ` Konrad Rzeszutek Wilk
2011-02-17  5:32       ` Fengzhe Zhang [this message]
2011-02-17 14:23         ` [PATCH] iomem: Prevent Dom0 pci bus from allocating RAM as I/O space in 2.6.32.27 tree Konrad Rzeszutek Wilk
2011-02-17 15:07           ` Li, Xin
2011-02-17 15:35             ` Konrad Rzeszutek Wilk
2011-02-18 15:16         ` [PATCH] iomem: Prevent Dom0 pci bus from allocating RAM as I/O space Konrad Rzeszutek Wilk
2011-02-20 13:58           ` Fengzhe Zhang
2011-02-17  4:11   ` Fengzhe Zhang
2011-02-18 22:05 ` Konrad Rzeszutek Wilk
2011-02-20 14:14   ` Fengzhe Zhang
2011-02-21 10:35     ` Li, Xin
2011-02-21 19:20       ` Konrad Rzeszutek Wilk
2011-02-22  4:55         ` Li, Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5CB2DF.80604@intel.com \
    --to=fengzhe.zhang@intel.com \
    --cc=eddie.dong@intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xin.li@intel.com \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.