From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Cc: netdev@vger.kernel.org, SH-Linux <linux-sh@vger.kernel.org>
Subject: Re: [RFC, PATCH 2/4] net: sh_eth: remove the SH_TSU_ADDR
Date: Thu, 17 Feb 2011 06:51:44 +0000 [thread overview]
Message-ID: <4D5CC580.9080905@renesas.com> (raw)
In-Reply-To: <AANLkTimJM0yEOU6RgoAs+Njv5b7ixVRnPubnUg=F72GX@mail.gmail.com>
2011/02/17 9:24, Nobuhiro Iwamatsu wrote:
>> @@ -1559,7 +1565,9 @@ out:
>> static int sh_eth_drv_remove(struct platform_device *pdev)
>> {
>> struct net_device *ndev = platform_get_drvdata(pdev);
>> + struct sh_eth_private *mdp = netdev_priv(ndev);
>>
>> + iounmap(mdp->tsu_addr);
>> sh_mdio_release(ndev);
>> unregister_netdev(ndev);
>> pm_runtime_disable(&pdev->dev);
>
> You forget to fix for ARSTR.
Thank you for your point! I will fix it.
Best regards,
Yoshihiro Shimoda
WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Cc: netdev@vger.kernel.org, SH-Linux <linux-sh@vger.kernel.org>
Subject: Re: [RFC, PATCH 2/4] net: sh_eth: remove the SH_TSU_ADDR
Date: Thu, 17 Feb 2011 15:51:44 +0900 [thread overview]
Message-ID: <4D5CC580.9080905@renesas.com> (raw)
In-Reply-To: <AANLkTimJM0yEOU6RgoAs+Njv5b7ixVRnPubnUg=F72GX@mail.gmail.com>
2011/02/17 9:24, Nobuhiro Iwamatsu wrote:
>> @@ -1559,7 +1565,9 @@ out:
>> static int sh_eth_drv_remove(struct platform_device *pdev)
>> {
>> struct net_device *ndev = platform_get_drvdata(pdev);
>> + struct sh_eth_private *mdp = netdev_priv(ndev);
>>
>> + iounmap(mdp->tsu_addr);
>> sh_mdio_release(ndev);
>> unregister_netdev(ndev);
>> pm_runtime_disable(&pdev->dev);
>
> You forget to fix for ARSTR.
Thank you for your point! I will fix it.
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2011-02-17 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 11:47 [RFC, PATCH 2/4] net: sh_eth: remove the SH_TSU_ADDR Yoshihiro Shimoda
2011-02-15 11:47 ` Yoshihiro Shimoda
2011-02-17 0:24 ` Nobuhiro Iwamatsu
2011-02-17 0:24 ` Nobuhiro Iwamatsu
2011-02-17 6:51 ` Yoshihiro Shimoda [this message]
2011-02-17 6:51 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5CC580.9080905@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=iwamatsu@nigauri.org \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.