Re: [RFC PATCH 1/6] isci: initialization

[Jeff Garzik <jeff@garzik.org>]

On 02/06/2011 07:34 PM, Dan Williams wrote:
> +irqreturn_t isci_isr(int vec, void *data)
> +{
> +	struct isci_host *isci_host
> +		= (struct isci_host *)data;
> +	struct scic_controller_handler_methods *handlers
> +		=&isci_host->scic_irq_handlers[SCI_MSIX_NORMAL_VECTOR];
> +	irqreturn_t ret = IRQ_NONE;
> +
> +	if (isci_host_get_state(isci_host) != isci_starting
> +	&&  handlers->interrupt_handler) {
> +
> +		if (handlers->interrupt_handler(isci_host->core_controller)) {
> +			if (isci_host_get_state(isci_host) != isci_stopped) {
> +				tasklet_schedule(
> +					&isci_host->completion_tasklet);
> +			} else
> +				dev_dbg(&isci_host->pdev->dev,
> +					"%s: controller stopped\n",
> +					__func__);
> +			ret = IRQ_HANDLED;
> +		}
> +	} else
> +		dev_warn(&isci_host->pdev->dev,
> +			 "%s: get_handler_methods failed, "
> +			 "isci_host->status = 0x%x\n",
> +			 __func__,
> +			 isci_host_get_state(isci_host));
> +
> +	return ret;
> +}

Obviously my grep-fu is failing me...  where is interrupt_handler 
assigned a value?  Creating a pointer for the interrupt handler, rather 
than directly registering the proper callback with the kernel, seems a 
bit odd.

	Jeff