From: Paolo Bonzini <pbonzini@redhat.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: [Qemu-devel] Re: [PATCH v2] tracetool: Add optional argument to specify dtrace probe names
Date: Thu, 17 Feb 2011 13:29:27 +0100 [thread overview]
Message-ID: <4D5D14A7.6090007@redhat.com> (raw)
In-Reply-To: <4D5D1235.70202@redhat.com>
On 02/17/2011 01:19 PM, Jes Sorensen wrote:
> On 02/17/11 13:16, Paolo Bonzini wrote:
>> On 02/15/2011 01:34 PM, Jes.Sorensen@redhat.com wrote:
>>> - if [ -z "$binary" ]; then
>>> + if [ -z "$probeprefix" -a -z "$binary" ]; then
>>> echo "--binary is required for SystemTAP tapset generator"
>>> exit 1
>>> fi
>>
>> --binary is always required, even with --probe-prefix, since it is used for
>>
>> +probe $probeprefix.$name = process("$binary").mark("$name")
>
> if I broke something with this
No, you didn't break anything. It's just that someone patching the
Makefile like you did in 2/2 might.
Paolo
next prev parent reply other threads:[~2011-02-17 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 12:34 [Qemu-devel] [PATCH v2] tracetool: Add optional argument to specify dtrace probe names Jes.Sorensen
2011-02-15 13:01 ` Stefan Hajnoczi
2011-02-17 12:16 ` [Qemu-devel] " Paolo Bonzini
2011-02-17 12:19 ` Jes Sorensen
2011-02-17 12:29 ` Paolo Bonzini [this message]
2011-02-17 12:30 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5D14A7.6090007@redhat.com \
--to=pbonzini@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.